From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) by dpdk.org (Postfix) with ESMTP id AF9AC1B559 for ; Wed, 17 Apr 2019 02:34:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vE1OBpc7kjBlJso9ZeFJVaIkYNIDmotXf/Id5qc55cs=; b=cjVkCS5O+S8uBf9vRhfmOPj8/mWeJKLpnDMWO8IQ2WX6LNT9iwM1o9ZP7NvxegOdsPUi31VcmYAaOEEo1NrwSI+crGQJJiYKoe4YTG0lEtWcz3CFYOHrxHWczMTTp95isguLSM/WofaOobwQO7ifcojQ9/oPGJfnOI3DrygsjGg= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4060.eurprd05.prod.outlook.com (52.134.72.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 00:34:28 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 00:34:28 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU9LVQnLsvTu10LkeaTvPDpw0Pjw== Date: Wed, 17 Apr 2019 00:34:28 +0000 Message-ID: <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb81de79-a968-4f08-4f6d-08d6c2cc734a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4060; x-ms-traffictypediagnostic: DB3PR0502MB4060: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(396003)(366004)(346002)(189003)(199004)(37006003)(81166006)(81156014)(316002)(53546011)(6862004)(105586002)(2906002)(25786009)(8936002)(4326008)(97736004)(106356001)(6506007)(478600001)(486006)(476003)(6512007)(76176011)(6246003)(256004)(54906003)(68736007)(53936002)(14454004)(86362001)(33656002)(229853002)(6116002)(2616005)(82746002)(11346002)(6436002)(3846002)(66066001)(5660300002)(186003)(6636002)(36756003)(446003)(305945005)(7736002)(26005)(71190400001)(102836004)(71200400001)(83716004)(99286004)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4060; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: p2LuGBukcEb293zBY+G0Zrk0zwfIxUEo0kBy6xAHcdGYjskfvFcCk7yZHnudooQjeG2fUszcByImvKQ0PjlUYi2RQshOFvqNU443Fr9uaBgEN8nz2/HHrlUEDSDNwJlrBJngoO+dEMeJ4wHczYrXJqu8kqh+4/X3YS9pl/NtJMKj+AgPnUX7XPyeCiBECY5EuwfxwRog8vazDCyBnl3nSvydSxCtDHa+TEGphULhapDOFya2qLOFT1pb3Y2CTVq0VHGlJqWk6gfXdSVF3g8AeRb2HSZ8EAYTTON84LKeAUC3Ewj0J92/mEiU1JlbSpkahDhK41rXVqaj50GN1QdytgvEF7AMY65/f+EVUmri9uqHnNfchWbs8NPLrS1dQMIqIViLH39APS0znQPdzlZ0GtGe9G9G0Bh2imdNTg5SHew= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb81de79-a968-4f08-4f6d-08d6c2cc734a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 00:34:28.1539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4060 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 00:34:30 -0000 > On Apr 16, 2019, at 5:01 PM, Yongseok Koh wrote: >=20 > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: >> The meson build was missing the define for Direct Rules. And a typo in the title. menson -> meson Also would be better to use 'meson build' instead of 'meson compilation' "net/mlx5: fix meson build for Direct Rules" >>=20 >> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >> Cc: orika@mellanox.com >>=20 >> Signed-off-by: Ori Kam >> --- >> drivers/net/mlx5/meson.build | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build >> index a4c684e..0037e15 100644 >> --- a/drivers/net/mlx5/meson.build >> +++ b/drivers/net/mlx5/meson.build >> @@ -111,6 +111,8 @@ if build >> 'mlx5dv_devx_obj_create' ], >> [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', >> 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], >> + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', >> + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], >=20 > Better to change the inconsistent naming? > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES >=20 > And I want it to be at a similar location to Makefile. Let's put it next = to > HAVE_IBV_FLOW_DV_SUPPORT. >=20 > thanks > Yongseok >=20 >> [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', >> 'SUPPORTED_40000baseKR4_Full' ], >> [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', >> --=20 >> 1.8.3.1 >>=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2358AA00E6 for ; Wed, 17 Apr 2019 02:34:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09D291B55B; Wed, 17 Apr 2019 02:34:32 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) by dpdk.org (Postfix) with ESMTP id AF9AC1B559 for ; Wed, 17 Apr 2019 02:34:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vE1OBpc7kjBlJso9ZeFJVaIkYNIDmotXf/Id5qc55cs=; b=cjVkCS5O+S8uBf9vRhfmOPj8/mWeJKLpnDMWO8IQ2WX6LNT9iwM1o9ZP7NvxegOdsPUi31VcmYAaOEEo1NrwSI+crGQJJiYKoe4YTG0lEtWcz3CFYOHrxHWczMTTp95isguLSM/WofaOobwQO7ifcojQ9/oPGJfnOI3DrygsjGg= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4060.eurprd05.prod.outlook.com (52.134.72.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Wed, 17 Apr 2019 00:34:28 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 00:34:28 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU9LVQnLsvTu10LkeaTvPDpw0Pjw== Date: Wed, 17 Apr 2019 00:34:28 +0000 Message-ID: <4610A325-1FF4-4B16-98B1-2F4177D84C8B@mellanox.com> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb81de79-a968-4f08-4f6d-08d6c2cc734a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4060; x-ms-traffictypediagnostic: DB3PR0502MB4060: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(396003)(366004)(346002)(189003)(199004)(37006003)(81166006)(81156014)(316002)(53546011)(6862004)(105586002)(2906002)(25786009)(8936002)(4326008)(97736004)(106356001)(6506007)(478600001)(486006)(476003)(6512007)(76176011)(6246003)(256004)(54906003)(68736007)(53936002)(14454004)(86362001)(33656002)(229853002)(6116002)(2616005)(82746002)(11346002)(6436002)(3846002)(66066001)(5660300002)(186003)(6636002)(36756003)(446003)(305945005)(7736002)(26005)(71190400001)(102836004)(71200400001)(83716004)(99286004)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4060; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: p2LuGBukcEb293zBY+G0Zrk0zwfIxUEo0kBy6xAHcdGYjskfvFcCk7yZHnudooQjeG2fUszcByImvKQ0PjlUYi2RQshOFvqNU443Fr9uaBgEN8nz2/HHrlUEDSDNwJlrBJngoO+dEMeJ4wHczYrXJqu8kqh+4/X3YS9pl/NtJMKj+AgPnUX7XPyeCiBECY5EuwfxwRog8vazDCyBnl3nSvydSxCtDHa+TEGphULhapDOFya2qLOFT1pb3Y2CTVq0VHGlJqWk6gfXdSVF3g8AeRb2HSZ8EAYTTON84LKeAUC3Ewj0J92/mEiU1JlbSpkahDhK41rXVqaj50GN1QdytgvEF7AMY65/f+EVUmri9uqHnNfchWbs8NPLrS1dQMIqIViLH39APS0znQPdzlZ0GtGe9G9G0Bh2imdNTg5SHew= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb81de79-a968-4f08-4f6d-08d6c2cc734a X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 00:34:28.1539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4060 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417003428.oN7t1owzNDlZ0OFUhbz-jy-V82lUHLHYwGwzlP7bqgk@z> > On Apr 16, 2019, at 5:01 PM, Yongseok Koh wrote: >=20 > On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: >> The meson build was missing the define for Direct Rules. And a typo in the title. menson -> meson Also would be better to use 'meson build' instead of 'meson compilation' "net/mlx5: fix meson build for Direct Rules" >>=20 >> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >> Cc: orika@mellanox.com >>=20 >> Signed-off-by: Ori Kam >> --- >> drivers/net/mlx5/meson.build | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build >> index a4c684e..0037e15 100644 >> --- a/drivers/net/mlx5/meson.build >> +++ b/drivers/net/mlx5/meson.build >> @@ -111,6 +111,8 @@ if build >> 'mlx5dv_devx_obj_create' ], >> [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', >> 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], >> + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', >> + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], >=20 > Better to change the inconsistent naming? > HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES >=20 > And I want it to be at a similar location to Makefile. Let's put it next = to > HAVE_IBV_FLOW_DV_SUPPORT. >=20 > thanks > Yongseok >=20 >> [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', >> 'SUPPORTED_40000baseKR4_Full' ], >> [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', >> --=20 >> 1.8.3.1 >>=20