DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Didier Pallard <didier.pallard@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/2] igb: release software locked semaphores	on initialization
Date: Wed, 09 Apr 2014 18:39:56 +0200	[thread overview]
Message-ID: <4611478.9TdyNLhD18@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EF95738@IRSMSX105.ger.corp.intel.com>

> It may happen that DPDK application gets killed while having acquired locks
> on the ethernet hardware, causing these locks to be never released. On next
> restart of the application, DPDK skip those ports because it can not
> acquire the lock, this may cause some ports (or even complete board if SMBI
> is locked) to be inaccessible from DPDK application until reboot of the
> hardware.
> 
> This patch release locks that are supposed to be locked due to an improper
> exit of the application.
> 
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied for version 1.6.0r2.

So the decision is to try not modify base driver.
But the fix should appear in the base driver one day and we must be careful 
when rebasing on an updated one.
In this case, the fix can be done on both side without being harmful.

Thanks for fixing this random failure.
-- 
Thomas

  reply	other threads:[~2014-04-09 16:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 11:59 [dpdk-dev] [RFC PATCH 1/2] e1000: " Didier Pallard
2014-02-19 11:59 ` [dpdk-dev] [RFC PATCH 2/2] ixgbe: " Didier Pallard
2014-02-19 12:41   ` Ananyev, Konstantin
2014-02-19 16:52     ` Thomas Monjalon
2014-02-19 17:51       ` Ananyev, Konstantin
2014-02-21 16:30         ` Ananyev, Konstantin
2014-02-24 14:19           ` didier.pallard
2014-02-24 15:34             ` Ananyev, Konstantin
2014-02-25  0:57             ` Ananyev, Konstantin
2014-02-26 10:52               ` didier.pallard
2014-04-08 13:29                 ` [dpdk-dev] [PATCH v3 1/2] " Didier Pallard
2014-04-08 13:29                   ` [dpdk-dev] [PATCH v3 2/2] igb: " Didier Pallard
2014-04-09 15:58                     ` Ananyev, Konstantin
2014-04-09 16:39                       ` Thomas Monjalon [this message]
2014-04-09 15:49                   ` [dpdk-dev] [PATCH v3 1/2] ixgbe: " Ananyev, Konstantin
2014-04-09 16:37                     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4611478.9TdyNLhD18@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).