From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E74891B8DA;
Tue, 10 Apr 2018 10:29:20 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 5AF6220CE5;
Tue, 10 Apr 2018 04:29:20 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 10 Apr 2018 04:29:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=KJCC7ijMYCyBQfgOkSJdSsBLd8
zrQfToYbSqT3L8qrk=; b=IsDi21QkLr/nGBcdwdlLOyV4toHXLSnCAu83AIBJPh
G857L/1043B9kP2cSpD7N6Yzh5xmbCNp+XXAl8/83vYx6+Qv4JcfqKtTqdYGDRyP
/B65zHv+OkMyWl5W4o1wIe0TQmgi2V27YTEyhHsTkIfs2dFU66v5ONQfGY+K/kGq
A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=KJCC7i
jMYCyBQfgOkSJdSsBLd8zrQfToYbSqT3L8qrk=; b=N9ylEL1msff3OMAOnqvz2h
SbjRs0I7Q7IYDxyFCi7Hef50rqnGQCJZigBADr9tzFAptjofAUvaAdQHLtaWImi5
Y+C0ne4IUoN2N4yjFDBH6KuSzdXkjmTu90Acy70ew5cLM5f0jeAq3AgMPhFljMxg
kNORnYUuO/tqfIVfcijmn2YP+svn3qQv13y8uKSFQ1NZvKMp0wZb6/ZHc+2eagOC
87qxf4lR4K0Yi2Z0Sz9SNm4S15HZcTIYgAxy8AaVYGLd6R93687MqASs1dSeIEW8
Cz7gonASrbKz1QE9yDijc74ie1rUSVF+6BbcTPa7sMYKwkE6weJv7j7qcxevE+vQ
==
X-ME-Sender: <xms:4HXMWmuAzPVSVRfZSH-6wxtoyz_nL8IliFI23TsLaCAqJ-_buqa4mg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 67FABE4449;
Tue, 10 Apr 2018 04:29:19 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: =?ISO-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>,
ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org,
stephen@networkplumber.org
Date: Tue, 10 Apr 2018 10:29:18 +0200
Message-ID: <4616956.1DYh5m3MiB@xps>
In-Reply-To: <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com>
References: <20180410061631.50301-1-shahafs@mellanox.com>
<20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link status query
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 08:29:21 -0000
10/04/2018 10:20, N=E9lio Laranjeiro:
> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
> > When application works with LSC interrupts the ethdev layer skips
> > the PMD callback and update according to the link status exists on
> > device data. It is because it assumes the link status on the device data
> > is the correct one since any link change is processed by the applicatio=
n.
> >=20
> > As multiple PMDs install the link status interrupt handler only on port
> > start and uninstall it on port stop, the link status may be incorrect in
> > case the query is called after port stop or before port start.
>=20
> It seems also logical to not process interrupts from stopped device,
> for them accessing to the link status should always end by calling the
> devop function.
>=20
> This patch is the result of discussion on thread [1].
>=20
> > Fixing the query implementation to use the PMD callback for such cases.
> >=20
> > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
> > Cc: stable@dpdk.org
> > Cc: stephen@networkplumber.org
> > Cc: nelio.laranjeiro@6wind.com
>=20
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>=20
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Looks OK
Acked-by: Thomas Monjalon <thomas@monjalon.net>