* [dpdk-dev] [PATCH] pci:fix missing free
@ 2016-09-23 2:06 zhouyangchao
2016-09-23 8:46 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: zhouyangchao @ 2016-09-23 2:06 UTC (permalink / raw)
To: david.marchand; +Cc: dev, zhouyangchao
Signed-off-by: zhouyangchao <zhouyates@gmail.com>
---
lib/librte_eal/common/eal_common_pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 7248c38..eb44998 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr)
goto err_return;
TAILQ_REMOVE(&pci_device_list, dev, next);
+ free(dev);
return 0;
}
return -1;
--
1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] pci:fix missing free
2016-09-23 2:06 [dpdk-dev] [PATCH] pci:fix missing free zhouyangchao
@ 2016-09-23 8:46 ` Thomas Monjalon
2016-09-29 1:41 ` Yangchao Zhou
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2016-09-23 8:46 UTC (permalink / raw)
To: zhouyangchao; +Cc: dev, david.marchand
Hi,
2016-09-23 10:06, zhouyangchao:
> Signed-off-by: zhouyangchao <zhouyates@gmail.com>
Is your first name Yangchao and your surname Zhou?
If so, it would be:
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] pci:fix missing free
2016-09-23 8:46 ` Thomas Monjalon
@ 2016-09-29 1:41 ` Yangchao Zhou
2016-09-30 15:19 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Yangchao Zhou @ 2016-09-29 1:41 UTC (permalink / raw)
To: thomas.monjalon; +Cc: dev, david.marchand, Yangchao Zhou
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
lib/librte_eal/common/eal_common_pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 7248c38..eb44998 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr)
goto err_return;
TAILQ_REMOVE(&pci_device_list, dev, next);
+ free(dev);
return 0;
}
return -1;
--
1.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] pci:fix missing free
2016-09-29 1:41 ` Yangchao Zhou
@ 2016-09-30 15:19 ` David Marchand
2016-09-30 15:27 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2016-09-30 15:19 UTC (permalink / raw)
To: Yangchao Zhou; +Cc: Thomas Monjalon, dev, stable
Hello,
On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> lib/librte_eal/common/eal_common_pci.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
> index 7248c38..eb44998 100644
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr)
> goto err_return;
>
> TAILQ_REMOVE(&pci_device_list, dev, next);
> + free(dev);
> return 0;
> }
> return -1;
> --
> 1.7.1
>
For the title, how about:
pci: fix memory leak when detaching devices
Afaics the fixes tag would be :
Fixes: dbe6b4b61b0e ("pci: probe or close device")
+ CC stable
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] pci:fix missing free
2016-09-30 15:19 ` David Marchand
@ 2016-09-30 15:27 ` David Marchand
2016-10-04 8:07 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2016-09-30 15:27 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, stable, Yangchao Zhou
On Fri, Sep 30, 2016 at 5:19 PM, David Marchand
<david.marchand@6wind.com> wrote:
> Hello,
>
> On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
>> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
>> ---
>> lib/librte_eal/common/eal_common_pci.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
>> index 7248c38..eb44998 100644
>> --- a/lib/librte_eal/common/eal_common_pci.c
>> +++ b/lib/librte_eal/common/eal_common_pci.c
>> @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr)
>> goto err_return;
>>
>> TAILQ_REMOVE(&pci_device_list, dev, next);
>> + free(dev);
>> return 0;
>> }
>> return -1;
>> --
>> 1.7.1
>>
>
> For the title, how about:
> pci: fix memory leak when detaching devices
>
> Afaics the fixes tag would be :
>
> Fixes: dbe6b4b61b0e ("pci: probe or close device")
>
> + CC stable
Thomas, can you apply this with my ack ?
Thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] pci:fix missing free
2016-09-30 15:27 ` David Marchand
@ 2016-10-04 8:07 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-10-04 8:07 UTC (permalink / raw)
To: Yangchao Zhou; +Cc: David Marchand, dev, stable
2016-09-30 17:27, David Marchand:
> On Fri, Sep 30, 2016 at 5:19 PM, David Marchand
> <david.marchand@6wind.com> wrote:
> > Hello,
> >
> > On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
> >> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> >
> > For the title, how about:
> > pci: fix memory leak when detaching devices
> >
> > Afaics the fixes tag would be :
> >
> > Fixes: dbe6b4b61b0e ("pci: probe or close device")
> >
> > + CC stable
>
> Thomas, can you apply this with my ack ?
> Thanks.
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-04 8:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-23 2:06 [dpdk-dev] [PATCH] pci:fix missing free zhouyangchao
2016-09-23 8:46 ` Thomas Monjalon
2016-09-29 1:41 ` Yangchao Zhou
2016-09-30 15:19 ` David Marchand
2016-09-30 15:27 ` David Marchand
2016-10-04 8:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).