* [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path
@ 2020-06-10 13:30 Ciara Power
2020-06-10 13:38 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Ciara Power @ 2020-06-10 13:30 UTC (permalink / raw)
To: kevin.laatz; +Cc: dev, Ciara Power, bruce.richardson
The path to the socket when running the script as a regular user needed
to be updated to match the logic in EAL.
Fixes: 6a2967c112a3 ("usertools: add new telemetry script")
Cc: bruce.richardson@intel.com
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
usertools/dpdk-telemetry.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py
index afbf01b19..8e4039d57 100755
--- a/usertools/dpdk-telemetry.py
+++ b/usertools/dpdk-telemetry.py
@@ -78,6 +78,6 @@ def readline_complete(text, state):
for f in glob.glob('/var/run/dpdk/*/dpdk_telemetry.%s' % TELEMETRY_VERSION):
handle_socket(f)
# Path to sockets for processes run as a regular user
-for f in glob.glob('/run/user/%d/dpdk/*/dpdk_telemetry.%s' %
- (os.getuid(), TELEMETRY_VERSION)):
+for f in glob.glob('%s/dpdk/*/dpdk_telemetry.%s' %
+ (os.environ.get('XDG_RUNTIME_DIR', '/tmp'), TELEMETRY_VERSION)):
handle_socket(f)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path
2020-06-10 13:30 [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path Ciara Power
@ 2020-06-10 13:38 ` Bruce Richardson
2020-06-24 23:10 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-06-10 13:38 UTC (permalink / raw)
To: Ciara Power; +Cc: kevin.laatz, dev
On Wed, Jun 10, 2020 at 02:30:33PM +0100, Ciara Power wrote:
> The path to the socket when running the script as a regular user needed
> to be updated to match the logic in EAL.
>
> Fixes: 6a2967c112a3 ("usertools: add new telemetry script")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path
2020-06-10 13:38 ` Bruce Richardson
@ 2020-06-24 23:10 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-06-24 23:10 UTC (permalink / raw)
To: Ciara Power; +Cc: kevin.laatz, dev, Bruce Richardson, stable
10/06/2020 15:38, Bruce Richardson:
> On Wed, Jun 10, 2020 at 02:30:33PM +0100, Ciara Power wrote:
> > The path to the socket when running the script as a regular user needed
> > to be updated to match the logic in EAL.
> >
> > Fixes: 6a2967c112a3 ("usertools: add new telemetry script")
+Cc: stable@dpdk.org
(even if there is little chance someone wants to maintain DPDK 20.05)
> > Cc: bruce.richardson@intel.com
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > ---
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-24 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 13:30 [dpdk-dev] [PATCH] usertools: fix telemetry script user socket path Ciara Power
2020-06-10 13:38 ` Bruce Richardson
2020-06-24 23:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).