From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60F70A0A04; Fri, 15 Jan 2021 15:09:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47395141106; Fri, 15 Jan 2021 15:09:31 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 90396141101 for ; Fri, 15 Jan 2021 15:09:29 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id E517C5808CA; Fri, 15 Jan 2021 09:09:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 15 Jan 2021 09:09:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= E0z6I1C+4MzSyfHFonMCyXI9F9xMYD0SO/RMQdGsZMA=; b=Pi2KRvC+XIJQ72jg /hyEkzV4IAfwH5ku2FR8o96Nyw0KJvG5dotuSjvm3M2uIGM92kg4uSV0m39VPF57 q6dq2mVJ+Mv36PtrcbwmNXFnEjoR8u7MvAHQSFKpHLn6QLN+QO/JyjX7FFiEaPaI YvzJLj0wLZHFbbPlWIz3CITBdMvI9o5Pjxj4RELpam82MVKV3DBcp9hqKT1z4bG8 XLO8P5expjHnlSiFoEBr4lmAQybI5xg4pLnd7KHusbJ0cRnDWWAW2sqNIIAQPkOh YAXcIA6Yu8rtvgKJ8EaL+LOHqnLCRSeXaCsnN7p2UwWPPRarDRvSpaY4mfe3XiWk Y6jRbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=E0z6I1C+4MzSyfHFonMCyXI9F9xMYD0SO/RMQdGsZ MA=; b=haYhCTdSlitPzXPNbop852O01Uvj4kgQpFLjfgOXR9Dxafmi5toD7b+Jz YmhZ2mLdvMsUb2yF7El1ASFfLbvBrNgpaGn4t7uYl8kB3NSHqz5NQoJPZoWzlnda UmhYF33X8oGW+IVepOJ6kCC6cBxZDlUNzIo1oaVb1JZa4WCUGLi2udZhlQczirbH o5LNrCzorToQcj5CK/WhyvLyIihL0bolmJfJJbBFUjPiWOOjZKISwUUBAvjhjja9 hR1cyv/T87AHKNnXsr6GjXTGOaDvGKf5V83x6VtHv/IIYdeTiJxOFyp+f/s6OriD MZQbQfADFgN1sbzjYcVDgov8jbt1w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtddvgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8BACC24005D; Fri, 15 Jan 2021 09:09:26 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Andrew Rybchenko , Yipeng Wang , Sameh Gobriel , Konstantin Ananyev , Bernard Iremonger , Vladimir Medvedkin , Ori Kam , Honnappa Nagarahalli , Olivier Matz , Cristian Dumitrescu , adrien.mazarguil@6wind.com Date: Fri, 15 Jan 2021 15:09:25 +0100 Message-ID: <4629518.ttYPrCFMyY@thomas> In-Reply-To: <20210115115905.GB1487@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <9b696a65-2012-7ae8-d840-1515f8bf140b@intel.com> <20210115115905.GB1487@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/01/2021 12:59, Bruce Richardson: > On Fri, Jan 15, 2021 at 11:51:49AM +0000, Ferruh Yigit wrote: > > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > > To verify that all DPDK headers are ok for inclusion directly in a C > > > file, and are not missing any other pre-requisite headers, we can > > > auto-generate for each header an empty C file that includes that header. > > > Compiling these files will throw errors if any header has unmet > > > dependencies. > > > > > > The list of headers to check is based of the "headers" value returned from > > > each library's meson.build file. However, since not all headers are for > > > direct inclusion, add a build variable "headers_no_chkincs" to list those > > > headers and skip checking them. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > > > > v2: > > > * add maintainers entry > > > * distribute exception list among meson.build files. > > > > > > MAINTAINERS | 4 ++++ > > > app/chkincs/gen_c_file_for_header.py | 12 ++++++++++ > > > app/chkincs/main.c | 4 ++++ > > > app/chkincs/meson.build | 28 ++++++++++++++++++++++++ > > > > +1 to have this kind of tool to check, but it is not an application like > > others in the 'app' folder, what do you think placing it under 'devtools' or > > 'buildtools'? > > Couple of reasons why it's placed in app. > > 1. We previously had a "chkincs" app in DPDK which was kept in the app > folder > 2. It allows us to reuse the build infrastructure for building apps, rather > than reduplicating it. > 3. We don't have any compilable code currently in the devtools folder, and > even in buildtools the pmdinfogen app is going to go away. > > That being said, none of those reasons are major issues that can't be > worked around if the consensus is to move it. It could be easily in devtools if it was a script. By the way, we already have devtools/check-includes.sh If your solution is better, please remove this script.