From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix pdf doc rules order
Date: Wed, 01 Apr 2015 21:22:48 +0200 [thread overview]
Message-ID: <4634326.zks7bAtCIX@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F00D9C@IRSMSX103.ger.corp.intel.com>
2015-04-01 13:29, Mcnamara, John:
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Wednesday, April 1, 2015 1:31 PM
> > To: dev@dpdk.org
> > Cc: mukawa@igel.co.jp; Mcnamara, John; De Lara Guarch, Pablo
> > Subject: [PATCH v2] mk: fix pdf doc rules order
> >
> > From: John McNamara <john.mcnamara@intel.com>
> >
> > Re-ordered the guide-pdf-% and guide-% rules to allow the doc-guides-pdf
> > target to build with make 3.81. It builds unmodified with all later
> > versions of make.
> >
> > Reported-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > ---
> > v2: reorder also clean rules
>
> Hi Thomas,
>
> That is fine for consistency but there weren't any issues with "make doc-clean" and "make doc-guides-pdf-clean" in the V1 patch/original.
>
> But I'm fine with it like this as well.
>
> John.
Fixes: ebf8050afd44 ("doc: add pdf output")
Applied, thanks
prev parent reply other threads:[~2015-04-01 19:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 9:17 [dpdk-dev] Cannot build doc using DPDK-2.0.0-rc3 Tetsuya Mukawa
2015-04-01 9:29 ` De Lara Guarch, Pablo
2015-04-01 9:49 ` Tetsuya Mukawa
2015-04-01 10:08 ` Mcnamara, John
2015-04-01 10:13 ` Masaru Oki
2015-04-01 10:49 ` Mcnamara, John
2015-04-01 11:13 ` Mcnamara, John
2015-04-02 1:04 ` Tetsuya Mukawa
2015-04-01 11:32 ` [dpdk-dev] [PATCH] mk: fix for "make doc-guides-pdf" with make 3.81 John McNamara
2015-04-01 12:07 ` De Lara Guarch, Pablo
2015-04-01 12:31 ` [dpdk-dev] [PATCH v2] mk: fix pdf doc rules order Thomas Monjalon
2015-04-01 13:29 ` Mcnamara, John
2015-04-01 19:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4634326.zks7bAtCIX@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).