From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0068.outbound.protection.outlook.com [104.47.41.68]) by dpdk.org (Postfix) with ESMTP id CF32510B9F for ; Wed, 21 Dec 2016 10:47:05 +0100 (CET) Received: from BN6PR03CA0003.namprd03.prod.outlook.com (10.168.230.141) by BN6PR03MB2467.namprd03.prod.outlook.com (10.168.223.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11; Wed, 21 Dec 2016 09:47:04 +0000 Received: from BL2FFO11OLC011.protection.gbl (2a01:111:f400:7c09::180) by BN6PR03CA0003.outlook.office365.com (2603:10b6:404:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11 via Frontend Transport; Wed, 21 Dec 2016 09:47:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11OLC011.mail.protection.outlook.com (10.173.160.157) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Wed, 21 Dec 2016 09:47:04 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBL9l1mQ027710; Wed, 21 Dec 2016 02:47:02 -0700 To: Jan Blunck , References: <1482232315-21626-1-git-send-email-jblunck@infradead.org> <1482232315-21626-4-git-send-email-jblunck@infradead.org> CC: , From: Shreyansh Jain Message-ID: <463bac9d-4319-c707-6678-bb06281376df@nxp.com> Date: Wed, 21 Dec 2016 15:20:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482232315-21626-4-git-send-email-jblunck@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131267872248283220; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39380400002)(39840400002)(39400400002)(39860400002)(39850400002)(39450400003)(39410400002)(2980300002)(1110001)(1109001)(339900001)(24454002)(377454003)(189002)(199003)(8936002)(229853002)(76176999)(36756003)(38730400001)(68736007)(92566002)(47776003)(83506001)(106466001)(77096006)(31686004)(85426001)(81166006)(81156014)(8676002)(64126003)(54356999)(105606002)(50986999)(65806001)(69596002)(65956001)(50466002)(33646002)(4001350100001)(189998001)(104016004)(4326007)(5001770100001)(97736004)(2870700001)(626004)(31696002)(2906002)(356003)(5660300001)(23746002)(65826007)(6666003)(2950100002)(86362001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2467; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC011; 1:eSnzpDGXxsEWGHBniDJDpnklVcdibR+WAMxO4sTy4eNEOz2Sa9nGfofwU5RzsdcQUNScqh5yiWnN+DlcQG96arBAYZFHtE3UomZY2RvbrLGiZW9cNUxQ/7sFSyQToRJAruA4O1gs8wksXqcUmuPHHBhsgLry3Yx3SpBChitAt4jKlWvTQQriJe4YisCQLG046xvQ6b79gBMkROgBjKHetNPA7BrBtLxryPhV7DNKt7meaIDKJFZElcIg6VoXIRT4SnJ/RMmD0LsX92du4OrkMIsSIwFWJQppN8cHXHingrA/2YcIMbH+wBBKOiSKEeVUaQtYZMOACqVL+DcQxC3nnjRVDIBmc4o1zTFFpHy1mFT7ZlbUqxrhOhIP/JvlBZVzFxzuTHYWzXQe8CKAVxiY4uv5TUSw5pUxu/lIJrdnApRGvIlSVer9lXaYBLY3b5bEoeEVC0jFfC0FCqyWflLQeRpRphqCD7U9VopggiULSiKJuxjuKSXPPrjiM6SEoqYXahJna+ZVvDINNThHVOj6ipP7Uzx/MbwfVXhTNlXgypcon6X9BwZYfKasDu6VrS2z9bYo1ChhtKp2Pv0eo5ejUBetlzp2goah1mBf824okKE= X-MS-Office365-Filtering-Correlation-Id: 521dd80b-8df7-413d-c054-08d42986523e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2467; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 3:iq77wydNSt6IQazX1PSAhYqngME51fHVKR10z0UG0KtiLstFK2Mh1iXfHerKzMn/9ruj9Vk4IOmBXLCPyFDa1Pg5TS8lvs8Fxdgvy0vwdLaacjDicRtd52dZIMMw1qPTFV6pbM1fCgw9BlbwvyTdOyCFCFDGhqHHqCUYNzfJRQAjoSLrm+ZwzDtjoMHIaVEtFRdhWLT15qhn670oX4XBDGJ2tO1p8CQbQtZ+0nr8Hg/yfNeQ6XBze9cOv6EJITat7Nc1LiWrnXRR58N78GMdkxeJt+hYfGN79OLziK+tpVxNgIvtgWE2MD6GhoaQqCDhjaDUDmn90yEjWTzUBfcy/m+Pom7oIrPa6jbtdTbEtidTPBsO2jt9uwICVW2045VZ; 25:EG7qXUtRH4F3ECbV5eDE7YaXPgI6p8zkNC5W1vDuNHR0vQMBhGgRDsn3B0esYAn3D+vj0AqkWg5S8ic9PKbdGLC7HqGIEUHYb46LO35qAJhAgiAayx8fePkSsZl8q56DRW+WE4sGksDLHXDZ96f6FUgUoU3oQdE1+zTsJz0FxQg7QPZAyllytxcMS2us9deKvWAz4IavpD/dSaRXBpwA4lhVHFrSwno5x0b7g0JUcE38OS46L2elAjIvqNT0j3TfAYsEBcQafVk+lX8QqIsZlC6V3Ch0ml9qxIsq+KviWEIKFIP795PiVimn8l0ZZPaCojfm4WyBDpmBJ3YogDCIUznd3ynJBa9zMPWLwztYjnWe6RxDOunkOAoVjwmZA/z1/VjHfjkMDdciMyWyJPme3CBtqL3CrOYGArmc83G360/bwpFvOSI5VKsCHVd80yn0LZRPK1INm/plIlw8GvAWNw== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 31:aqpy5PDkMMVCoVP1SELn+VEe3BWYfe6nn3tv5iXLHyH3qw7RjBXVFJxJ81qwHgqxz4WgZikveRpLA4SMAnxu3VnupRSfv0thHLIdbsxcV2JjX9FiNEhgkV1/jqbIYqg9/lDKcVi5lqZO8U7RgrTQ9hLtuROzRLoIwcq4xU4mhjtIqIpy6IiendNE2XEgi3gEE23DSt+0dRupz8ElnjP0OYhQgEp2SYmioSI6CDGkXxtGaojAFaS9baddl8Jdk/IdKL6B1vn2A8WVTNWVFLm+3g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13024025)(13023025)(8121501046)(5005006)(13018025)(13015025)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:BN6PR03MB2467; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2467; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 4:d4zlgZSTUKCqP+LzwOJNbwaQ56jFe340AET9dFk7OQMfi9DQNUuSFT3TYoC2qDv6Qnni6T9m4EqlpTy8fTkOja0F7vAewB9TBdYEwPZBGaDpNmklC++UE1OjXSak4SVKIwtnXoRNx86eV2WuYwSD8WfIpjy+9FtOcGl38yLQ9Bo9FbpAu+Pri/SUt9Si3S50g4k0K6qQ21MmPNYBSpIxIIiDz52p2B5ysQzoeKnfARz1OgPuTldhUtV3OqTM4yQgLp7i3BHHx3L6wGKxJdsXJGJ6kHPanI1g3i9/8IiZKvDgIxgckjJYKJJQe+/tfWUoZc/PTBGAKwh+ubhPmtAkZ5NDX7WTICZtIHPYutixLGExHV2hrIyWX6/2Xm/HXvSykxJ5FPXPRNzIw0f/R8vOA3uOQ93MftwXhaOfRO53ZABU3D+i91vn+d1wWM44j/PNpyro3XQffZo6iodTwP3QjUQ/qVzfuhtXaIEnYUyrCOUdq3AlKUdpyqU5nqBUO5wv2llgSKOtG3rLueVl33Qt2Ql+olJj+jJmq6GB5cldzwx3iRH+n0/SWHigwsZ6bc2CTOBGU+mpdCHaxoD8OCStDF2w14sQaL7tyhPMHE34bMNw7BhEIQjRStHrn8jmGXtDESWs7FVnrGBhE1md9RrcQM9EGlYYrjj3bFBXWcFokypNEPoOFcvHbteziYT7H+9dsp2poQWAVjKK+Lsf+frbNA== X-Forefront-PRVS: 01630974C0 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2467; 23:ij3iyvyZIsIQkUPQshT334J5Ks5xLiUXqk16J?= =?Windows-1252?Q?Z+yawkGswNCgonUvJ10vK8Z635hBg0OKxXNIic87eGI/bZOqA7lKbegI?= =?Windows-1252?Q?+d4+ci6aiyQ1MN3vLMctxt5J22bkpdRJBIn5iRpe596bI1lKw+Zy1ppx?= =?Windows-1252?Q?Snov/IaBwpGq9w1TH17njGDiNSlMNZb7DAgFi57HesKHWaCuDznfsueR?= =?Windows-1252?Q?NDFS20D6DgWMRbZFp596m9gybeeQrEI3LPuNfl2n4xc88PStP2QOTWIF?= =?Windows-1252?Q?gjueo7XtSEWExQrFoHr/fGnJGVqc0auCj9mQfwzazyB0TmLVvDo2/YmF?= =?Windows-1252?Q?kMvGWA52CTQg3Qm0YqZGUhU7gEAxX2A3uM8UhfTkUF2ic+hs8gTQGjmx?= =?Windows-1252?Q?9xCe4SF00+8fTNNdCrbHKFxB3+sHZu085a8vLfn4LlLzCtJ2qO9pFd9u?= =?Windows-1252?Q?kCJgXX6yPS3PE3xvyWfToUyH0IGiTfWLDKGO53835se+zTHVSUSrYWz9?= =?Windows-1252?Q?vPWle+hlqSy32wshZfCGxg19CF8ZVvZbNCJK7vK1ICnaRZZV/KENj0Zk?= =?Windows-1252?Q?SVAcVhTTkb2bhWU5/HLBsyfC3MGiWPsUGoYdDUplh2UAs0YfyAcn1AJe?= =?Windows-1252?Q?V3FcIvGWCWXYG03cRMYff5S0xshvPbRambCC4tW3diCrtu3gCsgQJgLB?= =?Windows-1252?Q?9gZsz67Atcn8gcST0AGlw0WbVnTEalmyFFIVGZ90aNDQNJhTgxEbpLF9?= =?Windows-1252?Q?YnmCdD2syO+Fwe91zCVQZ8AKTVREz90aP243zD44oIj5Hxj/xd1cuBsT?= =?Windows-1252?Q?w928U1/6tDRIWlAIHobgueX5JFkYMPVDxzh7o2hwlRWa+h1ibYiNsOM7?= =?Windows-1252?Q?H4JfCo+To1Q4S70eFcTPg5KU3myMGqDnYKvpTd2B6jBvEsjNeTgsWAwe?= =?Windows-1252?Q?6oAwIZCk0kowc6y9qTeakVyzBXTZSgLIq5KfZ3mT8XCpXlwK5C+yZAqe?= =?Windows-1252?Q?MyYJcOyzC0v5ILZ1hos5q9rpbCvjWKqvIMPfoizYtWpdHQ4j58U0JwtM?= =?Windows-1252?Q?yqqmLZ1NyMInqTJ45t7l/g8XBnE+1ktqIFIGDqFBUo0jD4lYOL96tog/?= =?Windows-1252?Q?Yw1PpTpfYIRRBfFuPXgI4rYjWoi6WkJX6VZOGwF2G9XSZkRhzD8SbAvo?= =?Windows-1252?Q?A+K/x2qu8K8YUiqErh1EsfBXZGThCe6Ka0KLRYUXfDjMaobLtp7HrNBk?= =?Windows-1252?Q?8ZJx5nNMdidHxcDr/pVBr0mX434G+8SUAXKYmVgw1u0tbZFCym+dJOK9?= =?Windows-1252?Q?xN/dFIqADvEEuLu0Ggsv1Uk9DTZSBSrjD/b1nEXYxW5D56ERweslIiuW?= =?Windows-1252?Q?TE+F26QmCoQ7tidUvCoo8cmKIRHxJjLrFEwnxvjcSgdArD02NEIOfYxf?= =?Windows-1252?Q?AE1SxqhQrcHlbhywZyFdYzTCSFMEUAPV62rBGHm/wWkztEcET/2rYeCj?= =?Windows-1252?Q?j2qH1/cqv7EWSY8OEQvPikQi0bUtiRB6ZVjiu65NLNXAJseQKVZm9Eav?= =?Windows-1252?Q?nhaiQvQOypk4nwvB6iMoYiXIGBA3YJ4Y54vI4N/ldAUOtK1P04ToqX1q?= =?Windows-1252?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 6:Xl2FvVS4AhG2YYql8zGdXzXTYt8/w7W4PcXVT2aLojwvuzd01Xy31paB+R4yIqHWG+YaWWDTn2XBbo71M4EO9cxcdgI6ir3MPpSK8aCIgRU/H0HC5vn10R7fAfianhwbv30fhINTR4FfXK83e9jRxEltq1Odm83+gQYsZLCoVaeToWNHqYpxQLEahMciaV7vfinHrHNYcuk2NkIqHgDxam+4pefGGBQONbPvZ9AE0/9MOGQm7z5o/bM9vWBHRLnaM/re36HuU3YtzDqiZC2wKrAEcvES21n06fNu0ovxomHAvOVl9heCJyI6SQs/GcE4lCjR5ji9Ao0cyXfennn/qlZy5Q1n6y4/ud1ZnhNfB0yZ+mPt1NBJdSSbVtFx6Pu5IGVoleg87gzsvESmW6lrDj/CLRCnxSMF0ghtOgjSj4yaGCRz3lM8wCpuMFld4m1y; 5:5nkj+rjGqw1zcr8Q4JgLdfz+fClkg6IOGaSmCbwpDB47oV6aaIterxcmFUBWAUmBlkEPy9LLEXQIf4EfZB9w6bgiWsaoZdkbB9IC0cNIo7EM+B92KBr0UBLPZaUgOXsVU02/xtul9CbiIN3tFmcr6FI5wys0yugOkv1/X7JwftiV831Lx0IWrvLWnscuJ3BG; 24:RB6rw7+g+hnl9dfPY5MbjAdm7ySgoGfofWeThZR6SipCkTtWlbb/GLRP8RF6vRBaGuD2qowktpD52/EIzRfGIwMAp2f8ha8jaH9FwekUrjA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2467; 7:2hsgeVq2eHocQSE6ExpyV3usE/WQq4PGoC3lJ1PUV/n4D6TYt1O6rhcxbff8X8KrTsyC9QteHLG39A9cMjdh/8Emc55+UYgIhxtlL8s3/2ovJ0kWHW9uh6VSlg3mlguug0cjPTsuJK63ysjhGPPnv2OibwD95Vg93z/161lMFw/yHwWCrGwRat74dh0yE+/rDZoDta4Ec2gpPAzJSOF9RCJ1jZhYCQZTE6yH4Mjr8j7ZD0R3iSslyD2fdz8ZTbcxE2xx0KzXDYFfvkhg18oEihaDks43+vUeaW739WktTJjUVmvCGzfEpnOWWnUd/6GU7wmoDUAtWGLmZGgyqfCM8kffb6vA4sxMoVFcrmMV3aRiqsaOkTFa+sDIoGE3JxYtADkwBy3/QS5wRQUOqdPVoo2wu8gPoBm9mUX9mgK1Sk1OFkuBVp0k3spaNu8cptO1mvWqb2tXB50tsUB1M9cT0w== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2016 09:47:04.5943 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2467 Subject: Re: [dpdk-dev] [PATCH v3 3/9] drivers: Use ETH_DEV_PCI_DEV() helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 09:47:06 -0000 On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote: > The drivers should not directly access the rte_eth_dev->pci_dev but use > a macro instead. This is a preparation for replacing the pci_dev with > a struct rte_device member in the future. > > Signed-off-by: Jan Blunck > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 12 +++--- > drivers/net/bnxt/bnxt_ethdev.c | 19 ++++++---- > drivers/net/bnxt/bnxt_ring.c | 11 +++--- > drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- > drivers/net/e1000/em_ethdev.c | 20 ++++++---- > drivers/net/e1000/igb_ethdev.c | 50 ++++++++++++++----------- > drivers/net/e1000/igb_pf.c | 3 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/enic/enic_ethdev.c | 2 +- > drivers/net/fm10k/fm10k_ethdev.c | 49 +++++++++++++------------ > drivers/net/i40e/i40e_ethdev.c | 44 +++++++++++----------- > drivers/net/i40e/i40e_ethdev.h | 4 ++ > drivers/net/i40e/i40e_ethdev_vf.c | 38 +++++++++---------- > drivers/net/ixgbe/ixgbe_ethdev.c | 65 ++++++++++++++++++++------------- > drivers/net/ixgbe/ixgbe_pf.c | 2 +- > drivers/net/nfp/nfp_net.c | 16 ++++---- > drivers/net/qede/qede_ethdev.c | 17 +++++---- > drivers/net/szedata2/rte_eth_szedata2.c | 27 +++++++------- > drivers/net/szedata2/rte_eth_szedata2.h | 34 ++++++++--------- > drivers/net/thunderx/nicvf_ethdev.c | 5 ++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 +- > 21 files changed, 234 insertions(+), 192 deletions(-) > > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index 0eae433..c331ccd 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -124,7 +124,7 @@ bnx2x_interrupt_handler(__rte_unused struct rte_intr_handle *handle, void *param > struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > > bnx2x_interrupt_action(dev); > - rte_intr_enable(&(dev->pci_dev->intr_handle)); > + rte_intr_enable(&(ETH_DEV_PCI_DEV(dev)->intr_handle)); > } > > /* > @@ -187,10 +187,10 @@ bnx2x_dev_start(struct rte_eth_dev *dev) > } > > if (IS_PF(sc)) { > - rte_intr_callback_register(&(dev->pci_dev->intr_handle), > + rte_intr_callback_register(&sc->pci_dev->intr_handle, > bnx2x_interrupt_handler, (void *)dev); > > - if(rte_intr_enable(&(dev->pci_dev->intr_handle))) > + if (rte_intr_enable(&sc->pci_dev->intr_handle)) This changeset generates following error in my environment: --->8--- /home/shreyansh/build/DPDK/01_dpdk/drivers/net/bnx2x/bnx2x_ethdev.c: In function ‘bnx2x_dev_start’: /home/shreyansh/build/DPDK/01_dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:190:30: error: passing argument 1 of ‘rte_intr_callback_register’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] rte_intr_callback_register(&sc->pci_dev->intr_handle, ^ In file included from /home/shreyansh/build/DPDK/01_dpdk/x86_64-native-linuxapp-gcc/include/rte_pci.h:86:0, from /home/shreyansh/build/DPDK/01_dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:34, from /home/shreyansh/build/DPDK/01_dpdk/drivers/net/bnx2x/bnx2x.h:34, from /home/shreyansh/build/DPDK/01_dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:11: /home/shreyansh/build/DPDK/01_dpdk/x86_64-native-linuxapp-gcc/include/rte_interrupts.h:73:5: note: expected ‘struct rte_intr_handle *’ but argument is of type ‘const struct rte_intr_handle *’ int rte_intr_callback_register(struct rte_intr_handle *intr_handle, --->8--- Problem is that earlier 'eth_dev->pci_dev->intr_handle' was being passed which was not a 'const'. But, the BNX2 local structure 'bnx2x_softc' has a 'const struct rte_pci_device *' as member. Maybe, following can help: rte_intr_callback_register(Ð_DEV_PCI_DEV(dev),...); > PMD_DRV_LOG(ERR, "rte_intr_enable failed"); > } > > @@ -215,8 +215,8 @@ bnx2x_dev_stop(struct rte_eth_dev *dev) > PMD_INIT_FUNC_TRACE(); > > if (IS_PF(sc)) { > - rte_intr_disable(&(dev->pci_dev->intr_handle)); > - rte_intr_callback_unregister(&(dev->pci_dev->intr_handle), > + rte_intr_disable(&sc->pci_dev->intr_handle); > + rte_intr_callback_unregister(&sc->pci_dev->intr_handle, Similar error here. rte_intr_callback_unregister(&(ETH_DEV_PCI_DEV(dev)->intr_handle), ...) solves it for me. > bnx2x_interrupt_handler, (void *)dev); > } > > @@ -516,7 +516,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf) > PMD_INIT_FUNC_TRACE(); > > eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops : &bnx2x_eth_dev_ops; > - pci_dev = eth_dev->pci_dev; > + pci_dev = ETH_DEV_PCI_DEV(eth_dev); > > rte_eth_copy_pci_info(eth_dev, pci_dev); > - Shreyansh