From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11A1045B08; Thu, 10 Oct 2024 19:25:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02DE64025D; Thu, 10 Oct 2024 19:25:17 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 1812940144 for ; Thu, 10 Oct 2024 19:25:15 +0200 (CEST) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 944C411401D9; Thu, 10 Oct 2024 13:25:14 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Thu, 10 Oct 2024 13:25:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1728581114; x=1728667514; bh=0MXezb2KPIGPJZX86vxCygCkvzI+jZKvQRrqM7FPQsA=; b= QGYkzqm6WY0rrN4U0YaLU3vxelF402ANS8zd7p8WCpvx+tMhB6s0PZp9L7m90Kdd Pj0E29/puQ0Sb0Ml20wBIlzqNWRLKegP5MoHXgTueItN6qKMt7yprE9gXbuU9/mU GcNSG2C8F6MA2iY2sXAyUXDeXfmsIJ7Q5z9OzK/Q6eDllOgTbqLAlzCzd4vSrvzj Uz1YYq9UuqzaxlSdUtzbHYa/FDjqcfwnnx5mcwKzjqgKexbISGJV3uHbd7qbydTN oKL7tCXKFF8O3ua+1txIfn12Bu+MMnNj8cqR9KiJZLaZxF6QPzmwM2M/93v8Rzwc IPk/I7bb+5pVnUOtfoW4qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728581114; x= 1728667514; bh=0MXezb2KPIGPJZX86vxCygCkvzI+jZKvQRrqM7FPQsA=; b=n fEpsiGYvNnlaaqNUF7YxEias90N7rty6/Jcqidbd8d+lpWufuNR684jAdRn+yvIz ucgna9R5lt8SHZJioStrzq0bHAbWPP8YIJecdeXPuKJMW5rCDwoJb8bOHbfmTYbs le+gyguBhHv3wE6HQh7ptd5anDEh1km7wtAl4POZFF2JDt3a/KAwKgNYAMo1Ge1b 2+V15Tqpr5M0v17SzehN04q+pGv+9NJZPpka2SYixb7oamrMtlq6XaHlzX6XJqJt xTZ1P1viLYKe5e7EwAVyJ7EnJvDj7bHhdndumOUM+VmFb2dB8wzsuneDdzVk5kjF OUfifqN94W7z2HyV+PKow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefhedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeev tdehvedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohepkedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvh hiugdrmhgrrhgthhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopeguvghvsegu phgukhdrohhrghdprhgtphhtthhopehsphhinhhlvghrsegtvghsnhgvthdrtgiipdhrtg hpthhtoheprghnrghtohhlhidrsghurhgrkhhovhesihhnthgvlhdrtghomhdprhgtphht thhopehmsgesshhmrghrthhshhgrrhgvshihshhtvghmshdrtghomhdprhgtphhtthhope hsthgvphhhvghnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopehf vghnghgthhgvnhhgfigvnheshhhurgifvghirdgtohhmpdhrtghpthhtohepfigrthhhsh grlhgrrdhvihhthhgrnhgrghgvsegrrhhmrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Oct 2024 13:25:13 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Martin Spinler , Anatoly Burakov , Morten =?UTF-8?B?QnLDuHJ1cA==?= , Stephen Hemminger , Chengwen Feng , Wathsala Vithanage Subject: Re: [PATCH] net/nfb: fix use after free Date: Thu, 10 Oct 2024 19:25:11 +0200 Message-ID: <4642040.8F6SAcFxjW@thomas> In-Reply-To: References: <20241010171547.2510123-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/10/2024 19:17, David Marchand: > On Thu, Oct 10, 2024 at 7:16=E2=80=AFPM Thomas Monjalon wrote: > > > > With the annotations added to the allocation functions, > > more issues are detected at compilation time: > > > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > > > It is fixed by moving the assignment before freeing the parent pointer. > > > > Fixes: 80da7efbb4c4 ("eal: annotate allocation functions") The real cause is: =46ixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") > > Signed-off-by: Thomas Monjalon > Reviewed-by: David Marchand Applied to fix compilation on the main branch.