From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BC5D11B147; Fri, 26 Apr 2019 12:33:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 03:33:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="153951127" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.92.20]) ([10.251.92.20]) by orsmga002.jf.intel.com with ESMTP; 26 Apr 2019 03:33:42 -0700 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org References: <20190426084337.3921-1-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <46433916-0e77-fd36-94fc-0cb855fac3b9@intel.com> Date: Fri, 26 Apr 2019 11:33:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190426084337.3921-1-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix string null termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 10:33:46 -0000 On 26-Apr-19 9:43 AM, David Hunt wrote: > coverity complains about a null-termination after a read, > so we terminate conditionally on whether idx is within > the buffer or at the end of the buffer. > > Coverity issue: 337680 > Fixes: a63504a90f ("examples/power: add JSON string handling") > CC: stable@dpdk.org > Signed-off-by: David Hunt > --- > examples/vm_power_manager/channel_monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c > index 971e4f2bc..711722fef 100644 > --- a/examples/vm_power_manager/channel_monitor.c > +++ b/examples/vm_power_manager/channel_monitor.c > @@ -808,6 +808,7 @@ read_json_packet(struct channel_info *chan_info) > int indent = 0; > do { > n_bytes = read(chan_info->fd, &json_data[idx], 1); > + json_data[idx + (idx < MAX_JSON_STRING_LEN - 1)] = '\0'; Why do it inside the loop and not after? > if (n_bytes == 0) > break; > if (json_data[idx] == '{') > -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 73253A05D3 for ; Fri, 26 Apr 2019 12:33:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1593B1B21A; Fri, 26 Apr 2019 12:33:47 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BC5D11B147; Fri, 26 Apr 2019 12:33:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 03:33:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="153951127" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.92.20]) ([10.251.92.20]) by orsmga002.jf.intel.com with ESMTP; 26 Apr 2019 03:33:42 -0700 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org References: <20190426084337.3921-1-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: <46433916-0e77-fd36-94fc-0cb855fac3b9@intel.com> Date: Fri, 26 Apr 2019 11:33:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190426084337.3921-1-david.hunt@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix string null termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190426103342.SCV70QeN2pIJpqXZrDB_u1nlI5Srn13pRobW1YV8DwI@z> On 26-Apr-19 9:43 AM, David Hunt wrote: > coverity complains about a null-termination after a read, > so we terminate conditionally on whether idx is within > the buffer or at the end of the buffer. > > Coverity issue: 337680 > Fixes: a63504a90f ("examples/power: add JSON string handling") > CC: stable@dpdk.org > Signed-off-by: David Hunt > --- > examples/vm_power_manager/channel_monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c > index 971e4f2bc..711722fef 100644 > --- a/examples/vm_power_manager/channel_monitor.c > +++ b/examples/vm_power_manager/channel_monitor.c > @@ -808,6 +808,7 @@ read_json_packet(struct channel_info *chan_info) > int indent = 0; > do { > n_bytes = read(chan_info->fd, &json_data[idx], 1); > + json_data[idx + (idx < MAX_JSON_STRING_LEN - 1)] = '\0'; Why do it inside the loop and not after? > if (n_bytes == 0) > break; > if (json_data[idx] == '{') > -- Thanks, Anatoly