From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A17CA0548; Fri, 9 Jul 2021 02:09:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C2CE4014D; Fri, 9 Jul 2021 02:09:11 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id C9C3640143 for ; Fri, 9 Jul 2021 02:09:08 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GLYMj1CBzz72V7; Fri, 9 Jul 2021 08:05:37 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 9 Jul 2021 08:09:05 +0800 To: =?UTF-8?Q?Havl=c3=adk_Martin?= CC: , , , , References: <20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz> <20210622092531.73112-3-xhavli56@stud.fit.vutbr.cz> <3b731983-2bc2-746e-4303-6654b2de1193@huawei.com> <6972a4cc793604dcb6c2e7ce4e0d1586@stud.fit.vutbr.cz> From: "Min Hu (Connor)" Message-ID: <4648adf2-e63d-39da-57b4-7e4aaab4473f@huawei.com> Date: Fri, 9 Jul 2021 08:09:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <6972a4cc793604dcb6c2e7ce4e0d1586@stud.fit.vutbr.cz> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/7/8 21:20, Havlík Martin 写道: > Dne 2021-07-08 14:43, Min Hu (Connor) napsal: >> 在 2021/6/22 17:25, Martin Havlik 写道: >>> Return value from bond_ethdev_8023ad_flow_set() is now checked >>> and appropriate message is logged on error. >>> >>> Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP >>> control") >>> Cc: tomaszx.kulasek@intel.com >>> >>> Signed-off-by: Martin Havlik >>> Cc: Jan Viktorin >>> --- >>>   drivers/net/bonding/rte_eth_bond_pmd.c | 8 +++++++- >>>   1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c >>> b/drivers/net/bonding/rte_eth_bond_pmd.c >>> index 4c43bf916..a6755661c 100644 >>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >>> @@ -1819,8 +1819,14 @@ slave_configure(struct rte_eth_dev >>> *bonded_eth_dev, >>> >>> internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id], >>>                       &flow_error); >>>   -        bond_ethdev_8023ad_flow_set(bonded_eth_dev, >>> +        errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev, >>>                   slave_eth_dev->data->port_id); >>> +        if (errval != 0) { >>> +            RTE_BOND_LOG(ERR, >>> +                "bond_ethdev_8023ad_flow_set: port=%d, err (%d)", >>> +                slave_eth_dev->data->port_id, errval); >>> +            return errval; >>> +        } >>>       } >>> >> Firstly, I think your patch is OK, >> But I want to know what is your standard to decide which function >> should check return value or not(of course, they are none-void)? >> > I encountered the problem with dedicated queues on mlx5, I looked into > the source code and I saw the cause, so I fixed it. If I had seen any > other issue, I would've fixed it too. That, for example, applies to the > log message fix I included. My standard is to check all non-void return > values. Got it. >> While, I noticed "bond_ethdev_lsc_event_callback" nearby was not >> checked, but you ignored it. >> > Not ignored, just didn't properly review more code than what closely > surrounded the problematic lines. >>>       /* Start device */ >>> Acked by: Min Hu (Connor) > .