From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>, Jerin Jacob <jerinj@marvell.com>
Cc: dev@dpdk.org, Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
David Christensen <drc@linux.vnet.ibm.com>,
"Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>,
David Marchand <david.marchand@redhat.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
dodji@redhat.com, dpdk stable <stable@dpdk.org>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter
Date: Wed, 08 Jul 2020 17:01:36 +0200 [thread overview]
Message-ID: <4650182.64zhJK4i9u@thomas> (raw)
In-Reply-To: <CALBAE1Psj3WKdMnudJUfF=5yZsFfZAhjknfuy3DGhuawwmabZg@mail.gmail.com>
08/07/2020 15:30, Jerin Jacob:
> On Tue, Jul 7, 2020 at 9:25 PM Phil Yang <phil.yang@arm.com> wrote:
> >
> > The n_poll_lcores counter and poll_lcore array are shared between lcores
> > and the update of these variables are out of the protection of spinlock
> > on each lcore timer list. The read-modify-write operations of the counter
> > are not atomic, so it has the potential of race condition between lcores.
> >
> > Use c11 atomics with RELAXED ordering to prevent confliction.
> >
> > Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter")
> > Cc: erik.g.carrillo@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> Hi Thomas,
>
> The latest version does not have ABI breakage issue.
>
> I have added the ABI verifier in my local patch verification setup.
>
> Series applied to dpdk-next-eventdev/master.
>
> Please pull this series from dpdk-next-eventdev/master. Thanks.
>
> I am marking this patch series as "Awaiting Upstream" in patchwork
> status to reflect the actual status.
OK, pulled and marked as Accepted in patchwork.
prev parent reply other threads:[~2020-07-08 15:01 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 11:19 [dpdk-dev] [PATCH 1/3] " Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-06-23 21:01 ` Carrillo, Erik G
2020-06-28 16:12 ` Phil Yang
2020-06-23 21:20 ` Stephen Hemminger
2020-06-23 21:31 ` Carrillo, Erik G
2020-06-28 16:32 ` Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-06-22 10:12 ` Phil Yang
2020-06-23 19:38 ` Carrillo, Erik G
2020-06-28 17:33 ` Phil Yang
2020-06-29 18:07 ` Carrillo, Erik G
2020-06-18 15:17 ` [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter Carrillo, Erik G
2020-06-18 18:25 ` Honnappa Nagarahalli
2020-06-22 9:48 ` Phil Yang
2020-07-01 11:22 ` Jerin Jacob
2020-07-02 3:28 ` Phil Yang
2020-07-02 3:26 ` Phil Yang
2020-07-02 3:56 ` Honnappa Nagarahalli
2020-07-02 21:15 ` Carrillo, Erik G
2020-07-02 21:30 ` Honnappa Nagarahalli
2020-06-22 9:09 ` Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 1/4] " Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 2/4] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-07-02 20:21 ` Carrillo, Erik G
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 3/4] eventdev: remove redundant code Phil Yang
2020-07-03 3:35 ` Dharmik Thakkar
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-07-02 20:30 ` Carrillo, Erik G
2020-07-03 10:50 ` Jerin Jacob
2020-07-06 10:04 ` Thomas Monjalon
2020-07-06 15:32 ` Phil Yang
2020-07-06 15:40 ` Thomas Monjalon
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-07 14:29 ` Jerin Jacob
2020-07-07 15:56 ` Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-08 13:30 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Jerin Jacob
2020-07-08 15:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4650182.64zhJK4i9u@thomas \
--to=thomas@monjalon.net \
--cc=Dharmik.Thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=drc@linux.vnet.ibm.com \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mdr@ashroe.eu \
--cc=nd@arm.com \
--cc=nhorman@tuxdriver.com \
--cc=phil.yang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).