From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E25EA0527; Wed, 8 Jul 2020 17:01:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7872A1DD10; Wed, 8 Jul 2020 17:01:44 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id A8C041C43D; Wed, 8 Jul 2020 17:01:42 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 26CE65800E1; Wed, 8 Jul 2020 11:01:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 08 Jul 2020 11:01:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= B2xgZq8ZSdBrhKJHwttlP1l8dJHLLu6qJV3/7rPOZKQ=; b=Pa2+/PySTmEBeHov Zw3n6G/6x/D2a+bqg6S9gNQwz8mUwBhhVq0GxZFNnywn/2bQoqZGhvXfOQFgb1IG fqfhTlsSTqAwQ3JEDysoDDYD4txMjYeTaNZ7edm2G4gKYKhDiyNbMWblx8NrXgE4 AHLf+fTpU2SSTuYuEUs1gZGtst9x98hZ8CquiehFAQ/LaJfz+4wvKT6OAgtwImJ8 7mq61pmrnWN2pRpIdR8MPm2kqEA3XPkOz46Oo13+Oe10qcI6hRLV86Oyw1Wx5WiZ pqZ/0hK6Z+AhJE9X9jERjLXX2Q0b9K/C24uxb53cnDDPDH9Fd0Z77C5NAVZS/MEE +ybZrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=B2xgZq8ZSdBrhKJHwttlP1l8dJHLLu6qJV3/7rPOZ KQ=; b=STVm3/fvgf1SuxQzLlWyLIiahX8dg0zqQtTyRe6mlBRNepSydyVhLAlUb tO7OLNniUPbOOVE7SVnLMu9g82g/gno81sIOEl3+eKm8VpMeJfntj2OaSBTM8jlj TJeQ7vTgJyyAPleDUUJHyAcHRdh3IdVD8TLDjQ+aLGUsr649H8NWSWZP8N0+3LSb hFRwZFBS456OtgjQEXoTZVIN8HZbUA0l8uVI+7p74tGAGclzH9o2FgUyptQv/psK BlFjfuJQTmc2N6XCiI7Tc9d5cv3XE/v53FufwXyLXglSvWp02P5wYUO5g5nQ5AYX F+hilvoY28/4Umb890kyH4Ab0pTaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudejgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24F0B30600B1; Wed, 8 Jul 2020 11:01:37 -0400 (EDT) From: Thomas Monjalon To: Phil Yang , Jerin Jacob Cc: dev@dpdk.org, Erik Gabriel Carrillo , Honnappa Nagarahalli , David Christensen , "Ruifeng Wang (Arm Technology China)" , Dharmik Thakkar , nd , David Marchand , Ray Kinsella , Neil Horman , dodji@redhat.com, dpdk stable , Jerin Jacob Date: Wed, 08 Jul 2020 17:01:36 +0200 Message-ID: <4650182.64zhJK4i9u@thomas> In-Reply-To: References: <1594120403-17643-1-git-send-email-phil.yang@arm.com> <1594137293-22468-1-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2020 15:30, Jerin Jacob: > On Tue, Jul 7, 2020 at 9:25 PM Phil Yang wrote: > > > > The n_poll_lcores counter and poll_lcore array are shared between lcores > > and the update of these variables are out of the protection of spinlock > > on each lcore timer list. The read-modify-write operations of the counter > > are not atomic, so it has the potential of race condition between lcores. > > > > Use c11 atomics with RELAXED ordering to prevent confliction. > > > > Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter") > > Cc: erik.g.carrillo@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Phil Yang > > Reviewed-by: Dharmik Thakkar > > Reviewed-by: Ruifeng Wang > > Acked-by: Erik Gabriel Carrillo > > Hi Thomas, > > The latest version does not have ABI breakage issue. > > I have added the ABI verifier in my local patch verification setup. > > Series applied to dpdk-next-eventdev/master. > > Please pull this series from dpdk-next-eventdev/master. Thanks. > > I am marking this patch series as "Awaiting Upstream" in patchwork > status to reflect the actual status. OK, pulled and marked as Accepted in patchwork.