From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CE4EA0C3F; Mon, 28 Jun 2021 13:05:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91ADF40692; Mon, 28 Jun 2021 13:05:45 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8A4934068A for ; Mon, 28 Jun 2021 13:05:44 +0200 (CEST) Received: from [192.168.1.71] (unknown [188.170.72.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9D2E17F4FD; Mon, 28 Jun 2021 14:05:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9D2E17F4FD DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1624878344; bh=kBRBAOWG1fGK1NdStypJtEjejT0xf0Ga1Hmg83het0A=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=oDOPFr3y2j1/gRL4W9NWalagBR2Cw4ptKqL6E+NjUIgmUmlkcHLE7p3aiSfNcJty3 66pJh8q/4KBkDNczLgYHbvHORZWTqSvJg/O7rKlW8nCYsmX+jIl/8ZKdmiCwsxlrF7 s4u7T9ADIj6Z6IJvUEXK+d6WQgmdj5aRzPzEBehc= To: "Li, Xiaoyun" , Ori Kam Cc: "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Singh, Aman Deep" , David Marchand References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <20210617142026.1133460-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Message-ID: <465256f0-a426-5061-2cec-d19e223d2d2d@oktetlabs.ru> Date: Mon, 28 Jun 2021 14:05:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/18/21 11:32 AM, Li, Xiaoyun wrote: >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Thursday, June 17, 2021 22:20 >> To: Li, Xiaoyun ; Ori Kam >> Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, >> Ferruh ; Singh, Aman Deep >> >> Subject: [PATCH v3] app/testpmd: send failure logs to stderr >> >> Running with stdout suppressed or redirected for further processing >> is very confusing in the case of errors. Fix it by logging errors and >> warnings to stderr. >> >> Since lines with log messages are touched anyway concatenate split >> format strings to make it easier to search using grep. >> >> Fix indent of format string arguments. >> >> Signed-off-by: Andrew Rybchenko >> --- >> v3: >> - fix typo in the patch description >> - fix applicable coding style issues reported by patchwork >> >> v2: >> - switch from printf() to fpritnf(stderr, ...) in more cases >> - do not inherit acks from the previous version since the patch is >> much bigger >> - fix style in few cases (TAB vs spaces, missing space separtor etc) >> - still don't use TESTPMD_LOG() since the patch does not add new logs. >> Also switching to TESTPMD_LOG() will add "testpmd: " prefix to log >> messages and it is a real change and could be a pain for automation. >> >> app/test-pmd/bpf_cmd.c | 6 +- >> app/test-pmd/cmdline.c | 957 ++++++++++++++----------- >> app/test-pmd/cmdline_flow.c | 20 +- >> app/test-pmd/cmdline_mtr.c | 8 +- >> app/test-pmd/cmdline_tm.c | 33 +- >> app/test-pmd/config.c | 455 ++++++------ >> app/test-pmd/csumonly.c | 5 +- >> app/test-pmd/parameters.c | 21 +- >> app/test-pmd/testpmd.c | 298 ++++---- >> app/test-pmd/util.c | 19 +- >> doc/guides/rel_notes/release_21_08.rst | 5 + >> 11 files changed, 1004 insertions(+), 823 deletions(-) > > Acked-by: Xiaoyun Li > It looks like Mellanox test failures are unrelated to the patch. There are a number of patches in queue. Which order is the right now? Apply this one and require appropriate changes in other testpmd patches? Or vise versa?