From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 705C2A04BB; Tue, 6 Oct 2020 12:54:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F5761023; Tue, 6 Oct 2020 12:54:09 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 817AEF64 for <dev@dpdk.org>; Tue, 6 Oct 2020 12:54:06 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id D9372580218; Tue, 6 Oct 2020 06:54:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Oct 2020 06:54:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1J35GVKGRSvktVCYxYFrMDi0B5b5I+MseED0pZDdCDs=; b=YnzqDSM11Wini6XH tUvmECt8i792g/AuuuPeXQtGWPpGGK3X+xSzPHI4cimDZ/VAtmOwXk5VOyPbPoU7 o2Q21N0omA4jsJhNa6DTQtrdXd0JLYIzz8n16b19UUWn7VRxX0PYtW37ZrxUazUF ELr0LW45CM8i6rLN80GgXYjtw0ODwCxIsD2Xy/KuJ0sabDNFbOzkOj9Ufaj485tB KzfSYUJ2g9R9OK+c7qRfrbNuhCqo6h7N7JHaqqFPr5pREOKdPKoT+xAWnHsPzQXu E7+kMUpyoJ+br6/VqdaDnd0V0U9AAzpX3JcOsJsF/7EfLTXVEyJQeHBL4kT3QRwj y4zAXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1J35GVKGRSvktVCYxYFrMDi0B5b5I+MseED0pZDdC Ds=; b=SIVXZxBGJX3Y6FjAU229SfGCZqj0jvQLeacoZumajafJzU+dOibkoiElO DFInxpoiMGvH/D5HxYI6NwF+isDmdU/QIdLco+eOJuH3ZgYmhXKJp6bEd4Zr1p0f D1FB41+YaI5AO1g/LdJlGot6nra1ab8+PgSF/iSYkPEAUbGujWrhgcz2RoJIn3VU NWpTiwmT3NhjnWtLgSGFlMlle6FsrjmFto+kygHiMTWY3lzU1fOIsgRylFdI6XpT i7c7IfINGAzrheuZ7nEK+LbsC/6ZS5YRhQUeZ0SFcHqC8UHqahAwga5yXMX9QK9z n3476kCK/2ajQ7DwpA3kSVeHwOGpg== X-ME-Sender: <xms:y0x8X8PKaPisc9lgnvrdb3wnldcO1aYBRO98XROFm3XDFv14zsvAZw> <xme:y0x8Xy-jgzg1EjFYfJCOtn6nFB73XBaFKHSIzK5cstd45TvQVhDWeaoxeDDFjJegd CMenrl4a4AcZDoViw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:y0x8XzQNXX3oO_Wn7w7iq1LGRlSPhU3xskcHB3wrnwn-lreuzHKfKg> <xmx:y0x8X0vDToPiHgGAKVp-F_hPBH7AS4esSx12KoC7k3gSn2S7-0uE7g> <xmx:y0x8X0dNZvucTijVQpstNKr46QYLvvo-ZZpu1l4WlHw03bgE1t9wzA> <xmx:zUx8X4_9q5XSaD_xK9kQxnvDW8vSwoLBn_VL45EaYaqo6jyU1Q3fMA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4335B3280065; Tue, 6 Oct 2020 06:54:02 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, david.marchand@redhat.com, jerinj@marvell.com, stephen@networkplumber.org, Nicolas Chautru <nicolas.chautru@intel.com>, Somalapuram Amaranath <asomalap@amd.com>, John Griffin <john.griffin@intel.com>, Fiona Trahe <fiona.trahe@intel.com>, Deepak Kumar Jain <deepak.k.jain@intel.com>, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Anatoly Burakov <anatoly.burakov@intel.com> Date: Tue, 06 Oct 2020 12:54:00 +0200 Message-ID: <4658008.ZccNZLbTaq@thomas> In-Reply-To: <7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com> References: <20200907225049.547832-1-thomas@monjalon.net> <20201005094300.590912-1-thomas@monjalon.net> <7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 06/10/2020 12:16, Ferruh Yigit: > On 10/5/2020 10:42 AM, Thomas Monjalon wrote: > > As decided in the Technical Board in November 2019, > > the kernel module igb_uio is moved to the dpdk-kmods repository > > in the /linux/igb_uio/ directory. [...] > Patch doesn't apply cleanly, not sure why, CI seems having same problem: > http://mails.dpdk.org/archives/test-report/2020-October/156378.html That's because I used --irreversible-delete to minimize the size of the patch. [...] > > If UEFI secure boot is enabled, the Linux kernel may disallow the use of > > UIO on the system. Therefore, devices for use by DPDK should be bound to the > > - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. > > + ``vfio-pci`` kernel module rather than any UIO-based module. > > For more details see :ref:`linux_gsg_binding_kernel` below. > > Should we change the order of the kernel drivers, currently first section is > "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out > of the repo, should we list the "VfIO" first? Absolutely. In general we need to encourage more VFIO and remove some references to igb_uio. But I don't want to do such "marketing" change in this patch. The goal of this patch is just to move the code. [...] > > +* kernel: The module ``igb_uio`` has been moved to the git repository > > +``dpdk-kmods`` in a new directory ``linux/igb_uio``. > > + > > Doc build giving warning on this: > WARNING: Bullet list ends without a blank line; unexpected unindent. Probably a merge issue. That's fine on my side. > Except from above minor comments looks good to me, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Do we agree I can merge without any change?