From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2E77A0524; Wed, 2 Jun 2021 13:06:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 936974069F; Wed, 2 Jun 2021 13:06:58 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 611CB40689 for ; Wed, 2 Jun 2021 13:06:56 +0200 (CEST) IronPort-SDR: 1TLm9L5jjTcokdwkNs4lDSJ9jtAW+ntVS+Wj4xAAEtjBF4WoJlK4bPSuH6Gz5PAuXqLBATFFCS pPVvxAaZcbWg== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="264942555" X-IronPort-AV: E=Sophos;i="5.83,242,1616482800"; d="scan'208";a="264942555" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 04:06:52 -0700 IronPort-SDR: 0r8JPTnCcl2beRVzF/+RPG+JVxtFJTM/Z++M8aSBrJ88DZeownlamkA0zC6+HACLxmBAHJauZZ zAKPumILQNkA== X-IronPort-AV: E=Sophos;i="5.83,242,1616482800"; d="scan'208";a="550094354" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.233.20]) ([10.213.233.20]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2021 04:06:47 -0700 To: Christian Ehrhardt , dev Cc: Nithin Dabilpuram , Thomas Monjalon References: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> <20210601082825.1604489-1-christian.ehrhardt@canonical.com> From: "Burakov, Anatoly" Message-ID: <465cd57b-f76e-4834-efab-9cb61d035f30@intel.com> Date: Wed, 2 Jun 2021 12:06:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210601082825.1604489-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vfio: fix stdbool usage without include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Jun-21 9:28 AM, Christian Ehrhardt wrote: > This became visible by backporting the following for the 19.11 stable tree: > c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" > > The usage of type bool in the vfio code would require "#include > ", but rte_vfio.h has no direct paths to stdbool.h. > It happens that in eal_vfio_mp_sync.c it comes after "#include > ". > > And rte_log.h since 20.05 includes stdbool since this change: > 241e67bfe "log: add API to check if a logtype can log in a given level" > and thereby mitigates the issue. > > It should be safe to include stdbool.h from rte_vfio.h itself > to be present exactly when needed for the struct it defines using that > type. > > Fixes: c13ca4e81cac ("vfio: fix DMA mapping granularity for IOVA as VA") > > Signed-off-by: Christian Ehrhardt > --- > lib/eal/include/rte_vfio.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h > index e7a87454bea..2d90b364801 100644 > --- a/lib/eal/include/rte_vfio.h > +++ b/lib/eal/include/rte_vfio.h > @@ -14,6 +14,7 @@ > extern "C" { > #endif > > +#include > #include > > /* > Acked-by: Anatoly Burakov -- Thanks, Anatoly