From: Weifeng LI <liweifeng96@126.com>
To: dev@dpdk.org, shahafs@mellanox.com, matan@mellanox.com,
viacheslavo@mellanox.com, chas3@att.com
Cc: liweifeng2@huawei.com, 863348577@qq.com,
Weifeng Li <liweifeng96@126.com>,
zhaohui8@huawei.com
Subject: [dpdk-dev] Segfault when eal thread executing mlx5 nic's lsc event
Date: Fri, 30 Oct 2020 00:42:10 +0800 [thread overview]
Message-ID: <465ecde5-a65a-782e-4f46-3e084e54c609@126.com> (raw)
hi
I am using the dpdk bond of mlx5. There is a segment error in the
process of starting the bond port. This is because EAL interrupt thread
is processing LSC interrupt when slave_configure is executing the
rte_eth_dev_rss_reta_update. rte_eth_dev_rss_reta_update will also use
mlx5 flow list.
I've also found another discussion about this
issue.https://mails.dpdk.org/archives/dev/2019-March/125929.html
<https://mails.dpdk.org/archives/dev/2019-March/125929.html>
Do it need a lock to protect the mlx5 flow list?
int
slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_eth_dev *slave_eth_dev)
{
...
/* Start device */
errval = rte_eth_dev_start(slave_eth_dev->data->port_id);
if (errval != 0) {
RTE_BOND_LOG(ERR, "rte_eth_dev_start: port=%u, err (%d)",
slave_eth_dev->data->port_id, errval);
return -1;
}
/* If RSS is enabled for bonding, synchronize RETA */
if (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS) {
int i;
struct bond_dev_private *internals;
internals = bonded_eth_dev->data->dev_private;
for (i = 0; i < internals->slave_count; i++) {
if (internals->slaves[i].port_id ==
slave_eth_dev->data->port_id) {
errval = rte_eth_dev_rss_reta_update(
slave_eth_dev->data->port_id,
&internals->reta_conf[0],
internals->slaves[i].reta_size);
if (errval != 0) {
RTE_BOND_LOG(WARNING,
"rte_eth_dev_rss_reta_update on slave port
%d fails (err %d)."
" RSS Configuration for bonding may be
inconsistent.",
slave_eth_dev->data->port_id, errval);
}
break;
}
}
}
next reply other threads:[~2020-10-30 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 16:42 Weifeng LI [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-06 3:05 [dpdk-dev] Segfault when eal thread executing mlx5 nic‘s " Zhaohui (zhaohui, Polestar)
2019-03-06 6:02 ` Shahaf Shuler
2019-03-06 9:42 ` [dpdk-dev] 答复: " Zhaohui (zhaohui, Polestar)
2019-03-06 18:59 ` Chas Williams
2019-02-22 7:33 [dpdk-dev] " wangyunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465ecde5-a65a-782e-4f46-3e084e54c609@126.com \
--to=liweifeng96@126.com \
--cc=863348577@qq.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=liweifeng2@huawei.com \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=zhaohui8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).