[dpdk-dev] [PULL REQUEST] i40e base driver update

[dpdk-dev] [PULL REQUEST] i40e base driver update

[Helin Zhang]

The following changes since commit cddae880b69155f76efa3241d02437fc69fade45:

  ixgbe: use scattered Rx with bulk allocation (2015-05-07 19:19:18 +0200)

are available in the git repository at:

  helin@dpdk.org:dpdk-i40e-next.git master

for you to fetch changes up to c73e796e3b1c15ac8ae66a0c18877c7fd966b2d4:

  i40e/base: modifications for future use (2015-05-08 02:07:06 -0400)

----------------------------------------------------------------
Helin Zhang (33):
      i40e: copyright update
      i40e: disable setting of phy configuration
      i40e: adjustment of register definitions and relevant
      i40e/base: rename 'err' to 'perrno'
      i40e/base: support of building both PF and VF driver together
      i40e/base: support of CEE DCBX on recent firmware versions
      i40e: replacement of 'i40e_debug_read_register()'
      i40e/base: rework of 'i40e_hmc_get_object_va'
      i40e/base: update of shadow RAM read/write functions
      i40e/base: catch NVM write semaphore timeout and retry
      i40e/base: check for AQ timeout in aq_rc decode
      i40e/base: fix up NVM update sm error handling
      i40e/base: enhancement of polling NVM semaphore
      i40e/base: enhancements of NVM checksum calculation
      i40e/base: replacement of DEBUGOUT() with i40e_debug()
      i40e/base: add fw build info to AQ data
      i40e/base: define and use i40e_is_vf()
      i40e/base: grab NVM devstarter version not image version
      i40e/base: enhancements on adminq init and sending asq command
      i40e/base: i40e_aq_get_link_info() should be used directly
      i40e/base: add new interfaces for future use
      i40e/base: update of get/set LED functions
      i40e/base: clean up sparse complaint in i40e_debug_aq
      i40e/base: get pf_id from HW rather than PCI function
      i40e/base: find partition_id in npar mode, and disable FCOE by default
      i40e/base: Reassign incorrect PHY type as a workaround for a FW issue
      i40e/base: add AOC phy types to case statement in get_media_type
      i40e/base: support for iSCSI capability
      i40e/base: set FLAG_RD when sending driver version to FW
      i40e/base: future proof some sizeof calls
      i40e/base: add more virtual channel operations for future use
      i40e/base: rework of structures and macros for future use
      i40e/base: modifications for future use

 lib/librte_pmd_i40e/Makefile               |   5 +-
 lib/librte_pmd_i40e/i40e/i40e_adminq.c     |  48 +--
 lib/librte_pmd_i40e/i40e/i40e_adminq.h     |  15 +-
 lib/librte_pmd_i40e/i40e/i40e_adminq_cmd.h | 183 +++++++++-
 lib/librte_pmd_i40e/i40e/i40e_alloc.h      |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_common.c     | 535 +++++++++++++++++++++------
 lib/librte_pmd_i40e/i40e/i40e_dcb.c        | 263 +++++++++++++-
 lib/librte_pmd_i40e/i40e/i40e_dcb.h        |  22 +-
 lib/librte_pmd_i40e/i40e/i40e_diag.c       |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_diag.h       |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_hmc.c        |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_hmc.h        |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c    |  33 +-
 lib/librte_pmd_i40e/i40e/i40e_lan_hmc.h    |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_nvm.c        | 555 ++++++++++++++++++++++-------
 lib/librte_pmd_i40e/i40e/i40e_osdep.h      |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_prototype.h  |  37 +-
 lib/librte_pmd_i40e/i40e/i40e_register.h   |  54 +--
 lib/librte_pmd_i40e/i40e/i40e_status.h     |   2 +-
 lib/librte_pmd_i40e/i40e/i40e_type.h       |  97 +++--
 lib/librte_pmd_i40e/i40e/i40e_virtchnl.h   |  43 ++-
 lib/librte_pmd_i40e/i40e_ethdev.c          |  31 +-
 lib/librte_pmd_i40e/i40e_ethdev.h          |   2 +-
 lib/librte_pmd_i40e/i40e_ethdev_vf.c       |   2 +-
 lib/librte_pmd_i40e/i40e_fdir.c            |   2 +-
 lib/librte_pmd_i40e/i40e_logs.h            |   2 +-
 lib/librte_pmd_i40e/i40e_pf.c              |   2 +-
 lib/librte_pmd_i40e/i40e_pf.h              |   2 +-
 lib/librte_pmd_i40e/i40e_rxtx.c            |   2 +-
 lib/librte_pmd_i40e/i40e_rxtx.h            |   2 +-
 30 files changed, 1513 insertions(+), 440 deletions(-)

Re: [dpdk-dev] [PULL REQUEST] i40e base driver update

[Thomas Monjalon]

Hi Helin,

> Helin Zhang (33):
>       i40e: copyright update
>       i40e: disable setting of phy configuration
>       i40e: adjustment of register definitions and relevant
>       i40e/base: rename 'err' to 'perrno'
>       i40e/base: support of building both PF and VF driver together
>       i40e/base: support of CEE DCBX on recent firmware versions
>       i40e: replacement of 'i40e_debug_read_register()'
>       i40e/base: rework of 'i40e_hmc_get_object_va'
>       i40e/base: update of shadow RAM read/write functions
>       i40e/base: catch NVM write semaphore timeout and retry
>       i40e/base: check for AQ timeout in aq_rc decode
>       i40e/base: fix up NVM update sm error handling
>       i40e/base: enhancement of polling NVM semaphore
>       i40e/base: enhancements of NVM checksum calculation
>       i40e/base: replacement of DEBUGOUT() with i40e_debug()
>       i40e/base: add fw build info to AQ data
>       i40e/base: define and use i40e_is_vf()
>       i40e/base: grab NVM devstarter version not image version
>       i40e/base: enhancements on adminq init and sending asq command
>       i40e/base: i40e_aq_get_link_info() should be used directly
>       i40e/base: add new interfaces for future use
>       i40e/base: update of get/set LED functions
>       i40e/base: clean up sparse complaint in i40e_debug_aq
>       i40e/base: get pf_id from HW rather than PCI function
>       i40e/base: find partition_id in npar mode, and disable FCOE by default
>       i40e/base: Reassign incorrect PHY type as a workaround for a FW issue
>       i40e/base: add AOC phy types to case statement in get_media_type
>       i40e/base: support for iSCSI capability
>       i40e/base: set FLAG_RD when sending driver version to FW
>       i40e/base: future proof some sizeof calls
>       i40e/base: add more virtual channel operations for future use
>       i40e/base: rework of structures and macros for future use
>       i40e/base: modifications for future use

There was a build break due log rework in the middle of this series.
Don't forget to check series with "git rebase -x make".
I adjusted the patches order to fix it.

Some titles and commit messages were a bit too vague and didn't describe
why changes are done. I tried to improve titles a bit.
In general, giving the name of a function in a commit title doesn't give
the right level of information. Titles starting with "update" or "enhance"
won't be descriptive enough and would probably be split.
I'm not completely satisfied with it but most of things are well described
so I guess it's enough for a base driver update of a young PMD.
Though, it would be nice to have more precise descriptions of why things
are done for next updates.

Applied, thanks