From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8C8AAA0487
	for <public@inbox.dpdk.org>; Wed,  3 Jul 2019 21:56:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E9D361E20;
	Wed,  3 Jul 2019 21:56:25 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id AC0271D9E
 for <dev@dpdk.org>; Wed,  3 Jul 2019 21:56:24 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C9478600057;
 Wed,  3 Jul 2019 19:56:21 +0000 (UTC)
Received: from [192.168.1.11] (85.187.13.154) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Jul 2019
 20:56:14 +0100
To: Ferruh Yigit <ferruh.yigit@intel.com>, <viveksharma@marvell.com>,
 <dev@dpdk.org>
CC: <intoviveksharma@gmail.com>, <thomas@monjalon.net>,
 <stephen@networkplumber.org>, <ramirose@gmail.com>, <jerinj@marvell.com>
References: <1555653564-27263-1-git-send-email-viveksharma@marvell.com>
 <1562038627-5057-1-git-send-email-viveksharma@marvell.com>
 <c5de055c-5ec7-4659-9b50-cbac997afc40@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <46667eb0-e50e-f9ca-d80a-49b900b1853d@solarflare.com>
Date: Wed, 3 Jul 2019 22:55:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <c5de055c-5ec7-4659-9b50-cbac997afc40@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [85.187.13.154]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24736.003
X-TM-AS-Result: No-2.145200-8.000000-10
X-TMASE-MatchedRID: VPleTT1nwdTmLzc6AOD8DfHkpkyUphL9D+jls0cSwJMIoD7Gyec7oy1S
 BwRaWLSlMiVhIT1xQi7k9MK5wPEB7kohWBZ4QV+6boe6sMfg+k+/OTsD3tyjeQzvg1/q1MH20b/
 vhnuSfzQPTJ94iLTbSolsal69zjSy/Ly3VILoo9yh7O7qzewu4EH25SKd6AXRmyiLZetSf8nJ4y
 0wP1A6AAOkBnb8H8GWDV8DVAd6AO/dB/CxWTRRu/558CedkGIvkrXfN5BwqVEDy0KOdZ9kWwnBQ
 gwkEB8eD53+Zg3W74yLDQie0U0uOyLcdwlDyWivID5p+BT4eyQ/dvlLLmKaB/3AJKznoAmtduMG
 GD6RXw/UNewp4E2/TgSpmVYGQlZ3sxk1kV1Ja8fhIo573pBCBw==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--2.145200-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24736.003
X-MDID: 1562183783-0bN8lJFBcIE2
Subject: Re: [dpdk-dev] [PATCH v4] ethdev: support QinQ strip dynamic
 configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03.07.2019 20:48, Ferruh Yigit wrote:
> On 7/2/2019 4:37 AM, viveksharma@marvell.com wrote:
>> From: Vivek Sharma <viveksharma@marvell.com>
>>
>> Enable missing support for runtime configuration (setting/getting)
>> of QinQ strip rx offload for a given ethdev.
>>
>> Signed-off-by: Vivek Sharma <viveksharma@marvell.com>
> Hi Andrew,
>
> As far as I understand you were OK with the patch after change, can I add your ack?

Yes, please. I've tried to find some time to double-check consistency
vs supported offloads and error reporting, but have not found time yet
to do it. Let's apply and I'll keep it in mind to take a look later.

Thanks,
Andrew.