From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id E62294CC0
 for <dev@dpdk.org>; Tue, 20 Mar 2018 16:21:22 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 20 Mar 2018 08:21:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,336,1517904000"; d="scan'208";a="35371015"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63])
 ([10.237.221.63])
 by FMSMGA003.fm.intel.com with ESMTP; 20 Mar 2018 08:21:13 -0700
To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>,
 Beilei Xing <beilei.xing@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil
 <harish.patil@cavium.com>, Shahed Shaikh <shahed.shaikh@cavium.com>,
 Tetsuya Mukawa <mtetsuyah@gmail.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
 <tiwei.bie@intel.com>, Marcin Wojtas <mw@semihalf.com>,
 Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>, dev@dpdk.org
References: <20180313180534.232296-1-ferruh.yigit@intel.com>
 <20180314081453.5qkfkdk2cxml5pnp@laranjeiro-vm.dev.6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <46679aca-880a-ace6-a2c6-35d8bc14021a@intel.com>
Date: Tue, 20 Mar 2018 15:21:12 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180314081453.5qkfkdk2cxml5pnp@laranjeiro-vm.dev.6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] drivers/net: update link status
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 15:21:23 -0000

On 3/14/2018 8:14 AM, Nélio Laranjeiro wrote:
> On Tue, Mar 13, 2018 at 06:05:34PM +0000, Ferruh Yigit wrote:
>> Update link status related feature document items and minor updates in
>> some link status related functions.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

<...>

>> @@ -536,7 +536,7 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, int wait_to_complete)
>>  	}
>>  	link_speed = ethtool_cmd_speed(&edata);
>>  	if (link_speed == -1)
>> -		dev_link.link_speed = 0;
>> +		dev_link.link_speed = ETH_SPEED_NUM_NONE;
>>  	else
>>  		dev_link.link_speed = link_speed;
>>  	priv->link_speed_capa = 0;
>> -- 
>> 2.13.6
>  
> Hi Ferruh,
> 
> On mlx5 this hunk is conflicts with my series [1].

Thanks Nélio,

The mlx5 change is so minor I thinks conflict can be handled while applying.

> 
> Regards,
> 
> [1] https://dpdk.org/ml/archives/dev/2018-March/092495.html
>