From: Thomas Monjalon <thomas@monjalon.net>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: add Bus log type
Date: Mon, 19 Jun 2017 22:54:57 +0200 [thread overview]
Message-ID: <4669455.PggrvpOhcS@xps> (raw)
In-Reply-To: <943050b9-9e57-970e-cbef-01afcdb9e3ff@nxp.com>
19/06/2017 13:03, Shreyansh Jain:
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs;
> > #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */
> > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */
> > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */
> > +#define RTE_LOGTYPE_BUS 20 /**< Log related to Bus. */
>
> Just wanted to ping - is there something wrong/unacceptable about this?
Sorry for not replying before.
The strange thing is that it is not used.
At least, the existing bus logs should be converted.
I've spotted few lines in drivers/bus/fslmc/.
And more importantly, we must switch to the new dynamic types
using rte_log_register().
next prev parent reply other threads:[~2017-06-19 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:38 Shreyansh Jain
2017-06-19 11:03 ` Shreyansh Jain
2017-06-19 20:54 ` Thomas Monjalon [this message]
2017-07-02 5:31 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4669455.PggrvpOhcS@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).