From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E84B8374 for ; Mon, 19 Jun 2017 22:54:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 83EEB20CA8; Mon, 19 Jun 2017 16:54:58 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 19 Jun 2017 16:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=W5JCKz8tyaRgyq2 F7JOwXagBH0k2hdj9H0BrSWyN3Vw=; b=qrCnwqekVW6wwcBgGtJNRwWz+pqEjl9 fayl68MapsbATUaKz44zW3sIrxa2ClckqMgJhxI1HpSSW/+KATyCFcmCMDhQcw11 s1xfpg0djCdO5Otqhw+v09sjg6UkKJW9+BCwGgQilWqjvB2OUzBfa3CEAzAFYYlF UHeBmJ7J4aoY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=W5JCKz8tyaRgyq2F7JOwXagBH0k2hdj9H0BrSWyN3Vw=; b=AkB7YP7R lui6yu1TLScfy0nFvx8j2MX790U6nIXZM+e6yNXZokL9ngOrQPYWcrodU03+TJvx 4mDBSzHjKZrpDsxMx5fZQ+APZ7nOziO/eZugli6xqh6T1FdlB0ew5zOkP53hHpjc 4DfEOWotAD1Q+MCCJOl7V1mHYlVlZvOoDJznYbTgFaZ88SxNBXRTiesE4R9idEYq A3ZddB0sni1icQLcuPtxVWqc8lNToTiMS9yR++zQzPi0YhYdIpSU8AzG6LF0isXg 4MK4VKIWKbPuhm+Hw1eOsRCe6DdbYTu7o5FbvnLqKaSxhDXrCCTd+EZiHo87pfgu LeLvbGbOMC1Cdw== X-ME-Sender: X-Sasl-enc: QwrgZO7kGvEF3ZttzehqFkLCUDDr6sPeP0x/9w71XIjo 1497905698 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3DBEE7E545; Mon, 19 Jun 2017 16:54:58 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org Date: Mon, 19 Jun 2017 22:54:57 +0200 Message-ID: <4669455.PggrvpOhcS@xps> In-Reply-To: <943050b9-9e57-970e-cbef-01afcdb9e3ff@nxp.com> References: <1495604325-15743-1-git-send-email-shreyansh.jain@nxp.com> <943050b9-9e57-970e-cbef-01afcdb9e3ff@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: add Bus log type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:54:59 -0000 19/06/2017 13:03, Shreyansh Jain: > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -87,6 +87,7 @@ extern struct rte_logs rte_logs; > > #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */ > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > +#define RTE_LOGTYPE_BUS 20 /**< Log related to Bus. */ > > Just wanted to ping - is there something wrong/unacceptable about this? Sorry for not replying before. The strange thing is that it is not used. At least, the existing bus logs should be converted. I've spotted few lines in drivers/bus/fslmc/. And more importantly, we must switch to the new dynamic types using rte_log_register().