From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
To: Stephen Hemminger <stephen@networkplumber.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: David Marchand <david.marchand@redhat.com>,
Markus Theil <markus.theil@tu-ilmenau.de>,
dev@dpdk.org
Subject: Re: [PATCH v2 1/2] eal: expose lcore pthread id
Date: Thu, 06 Jul 2023 07:50:08 +0200 [thread overview]
Message-ID: <4669e4450971f24375978b33e30111d98975ec2b.camel@tu-ilmenau.de> (raw)
In-Reply-To: <20230705195722.31993ca2@hermes.local>
On Wed, 2023-07-05 at 19:57 -0700, Stephen Hemminger wrote:
> On Tue, 29 Nov 2022 14:04:45 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > > Markus and I ultimately use the function in the patch to call
> > > rte_thread_setname() (which takes the pthread id as an argument) to
> > > rename our
> > > lcore workers from "lcore-worker-X" to something more meaningful in the
> > > scope
> > > of our application. Having descriptive thread names makes debugging
> > > significantly easier. For example, verifying CPU pinning worked as
> > > intended
> > > with ps -T ..., or identifying threads in the Intel VTune profiler.
>
> Why not have the worker threads rename themselves?
That's the way we ended up with, i.e. something like
rte_thread_setname(pthread_self(), "...");
called by each worker.
I guess due to the possibility to set the name by pthread id, and obtain it for
ctrl threads, but not for regular workers, we got the impression of a "missing
piece" in the API. I understand the motivation to keep pthread internals out of
the API, so i guess we can drop the patch.
Thanks
Michael
--
Michael Pfeiffer
Technische Universität Ilmenau
Fakultät für Informatik und Automatisierung
Fachgebiet Telematik / Rechnernetze
E-Mail: michael.pfeiffer@tu-ilmenau.de
Telefon: +49 3677 69-4854
Web: https://www.tu-ilmenau.de/telematik
next prev parent reply other threads:[~2023-07-06 5:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 6:20 [PATCH " Markus Theil
2022-10-14 6:21 ` [PATCH 2/2] eal: prevent OOB read in rte_lcore_to_socket_id Markus Theil
2022-10-14 7:54 ` [PATCH v2 1/2] eal: expose lcore pthread id Markus Theil
2022-10-14 7:54 ` [PATCH v2 2/2] eal: prevent OOB read in rte_lcore_to_socket_id Markus Theil
2022-10-20 11:20 ` [PATCH v2 1/2] eal: expose lcore pthread id David Marchand
2022-10-20 15:36 ` Stephen Hemminger
2022-10-20 20:03 ` Michael Pfeiffer
2022-11-29 22:04 ` Tyler Retzlaff
2023-07-06 2:57 ` Stephen Hemminger
2023-07-06 5:50 ` Michael Pfeiffer [this message]
2022-11-12 0:34 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4669e4450971f24375978b33e30111d98975ec2b.camel@tu-ilmenau.de \
--to=michael.pfeiffer@tu-ilmenau.de \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).