From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FBBB42DE2; Thu, 6 Jul 2023 07:50:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1243240A79; Thu, 6 Jul 2023 07:50:13 +0200 (CEST) Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67]) by mails.dpdk.org (Postfix) with ESMTP id 891D240144 for ; Thu, 6 Jul 2023 07:50:11 +0200 (CEST) Received: from jaime-2.fritz.box (unknown [80.153.69.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id E16E2580099; Thu, 6 Jul 2023 07:50:08 +0200 (CEST) Message-ID: <4669e4450971f24375978b33e30111d98975ec2b.camel@tu-ilmenau.de> Subject: Re: [PATCH v2 1/2] eal: expose lcore pthread id From: Michael Pfeiffer To: Stephen Hemminger , Tyler Retzlaff Cc: David Marchand , Markus Theil , dev@dpdk.org Date: Thu, 06 Jul 2023 07:50:08 +0200 In-Reply-To: <20230705195722.31993ca2@hermes.local> References: <20221014062100.5761-1-markus.theil@tu-ilmenau.de> <20221014075421.10300-1-markus.theil@tu-ilmenau.de> <20221020083605.274c43f2@hermes.local> <20221129220445.GB31725@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230705195722.31993ca2@hermes.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 2023-07-05 at 19:57 -0700, Stephen Hemminger wrote: > On Tue, 29 Nov 2022 14:04:45 -0800 > Tyler Retzlaff wrote: >=20 > > > Markus and I ultimately use the function in the patch to call > > > rte_thread_setname() (which takes the pthread id as an argument) to > > > rename our > > > lcore workers from "lcore-worker-X" to something more meaningful in t= he > > > scope > > > of our application. Having descriptive thread names makes debugging > > > significantly easier. For example, verifying CPU pinning worked as > > > intended > > > with ps -T ..., or identifying threads in the Intel VTune profiler. >=20 > Why not have the worker threads rename themselves? That's the way we ended up with, i.e. something like =20 rte_thread_setname(pthread_self(), "..."); called by each worker. I guess due to the possibility to set the name by pthread id, and obtain it= for ctrl threads, but not for regular workers, we got the impression of a "miss= ing piece" in the API. I understand the motivation to keep pthread internals ou= t of the API, so i guess we can drop the patch. Thanks Michael --=20 Michael Pfeiffer Technische Universit=C3=A4t Ilmenau Fakult=C3=A4t f=C3=BCr Informatik und Automatisierung Fachgebiet Telematik / Rechnernetze E-Mail: michael.pfeiffer@tu-ilmenau.de Telefon: +49 3677 69-4854 Web: https://www.tu-ilmenau.de/telematik