From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AD5F6370 for ; Mon, 12 Dec 2016 18:53:59 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 12 Dec 2016 09:53:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,337,1477983600"; d="scan'208";a="1071172927" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga001.jf.intel.com with ESMTP; 12 Dec 2016 09:53:57 -0800 To: Harish Patil , "dev@dpdk.org" References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com> <1480733039-13046-2-git-send-email-harish.patil@qlogic.com> Cc: Dept-Eng DPDK Dev From: Ferruh Yigit Message-ID: <466b1cf9-78b0-4449-68a0-f5a0e20dbb5a@intel.com> Date: Mon, 12 Dec 2016 17:53:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/7] net/qede: refactor filtering code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 17:54:00 -0000 On 12/12/2016 5:36 PM, Harish Patil wrote: > >> On 12/3/2016 2:43 AM, Harish Patil wrote: >>> The filter_config in qed_eth_ops_pass is a wrapper call driving all the >>> filtering configuration. This requires defining multiple structures and >>> passing different function arguments for each filter type which is >>> unnecessary. So as part of this refactoring we remove filter_config from >>> qed_eth_ops_pass and invoke base apis directly. Another change is to >>> use a singly list for unicast/multicast macs and thereby prevent >>> duplicate >> >> singly linked list? > > Yes. Two lists to track unicast and multicast mac entries: > + SLIST_HEAD(mc_list_head, qede_mcast_entry) mc_list_head; > > + SLIST_HEAD(uc_list_head, qede_ucast_entry) uc_list_head; > > > >> >>> entries. >>> >>> This change is primarily intended to support future tunneling support >>> which makes use of existing L2 filtering/classifications. >>> >>> Fixes: 2ea6f76a ("qede: add core driver") >> >> What is fixed in this patch, isn't it a refactor? > > The fix part is to make use of the newly added lists and prevent duplicate > mac filters. > Before that there were no checks. Other than that its refactoring to > mainly invoke direct base APIs. So this is not fixing any defect in driver, so I believe Fixes tag can be removed. This tag is mainly useful to pick commits for stable trees. > >> >> btw, all Fixes formats are wrong in the patchset, can you please use the >> git alias provided: >> http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body >> >>> >>> Signed-off-by: Harish Patil >>> --- >> <...> >> > >