From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id DB74F37B7; Thu, 9 May 2019 16:59:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6706D25A86; Thu, 9 May 2019 10:59:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 10:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gX0LpmKRWG6eIVUjUJdYl/dxLINK6LK1aQXRabe4BKk=; b=jHqCDbWdpCyF oj4KL/ouYKOk32SSiTARA/GdlVRF3mxdZ14O/3+xvIotry+aKZbcBH3Z9dNAdl3Z ExJxvnK3eN7uUfLc3f2Z5dFIVjemdIPG37kVg5b77FLgnXTGZhMDbzkTpHbc/5dV Tm9RHTvNAvs03kZsbsPTtaAmvnqPYcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gX0LpmKRWG6eIVUjUJdYl/dxLINK6LK1aQXRabe4B Kk=; b=sgzY3vcv+2ct+T/hR5V4cc3l8RSTKmvQf3f5x6LL72vOg8vPPME5jCNnf hyOZiBQppMr6Mm6Y/xKQxzHOBXUpdpSu1WNd1BgF/YtIN3YTT5ORofPWW+RlA5R+ oMORCTprz/DsGg7J5REj8VfH1B0/Ug0hBdbAHnaQfND3UfY1ubBqbrO2ycYS7+1r fw44Qzr3po00aGCMJGmDwUPjKWcaSBL4VD5eQETkM/sEKU4eOJfHRyM6eP2b6cYi UpJ32v4Ta5W4uzm/ldc6YQiDtyDY7sRPTpxbhOyUBmj2i/GK7waZG8wDG3Mjf8K1 XZjxUvS3Zq1wckKh0dbYlrEy0sudw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24BF98005C; Thu, 9 May 2019 10:59:40 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: stable@dpdk.org, dev@dpdk.org, John McNamara , Marko Kovacevic Date: Thu, 09 May 2019 16:59:38 +0200 Message-ID: <4673364.Vn0jRf8MzI@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] ipc: add warnings about correct API usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 14:59:42 -0000 03/05/2019 13:50, Anatoly Burakov: > When handling synchronous or asynchronous requests, the reply > must be sent explicitly even if the result of the operation is > an error, to avoid the other side timing out. Make note of this > in documentation explicitly. > > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -226,6 +226,11 @@ struct rte_mp_reply { > * As we create socket channel for primary/secondary communication, use > * this function typedef to register action for coming messages. > * > + * @note When handling IPC request callbacks, the reply must be sent even in > + * cases of error handling. Simply retuning success or failure will *not* send retuning -> returning Will fix on apply. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ADDD7A0096 for ; Thu, 9 May 2019 16:59:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0B053977; Thu, 9 May 2019 16:59:43 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id DB74F37B7; Thu, 9 May 2019 16:59:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6706D25A86; Thu, 9 May 2019 10:59:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 10:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gX0LpmKRWG6eIVUjUJdYl/dxLINK6LK1aQXRabe4BKk=; b=jHqCDbWdpCyF oj4KL/ouYKOk32SSiTARA/GdlVRF3mxdZ14O/3+xvIotry+aKZbcBH3Z9dNAdl3Z ExJxvnK3eN7uUfLc3f2Z5dFIVjemdIPG37kVg5b77FLgnXTGZhMDbzkTpHbc/5dV Tm9RHTvNAvs03kZsbsPTtaAmvnqPYcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gX0LpmKRWG6eIVUjUJdYl/dxLINK6LK1aQXRabe4B Kk=; b=sgzY3vcv+2ct+T/hR5V4cc3l8RSTKmvQf3f5x6LL72vOg8vPPME5jCNnf hyOZiBQppMr6Mm6Y/xKQxzHOBXUpdpSu1WNd1BgF/YtIN3YTT5ORofPWW+RlA5R+ oMORCTprz/DsGg7J5REj8VfH1B0/Ug0hBdbAHnaQfND3UfY1ubBqbrO2ycYS7+1r fw44Qzr3po00aGCMJGmDwUPjKWcaSBL4VD5eQETkM/sEKU4eOJfHRyM6eP2b6cYi UpJ32v4Ta5W4uzm/ldc6YQiDtyDY7sRPTpxbhOyUBmj2i/GK7waZG8wDG3Mjf8K1 XZjxUvS3Zq1wckKh0dbYlrEy0sudw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24BF98005C; Thu, 9 May 2019 10:59:40 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: stable@dpdk.org, dev@dpdk.org, John McNamara , Marko Kovacevic Date: Thu, 09 May 2019 16:59:38 +0200 Message-ID: <4673364.Vn0jRf8MzI@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] ipc: add warnings about correct API usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509145938.X6ujCzWqDZ7tR-4IU1g4oKeNhZajDA2cVOIjd99klsE@z> 03/05/2019 13:50, Anatoly Burakov: > When handling synchronous or asynchronous requests, the reply > must be sent explicitly even if the result of the operation is > an error, to avoid the other side timing out. Make note of this > in documentation explicitly. > > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -226,6 +226,11 @@ struct rte_mp_reply { > * As we create socket channel for primary/secondary communication, use > * this function typedef to register action for coming messages. > * > + * @note When handling IPC request callbacks, the reply must be sent even in > + * cases of error handling. Simply retuning success or failure will *not* send retuning -> returning Will fix on apply.