From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4FB502C18 for ; Fri, 28 Apr 2017 11:00:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 08060209C3; Fri, 28 Apr 2017 05:00:09 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 28 Apr 2017 05:00:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=KDYxiFh95E+/EPk UCtmWmyIR7E6S3IpPoStKkyWREcg=; b=eL8hOQRFHh1I9F8Lf6R6fBpJzPPHApn ktmCdJGMAA/RZPD9rH7nEeePq6Y+7Z7McGgaDQ3dCgt4WJ6ffxe5lNVRjWZeyY6e K19uqrak6tk2UHLrMKx+VKUdIaeayjBIIyTuV9Z6tg3Snzd9Q0k8b41FxaQG1lDk s+ybQoFPpSDs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=KDYxiFh95E+/EPkUCtmWmyIR7E6S3IpPoStKkyWREcg=; b=KpxzUR1z xEzk28v15X4nyfYZkwnIRtdthbDnzt2bgYWz7gStJbvi/ZoAN2PPU5xzkjAZ9//G 0WvXS+n9QThIaUTAk0U6wiJrN6yMICtqPGMIpROhyTmT1LK1SZd26I/IeZPOZEcL 3XXB0vT8zekdNSxTZov1NFVESjojOw4lnpWbljDYYOP1RO8ffRwNw3JzLYwTw0w/ sUoBrtsHc5/KLiRqoC21z9xWhWVMav0hOriA3TWKdehmBGaXz+Fm4h8dVu2L+s5q GLyLKDRcvodghJ73BQmXuwu1b8nlGNsxk5uckWrwVIiJkR3tT8wzJXK0WbXPDN2E HMfzemMvo5wwMA== X-ME-Sender: X-Sasl-enc: zH/c0xd++VRLpl0o3Hc5u4vQGeYv5im4ark0Ymvm7MLD 1493370008 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B0F4A24140; Fri, 28 Apr 2017 05:00:08 -0400 (EDT) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org Date: Fri, 28 Apr 2017 11:00:07 +0200 Message-ID: <4676086.N97G0cgc3q@xps> In-Reply-To: <20170428082706.GY11512@yliu-dev.sh.intel.com> References: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> <1679460.mJD8jeqIBn@xps> <20170428082706.GY11512@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 09:00:09 -0000 28/04/2017 10:27, Yuanhan Liu: > On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote: > > 28/04/2017 09:21, Yuanhan Liu: > > > Some commits for stable releases (with Cc stable tag) may not have the > > > fixline. For example: > > > http://dpdk.org/dev/patchwork/patch/23955/ > > > > > > It disables a feature we have implemented in last release. The feature > > > is done right. It's the QEMU implementaton being buggy, that we have to > > > disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without > > > such workaround, QEMU won't start when queue number >= 2. > > > > > > That said, we also have to backport it to stable releases, though there > > > is no fixline (there was no DPDK bug to fix after all). > > > > How do we know where should it be backported? > > Good question. As a stable maintainer, I may not know. But the developer > should know. For such case, he may add something like: > > Cc: stable@dpdk.org # for v17.02+ It breaks backport semi-automation. > It's a trick used widely in kernel and QEMU community. > > > It is fixing a bug with a correct implementation because of > > a buggy dependency. But it is still a bug. > > So I think we should put a Fixes: line. > > I don't have strong objection to this. It just doesn't make too much > sense to me: there is no bug in the DPDK implementation after all. > > But if you insist, I'm okay with it. Yes I insist :) It is fixing code to work with some dependencies. > > > There should be similar cases like this. Thus, this patch makes > > > git-log-fixes.sh script also list those stable commits do not have > > > fixline. > > > > I am against putting Cc: stable without Fixes: line. > > General, yes. And luckily, that should be rare. > > > However, this patch is harmless. > > Yes. Moreover, we should not miss some important fixes with it.