From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id BB2F28E64 for ; Thu, 21 Jan 2016 12:50:11 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id n5so76420340wmn.0 for ; Thu, 21 Jan 2016 03:50:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=8T7+1xAmC8S4FLZPUFuJ9d93/lN9w3bPHDPB7QgRSkU=; b=o7ykfLAzXYPncoG2K72JxiNdLyik7xUVSdwNode/xnCBhSbopYWDnbJPZY7ZuX2KZ6 y1vgCJTKeFFPm0tZsAyvhoIIChWwSu5syfTETbsfPHjFKvcbeXCCZQyv0ntdmnMDzcQm wKROrTu0ks3y93GJPufT4Vgf1i1S7XCgNBoCUL8Nq8q5KkXYDANF5TawWXz2JRV/3aUq vchGsWelGrn1tisA59TWz8sq5EaLaTuCGjnXFCawLVQhPpH7UUhmwnCxJHtIJsNw2NNq 39UBZOzckB54m4zZLZlecRq7V++y0bb0LRk3IY+L+s9iDMtJXhzNYWCFkRQ5QBXg34w9 cA/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8T7+1xAmC8S4FLZPUFuJ9d93/lN9w3bPHDPB7QgRSkU=; b=NSws0CSVxTCIV8s/Qa5GJWJ9MUXJ/XwN3YDNShq4nieYzT8AQGzCVsM5GtvumAWVV2 SJkwRw+APYlX6sxK9t6iYiFBMEKgDYzALArLHdRAqZ7+UrkXgkiTtrVhttcunVHbsRFW vi1BsYXzFWZ4Hv6D6Iyck8z9P+LZpE1JTb1n9yx3L5EGdpf23ltrPzW7RcdvB24e3ZOs bhFICQPgNI1m99uCrdJX5nuQYTiF0WnjEqlSV7keYF2hcYqkyN38zY/Xv/K5jJlDV4VX riVdWVbn2S/A7+W03vlqYQpn+/6tTTrY2hP5dCnKJLsD0b3KHEBuq4CvAvNzmg3uXdHs yRbA== X-Gm-Message-State: AG10YOSXWLNpljmXn8HU2FOBRzeCS8apH9EtUPxK4UnSf/Xk7uwmwNID8XgBmOo1A/U0H3no X-Received: by 10.194.61.111 with SMTP id o15mr21240622wjr.104.1453377011442; Thu, 21 Jan 2016 03:50:11 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id cv10sm1118022wjb.17.2016.01.21.03.50.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jan 2016 03:50:10 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Thu, 21 Jan 2016 12:49:10 +0100 Message-ID: <4677246.JVjdGphvhY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453191125-26335-9-git-send-email-yuanhan.liu@linux.intel.com> References: <1452832571-6156-1-git-send-email-yuanhan.liu@linux.intel.com> <1453191125-26335-1-git-send-email-yuanhan.liu@linux.intel.com> <1453191125-26335-9-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 8/9] virtio: add 1.0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 11:50:11 -0000 2016-01-19 16:12, Yuanhan Liu: > int > vtpci_init(struct rte_pci_device *dev, struct virtio_hw *hw) > { > - hw->vtpci_ops = &legacy_ops; > + hw->dev = dev; > + > + /* > + * Try if we can succeed reading virtio pci caps, which exists > + * only on modern pci device. If failed, we fallback to legacy > + * virtio handling. > + */ > + if (virtio_read_caps(dev, hw) == 0) { > + PMD_INIT_LOG(INFO, "modern virtio pci detected."); > + hw->vtpci_ops = &modern_ops; > + hw->modern = 1; > + dev->driver->drv_flags |= RTE_PCI_DRV_INTR_LSC; > + return 0; > + } RTE_PCI_DRV_INTR_LSC is already set by virtio_resource_init_by_uio(). Do you mean interrupt was not supported with legacy virtio?