From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0078.outbound.protection.outlook.com [104.47.38.78])
 by dpdk.org (Postfix) with ESMTP id C5ACC133F
 for <dev@dpdk.org>; Wed, 22 Mar 2017 05:40:21 +0100 (CET)
Received: from BN6PR03CA0064.namprd03.prod.outlook.com (10.173.137.26) by
 SN2PR03MB2272.namprd03.prod.outlook.com (10.166.210.17) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
 15.1.961.17; Wed, 22 Mar 2017 04:40:19 +0000
Received: from BL2FFO11FD046.protection.gbl (2a01:111:f400:7c09::182) by
 BN6PR03CA0064.outlook.office365.com (2603:10b6:404:4c::26) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via
 Frontend Transport; Wed, 22 Mar 2017 04:40:20 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
 smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
 designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; 
 client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
 BL2FFO11FD046.mail.protection.outlook.com (10.173.161.208) with Microsoft
 SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id
 15.1.977.7 via Frontend Transport; Wed, 22 Mar 2017 04:40:19 +0000
Received: from [10.232.14.39] ([10.232.14.39])
 by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2M4eG5u020362;
 Tue, 21 Mar 2017 21:40:17 -0700
To: Anatoly Burakov <anatoly.burakov@intel.com>
References: <1490112483-5603-1-git-send-email-anatoly.burakov@intel.com>
CC: <dev@dpdk.org>, <gowrishankar.m@linux.vnet.ibm.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <467aba33-3bcb-0d1f-c762-4281b2f5a870@nxp.com>
Date: Wed, 22 Mar 2017 10:16:17 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490112483-5603-1-git-send-email-anatoly.burakov@intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131346312201249372;
 (91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
 SFV:NSPM;
 SFS:(10009020)(6009001)(336005)(39380400002)(39850400002)(39400400002)(39410400002)(39840400002)(39860400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(3190300001)(189002)(199003)(24454002)(377454003)(9170700003)(50986999)(36756003)(54356999)(54906002)(8676002)(6246003)(65956001)(104016004)(230700001)(189998001)(50466002)(229853002)(6916009)(5660300001)(2950100002)(65826007)(65806001)(2906002)(4001350100001)(76176999)(53936002)(105606002)(81166006)(31686004)(4326008)(31696002)(305945005)(356003)(33646002)(47776003)(77096006)(86362001)(64126003)(85426001)(8936002)(23746002)(38730400002)(106466001)(110136004)(83506001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2272; H:tx30smr01.am.freescale.net;
 FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; 
X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD046;
 1:CPvAL8AJOyo8vMBgXXpANmHY7puT2numi6YlU1Tu8XS9nYnUu5W/CArnqdOLDK3eBNGbIeBZRe0gPldJMRrSJ8j0NabP3Bt/kPgdr3PeYG38MSG7qwgFOKr4ypiHXzm26Jm4kmQd8RoBRZEzSxalviqXrOxDyZBcik2JtyEFnkxacOF4XQn2iFoMGVy23NcZ5+3G2NzBKgUaZicZJBLP7tFsk7TITCnkICP/ZHuVbHcsehaxUG1NJXGFYYNsyXgVNvDXIYR1yCIvwpBkvBCIXHB24pyzV8U9QPPwNcVxMsrVCcUYXLk7vJIiQciKgwjOgleZcDH0OILggEg9jAMLMl/YTRyzQaNBn6iUb0+j2mfOgW4VKfKpO14QXLfy6AttHlYNbMZ6N9jzp380couyA7gmpCvjPMXUNR+btG8B7EhWIDpT9bJbVAllnz6GHhR2fSOB9qKRivmtdaU6vyH8RBkFY2DY12FH/af2jwK+vE7MGwi+QL4jzX6I/fGdv5CDSFitbaa680a328TYuDBRlh6ll8vi+OXERxXnG+8vJvX0DO9pt9qcBfTO7sv6YqjDYkNKqmaNDWei4qObHUQ0W4sp1YpVnHDUS3a6mFjAdtu3IJ0ClkSyb283UcGBSXN6
X-MS-Office365-Filtering-Correlation-Id: 67b0e74d-1aa7-4461-5fa0-08d470dd8bc2
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR03MB2272;
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2272;
 3:UX6nPCO8BlflA3On/DtNvk0+/umzmOKP8qLu9OclOVV8aPaB8CFLiAYoypR2o69qnlOSCZ7KwNsFDHhNBIY2zmtxOdmKBsu64803lx4FbtM8vqnt67xWbJi0KF2TIWlPfvE4MXy+t51cnLCkSFBNEl9eckhGh6cGWwuT0XBUqj00Wlsmmn/yCPpW+poKkxB7MFNtgakEeWoTHuKe/Slp8ycmyZ0GWv0xCdNRv24I4YHRq5+MlAE1S58e+ECKw12Umjvyk2QF6P3XYxTxyKwomlKw2Di0/0no4iHXbVDEieJdnLjQC6cEsK0NO8o05qLajuHhxcz36WEYm7uefrj/CkJlMfEf4qV8k0Wn/o6+KTYfPNfMW6ojnsF1Fpoubaw8;
 25:JjviScT2TbDsrgebfo6AKAIhvdVkNB/nHqHc4FliWQeCFKZJNpj/ebQ8GUK2F3GRIFZPokIB+2+7Rf7o4YJTwPLK1/Xe262eAQryjKMWpWDMWY1nkF+6sU6D3MarDwtFi40sqRmrQQ4k2qhW7T9jWRj/W04CsRfDoAFHM5Xv5iBQ3yOOfqBO3XTsgqfBrajGLk2hnUxmYxUPSFYLjZzZo/8uI1SbEPp2V+0oNccxzLWFb40IBb7gzD/EQ/NufcWXI7Mcv5672v3gWsnbSwgvaIVpIMSIpcYtImi/TJcvuzGgjFTcx83quzK6aIuhpTp/pO2FPZ+OPrbrLVF9EvkAjtxa/hsN7YJkaAT1Tah9N7nOIt+a65nVIvt3sREJScYqiON+55ZbF9a/hR90nN3+K1Jt9Y5rMmSNIODjE3PX3CgtOe7GqLQCS7l0/BvhDwyvskbKle5/o6BBCDcY73gYaA==
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2272;
 31:OfG8IjDvgc4cmxIoofBTOwu2LARlOhzFSArLYzCnzwEtiS1bY2GkTpEj8OCKSBTAohqtJ9qQA5OqUOZzBGUzJho5c0wsjLgRu61UflHw1XOvdrfm+i674Aeh+DiDIRcAj3DNx/QyjSARP91d8jh0+iKv6/CqkB/hJSFK7TQql6dyT+/3hlXi45ww6E8pouSMimvTsoRKnEA2imfFNZzhT+SWJhUaqXw+6mLijezZkeusubEyzNsOBObWgsKH3R1vohza2lS75eI2eqpMTl6oAg==
X-Microsoft-Antispam-PRVS: <SN2PR03MB2272E8811CDDCF6DFAFD8B7A903C0@SN2PR03MB2272.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(6095060)(601004)(2401047)(13023025)(8121501046)(13015025)(13017025)(5005006)(13018025)(13024025)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025);
 SRVR:SN2PR03MB2272; BCL:0; PCL:0; RULEID:(400006); SRVR:SN2PR03MB2272; 
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2272;
 4:qH3S1hR7JTPEGYm/l3/yMyo2cK7gH4WbZqlOKJNst9NG5rT2EfWvk4SDyrczx54KyxFhcjE6HeClQ6MI0CefChQDYUR8pmoWRZtzuqwNLG1yqoBJa5xCjXJtg2m5blPJ2Y+q5B4WZYIA7s7ME/qVx8LhcwtyIJt8RDVWVA3z9KJOdWyLN70r7Xr75E+eT6l0BeWTfgt+/94G2xgDUFaIZ3hhuVhfs310s0d/5nVU30RggAM+5fvgWBClkWajjeU4oHsLM/dpV05z2dEEQslqsCnzvQQ27SFik8BhstXgAE8A+lTG+thPmw2vpI8ssc/SzKzsLcjVKXiBzaxqsR4iwwGL6hPiEoNw0L8BNsbG3aY8sSWSlXmdXZWWTHYkghgVDROwt0PenAk6KCIOhQJp1kBzkADSUv/OhzCseegIlqpLu+vAH0mAPWRVHYvgV346ND5rTVoOwz4do1nqd8noJVuE9U5lboRyNdIpTlop0PqaaG0r9bq5TOOuocCwAAqQqYzHbHUOO9YPG/CAlg1CEztm2gr7wsfqTXSY/YddQJ446v4FhXGBUG+Q50zg+/Y2zTOsvQS1vnrn/JuNeBbYtGsgMX63aBaw6j1RRogFcdGA0tkLf9j/+GsyvJUFFD+IkaVyZNRNfmKBVUthKeMk1T7hSStXO9Ut53hyEN4SdEKa6fkgkds4cmpeyX4u6iluQUvmSf65b+TSmJto4k9FA5/X8HIjhUXsaApcqo0PUGBL+5zNlDHMHlY4vXtobcg1
X-Forefront-PRVS: 02543CD7CD
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR03MB2272;
 23:NnDtuDc/nA9us9q1gcpb69FbCHN6S4ALXWGzk?=
 =?Windows-1252?Q?vCCtrLpOxW/LNCcJV5NmTDNFNXXr1M5kWCaCWgQOsBu5y1HCsN8mpZc9?=
 =?Windows-1252?Q?d2OQ6MNm1jWKI/fwPLNzCx16kxOIHAnvp9ip8Knpa81TmkRpoDfzmCUh?=
 =?Windows-1252?Q?PRyU3ZiO50Gs/1Y5vW/Vh/RvhUekNimk//p7qQyc8SccHsXThyIxUMJ0?=
 =?Windows-1252?Q?vEScZR1LyzSNlx2ZaBtfCdHSUsMJYYl9P7KjZlxDaKFKxmIY5hGLDCi/?=
 =?Windows-1252?Q?rbGnLZVvd+QCbWHtW00spAjGJDErKSNZekh9Oo0iC1iUch8QamiltIcs?=
 =?Windows-1252?Q?NJ8VZ2Yboi4eenS2xDhoNVOW6sk2dVII2ylbYRjo4zSvBrXKibd4UXN7?=
 =?Windows-1252?Q?TlejO/BuMdLKeCyAQZvnmN+gTVXeda7/OCvGcnsRBJAC+Mv+TFYAmVRh?=
 =?Windows-1252?Q?p5LK2ZeVU88dRTydIeM7xU/yE97Tg95k5jp5pAM46HHia2iI3/nnsfwG?=
 =?Windows-1252?Q?Lxz8k7tg2QgF9iAIjKtzyTQHDULMSRJ590n8cNz2NO+Pm30rmgo07M+J?=
 =?Windows-1252?Q?d6KN8NZc4UyNupWD0w/xQTPQ2ghDeBTQhOWV1nsPUk0FekSaR/YZu4Zv?=
 =?Windows-1252?Q?IBHHEhYt/Zq1bEubrCa+Rqq/dQj2wyR17RYRDYilQ/RTDr38YZbztM9Z?=
 =?Windows-1252?Q?PeLeoM1cAHjD7bNzCB3spvVTYacnMmpHqhv0e8A6mKGqGCLjazIaSViS?=
 =?Windows-1252?Q?/2q9qDZLgekPLut3ozZ/tIEsAqzzl9lL7X8TbX778PD7jiYTDSumenLy?=
 =?Windows-1252?Q?g4s0L0DJ9ZET30vHDx50CxzM9cEPd6uIyqoqJnaDSm/f2PBmGP2RMbn5?=
 =?Windows-1252?Q?SVGOcCC+3BVqSE0NX34SZGqyptPpDg72UVoE0/oenM8AUcgZ1201LHW8?=
 =?Windows-1252?Q?qpmavTMtvDmalnki02R/crjvybbMxGWa4lF3tBCLnMOQgK9tLetL4UpU?=
 =?Windows-1252?Q?5Bw8dgWStQtczhDGDJIqJN65UMWftMGEie86dJn1utnuS5Uk/tpGXxkk?=
 =?Windows-1252?Q?S/lScsv0VkPiVQITsn8nNKm0YoEb6TxJaIi1riY5YZNhWDMDchQSfJ3D?=
 =?Windows-1252?Q?SUO7SI925Gsjr/bj0ufrCnFEULsf48DPzeodXhQZegrILraFbJjb1ONc?=
 =?Windows-1252?Q?zk9sNspmknz0r0VyfpJe4/A9p9CEUj7E5E+NfWbSlTUgHFHpwGoGY0xB?=
 =?Windows-1252?Q?QOC4HiLpSbkvr4qVqUpbITYNZyXzjsrCR7R8uceJAMavn9sGl5KWoncX?=
 =?Windows-1252?Q?5lgqFH1Y44YdvqL9/AZWOKhFNDn+ucY1w24lNwDUpjumPGmyyZTXXXTE?=
 =?Windows-1252?Q?KsmzgpXEMMa1p9KSSU6mTBJpX2FqV8Slq7AtVQpDSi0R0hNUt2gubjg/?=
 =?Windows-1252?Q?sy2Z9k/DXSnbjy6SyPnRuRj4XsfMZM1Z3dupsXFga+QBq5KNlJNJzrfN?=
 =?Windows-1252?Q?5xRMmJ5XWXnIJ/PHJ6a1YewMPHGMd9T9+K3OFOfc64TT/UHFFMnGfiOB?=
 =?Windows-1252?Q?Y3cjnvbXtI41+g=3D?=
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2272;
 6:aaAJOtQUIG+pYUOo0UuP2i5QBr2WWs/9/oS+/itjXLXNvDWGh9kKRFX6aEwbxAxJwrq9yHvnDL52YHbgU1MTU5135pkVjTPdQOmSHRwQ6OoSIkxhyTLetmpYXAiBJDKoJ5vUtCw5eJZl+alvoEg9RJHJmbqPHGRQyoF77U02fBGVRTAMeFjXUeHb/H3PULfHTK6Y+4gj3cX2lRxhTDbj82b+wjBJ7C9Kf1hdTvCW9ChAw2LCSfrUU/IdmyOqojZzx0r2ENTkWPm1uQ4A1To04ZS3AblEbKJsWf7fhV0dXtYChfX7od3L3mTPxDlUMazaI5eYRD8+1Ox9z2qW5mB2zNYikjibQ5Vm+0cq92e7+1jc1rSZIWsZE/dGEQYKDT5dQy4mlW3WHLnQwCuY0G68gIgbLXR72VkuEWquJ/SI3sE=;
 5:96l515EOLK6fIrFKRqpEpys2eydGpMDVx+DmoxWRL/HbG4vUsVkhLlIxxgsCJD5+AfrlB5hOC4DsDJIe6zzMhd8hSEfOuU7OuxA0L8z21uQBMHd55IQguWlFxF143Ytnr3XTmTXSdTro37NhaWgiUD43/dPXCznGbWgWalgIN0vyQvfwPAgoZC1nbncrFSjj;
 24:8b6yMEO5MhHMdFNtlAWOuQs3JNTV//DAvHJZ5LAobJdhfGb4AhPzKHmBWu+tlPkFnoGK/0Pfp1Fdq7kbpKm3UkGBjYSKLP+X6gsOvaPGASI=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2272;
 7:B3ibwVhTwk2SOaipaqwBP1tP5lEiPSU5DXPOYTebnQG3RFgMDU7gm1HvjVSnymxexyTHXMPJK2kLrf1L13kZgSCktE6wOJZ1xfiVKMd/yUlmKhCB4MDOL6mzm69L+EdY67e6fdDlVJ7ejTv2ZV1QIWUFyc/0/LdOhz5FEd0idmBr0w9a8Y1YWXlBVjysqjcRuXz3tXvoo7l7D+V6Cyu5p3QDSZh+W9I+CVvLhHA8qqD55CDtnJSFMZBSIQD0Myrn7UZ68v7z+Ja8SdEmnlCwzygh9opchaSa9DPak2e7g9sByHjOsMCx2cINtEIRf3FyAouBmUyJEyC1wSAS5o1nZQ==
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 04:40:19.9221 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
 Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2272
Subject: Re: [dpdk-dev] [PATCH] vfio: fix compile on older kernels
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Mar 2017 04:40:22 -0000

Super trivial comment inline:

On Tuesday 21 March 2017 09:38 PM, Anatoly Burakov wrote:
> From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
>
> Fixing compile failures for kernels without sPAPR IOMMU support.
>
> Fixes: 0fe9830b5345 ("eal/ppc: support sPAPR IOMMU for vfio-pci")
> Signed-off-by: Burakov, Anatoly <anatoly.burakov@intel.com>
> ---
>  lib/librte_eal/linuxapp/eal/eal_vfio.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.h b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> index ac31a4f..58b7976 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> @@ -59,6 +59,7 @@
>  #define VFIO_IOMMU_SPAPR_REGISTER_MEMORY _IO(VFIO_TYPE, VFIO_BASE + 17)
>  #define VFIO_IOMMU_SPAPR_TCE_CREATE _IO(VFIO_TYPE, VFIO_BASE + 19)
>  #define VFIO_IOMMU_SPAPR_TCE_REMOVE _IO(VFIO_TYPE, VFIO_BASE + 20)
> +#define VFIO_IOMMU_SPAPR_TCE_GET_INFO	_IO(VFIO_TYPE, VFIO_BASE + 12)

I guess a new line should be added here and ...

>  struct vfio_iommu_spapr_register_memory {
>  	uint32_t argsz;
>  	uint32_t flags;
> @@ -75,6 +76,18 @@ struct vfio_iommu_spapr_tce_remove {
>  	uint32_t argsz;
>  	uint64_t start_addr;
>  };

and here...

> +struct vfio_iommu_spapr_tce_ddw_info {
> +	uint64_t pgsizes;
> +	uint32_t max_dynamic_windows_supported;
> +	uint32_t levels;
> +};

and here.

> +struct vfio_iommu_spapr_tce_info {
> +	uint32_t argsz;
> +	uint32_t flags;
> +	uint32_t dma32_window_start;
> +	uint32_t dma32_window_size;
> +	struct vfio_iommu_spapr_tce_ddw_info ddw;
> +};
>  #else
>  #define RTE_VFIO_SPAPR VFIO_SPAPR_TCE_v2_IOMMU
>  #endif
>