DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com,
	somnath.kotur@broadcom.com, andrew.rybchenko@oktetlabs.ru,
	rahul.lakkireddy@chelsio.com, jerinj@marvell.com,
	humin29@huawei.com, haiyue.wang@intel.com,
	ndabilpuram@marvell.com, sthemmin@microsoft.com,
	sachin.saxena@nxp.com, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v4] ethdev: deprecate header fields and metadata flow actions
Date: Fri, 26 Nov 2021 18:07:54 +0100	[thread overview]
Message-ID: <4681850.ngjkj8ognW@thomas> (raw)
In-Reply-To: <YaD0rPqqcsUvVTwB@platinum>

26/11/2021 15:52, Olivier Matz:
> On Fri, Nov 26, 2021 at 02:06:23PM +0100, Thomas Monjalon wrote:
> > 26/11/2021 13:53, Ferruh Yigit:
> > > On 11/26/2021 9:51 AM, Viacheslav Ovsiienko wrote:
> > > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was
> > > > introduced by [1]. This action provides an unified way
> > > > to perform various arithmetic and transfer operations over
> > > > packet network header fields and packet metadata.
> > > > 
> > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action")

It should be [1] 73b68f4c54a0 ("ethdev: introduce generic modify flow action")

> > > > On other side there are a bunch of multiple legacy actions,
> > > > that can be superseded by the generic MODIFY_FIELD action:
> > > > 
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL      sfc
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC       bnxt, cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST       bnxt, cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC       cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST       cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC         cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST         cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TTL            mlx5, sfc
> > > > RTE_FLOW_ACTION_TYPE_SET_TTL            mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC        cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST        cxgbe, mlx5
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ        mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ        mlx5
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK        mlx5
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK        mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP      mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP      mlx5
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID    bnxt, cnxk, cxgbe, enic,
> > > >                                          mlx5, octeontx2, sfc
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP    bnxt, cnxk, cxgbe, enic,
> > > >                                          mlx5, octeontx2, sfc
> > > > RTE_FLOW_ACTION_TYPE_SET_TAG            mlx5
> > > > RTE_FLOW_ACTION_TYPE_SET_META           mlx5
> > > > 
> > > > This note deprecates the following RTE Flow actions,
> > > > as not supported by any of PMDs:
> > > > 
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT
> > > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN
> > > > 
> > > > The following actions are supposed to be deprecated in 22.07
> > > > and replaced by generic field modify action:
> > > > 
> > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_TP_DST
> > > > RTE_FLOW_ACTION_TYPE_DEC_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_TTL
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
> > > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ
> > > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK
> > > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP
> > > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP
> > > > RTE_FLOW_ACTION_TYPE_SET_TAG
> > > > RTE_FLOW_ACTION_TYPE_SET_META
> > > > 
> > > > The VLAN set actions are interrelated to VLAN header insertion/removal
> > > > and supported by multiple PMDs and widely used by applications and
> > > > not supposed to be deprecated due to potential large impact on
> > > > drivers and applications.
> > > > 
> > > > Signed-off-by: Viacheslav Ovsiienko<viacheslavo@nvidia.com>
> > > 
> > > Thanks for the update,
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > 
> > > 
> > > We need to follow with relevant PMD maintainers to switch to new
> > > 'MODIFY_FIELD' action till end of v22.07 release.
> > 
> > Yes I would like to see them replying here, but seems some are not watching.
> > I don't want to block this interesting deprecation plan,
> > so I will merge if few more maintainers involved in ethdev give their ack.
> > 
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.



      reply	other threads:[~2021-11-26 17:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23  7:59 [PATCH] " Viacheslav Ovsiienko
2021-11-24  8:06 ` [PATCH v2] " Viacheslav Ovsiienko
2021-11-24 14:56   ` Thomas Monjalon
2021-11-24 15:37 ` [PATCH v3] " Viacheslav Ovsiienko
2021-11-24 15:59   ` Thomas Monjalon
2021-11-24 16:21   ` Ori Kam
2021-11-24 16:37     ` Slava Ovsiienko
2021-11-24 17:32       ` Thomas Monjalon
2021-11-24 18:09         ` Ori Kam
2021-11-25 11:53   ` Ferruh Yigit
2021-11-25 12:03     ` Somnath Kotur
2021-11-25 13:06     ` Thomas Monjalon
2021-11-25 14:13       ` Slava Ovsiienko
2021-11-25 14:40         ` Ferruh Yigit
2021-11-25 14:52           ` Slava Ovsiienko
2021-11-25 14:15       ` Ferruh Yigit
2021-11-25 13:56     ` Slava Ovsiienko
2021-11-25 15:14       ` Ferruh Yigit
2021-11-25 15:53         ` Thomas Monjalon
2021-11-25 12:18   ` Ferruh Yigit
2021-11-25 12:29     ` Ori Kam
2021-11-25 12:46       ` Ferruh Yigit
2021-11-25 13:56         ` Ori Kam
2021-11-25 14:28           ` Ferruh Yigit
2021-11-25 12:31   ` Ferruh Yigit
2021-11-25 12:50     ` Thomas Monjalon
2021-11-26  9:51 ` [PATCH v4] " Viacheslav Ovsiienko
2021-11-26 12:53   ` Ferruh Yigit
2021-11-26 13:06     ` Thomas Monjalon
2021-11-26 14:52       ` Olivier Matz
2021-11-26 17:07         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4681850.ngjkj8ognW@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=humin29@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=olivier.matz@6wind.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=sachin.saxena@nxp.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sthemmin@microsoft.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).