From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9B55C1B1E9 for ; Mon, 10 Dec 2018 17:21:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2018 08:21:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,339,1539673200"; d="scan'208";a="99555653" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.93]) ([10.237.220.93]) by orsmga006.jf.intel.com with ESMTP; 10 Dec 2018 08:21:33 -0800 To: David Harton , dev@dpdk.org References: <20181207222420.9508-1-dharton@cisco.com> <20181209201120.36072-1-dharton@cisco.com> From: "Burakov, Anatoly" Message-ID: <4681b8be-1b94-a12a-2f25-79471bc1c338@intel.com> Date: Mon, 10 Dec 2018 16:21:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20181209201120.36072-1-dharton@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: fix rte_zalloc_socket to zero memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 16:21:36 -0000 On 09-Dec-18 8:11 PM, David Harton wrote: > The zalloc and calloc functions do not actually zero the memory. > Added memset to rte_zmalloc_socket() so allocated memory is cleared. > > Signed-off-by: David Harton > --- > > v2 Indented if clause > > lib/librte_eal/common/rte_malloc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c > index 0da5ad5e8..40a5384ff 100644 > --- a/lib/librte_eal/common/rte_malloc.c > +++ b/lib/librte_eal/common/rte_malloc.c > @@ -74,7 +74,10 @@ rte_malloc(const char *type, size_t size, unsigned align) > void * > rte_zmalloc_socket(const char *type, size_t size, unsigned align, int socket) > { > - return rte_malloc_socket(type, size, align, socket); > + void *new_ptr = rte_malloc_socket(type, size, align, socket); > + if (new_ptr) > + memset(new_ptr, 0, size); > + return new_ptr; > } > > /* > NAK, see comments to v1. TL;DR this is not needed, rte_free does memset(0). If there are circumstances where some memory is not erased, this is a bug and should be fixed at the source. -- Thanks, Anatoly