From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C08C81B109 for ; Thu, 18 Oct 2018 16:21:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5588122A3D; Thu, 18 Oct 2018 10:21:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Oct 2018 10:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=yvDIWECuFdNBSr+ajQYg7zZMEm24q+IMHBV2KiOcMsE=; b=Jp37Bb8Q+JLB JfWkO3F5lmS5VNuRFBv34CKU+92+EDweIf8CwQtpgWUrdnYTZHkJ2RixGq4j/uKx /XlpmJmBk8lwZyBW3xnH2pJ/oQfe0tfrlleL8mcLAnhNaaqAm6+kG28hrhgNYzBq hg3tBM7Uq2cBl8algMPA3fAIG+EQUrk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=yvDIWECuFdNBSr+ajQYg7zZMEm24q+IMHBV2KiOcM sE=; b=i61u8BhS9vPGwYHX8rtZwrQt9erNZpmmFbgyfqKEJNIVwkNbXJ8ZI3aZi yphR2UXaWy+Q0L9zDV7MeLceqlDSGIcLQAU13fhsPKoh80Rc9icwh++tvFqKLwBd 2OQPtcxA6ts0u9SJbui752ZWYtszPAsRmCZBb1QiTTE0pAsghcoGZxcai25HmoSV 0bG1jVh47A2pamATFxcKF/eLsJvk8Hw74HA8taDUVXSqiQaO2BaNqAdHGvFexvww ck6+BSINKDOn37dpp/y76Gnik4k864CRzEqHetjHB89AOAZjL9+KFPNv6Z3Pvwhn H2DWVDkWXD4YSWqkWdYNK7Smdh6DQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A64B6102DD; Thu, 18 Oct 2018 10:21:24 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "ophirmu@mellanox.com" , "rahul.lakkireddy@chelsio.com" , Wisam Jaddo Date: Thu, 18 Oct 2018 16:21:28 +0200 Message-ID: <4688337.PUasVPICMu@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D12D5C@IRSMSX107.ger.corp.intel.com> References: <20180907233929.21950-1-thomas@monjalon.net> <4896325.UA0OBGhyO2@xps> <8CEF83825BEC744B83065625E567D7C260D12D5C@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/6] app/testpmd: fix ports list after removing several at once X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 14:21:27 -0000 18/10/2018 13:41, Iremonger, Bernard: > Hi Thomas > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 18/10/2018 12:40, Iremonger, Bernard: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > From: Wisam Jaddo > > > > > > > > When detaching a port, the full rte_device is removed. > > > > If the rte_device was hosting several ports, the testpmd list of > > > > ports must be updated for multiple removals. > > > > > > ./devtools/check-git-log.sh -1 > > > Missing 'Fixes' tag: > > > app/testpmd: fix ports list after removing several at once > > > > I think it is OK. > > It is fixing a case which was not tested before. > > And we don't really need to backport it. > > If "fix" is removed from the commit message then the fixes line will not be needed. > However if it is a real fix, then I think fixes line should be added . I know, I am the one implementing this check :-) If I add a Fixes: line, it will warn about a lack of Cc:stable. But we don't need to backport this. That's why I think we can ignore this warning. Reminder: it is just warning, not a mandatory requirement.