From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 124EB1B7DC for ; Tue, 10 Apr 2018 18:18:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 09:18:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="219298548" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2018 09:18:08 -0700 To: Olivier Matz , dev@dpdk.org References: <20180403130439.11151-1-olivier.matz@6wind.com> <20180403130439.11151-2-olivier.matz@6wind.com> From: "Burakov, Anatoly" Message-ID: <46888c05-e24b-1555-5278-b14591a10d8f@intel.com> Date: Tue, 10 Apr 2018 17:18:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180403130439.11151-2-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] eal: use sizeof to avoid a double use of a define X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 16:18:11 -0000 On 03-Apr-18 2:04 PM, Olivier Matz wrote: > Only a cosmetic change: the *_LEN defines are already used > when defining the buffer. Using sizeof() ensures that the length > stays consistent, even if the definition is modified. > > Signed-off-by: Olivier Matz > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly