From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9385FA0C4E; Tue, 2 Nov 2021 12:23:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E63D40689; Tue, 2 Nov 2021 12:23:20 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 554764003F for ; Tue, 2 Nov 2021 12:23:18 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="317436330" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="317436330" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 04:22:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="728612154" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 02 Nov 2021 04:22:09 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 04:22:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 04:22:09 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 04:22:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VG2aZpKHwXjXiY2Bt6hLgNyR8CeDvXLQmFOcT1iflvifUy0Vo8RUw6KmXx4QssTsF/yccyCyXyq4ltI7wPqi+mz3VtOUaLihU3zScxuIokPGoj+yoBvMye2BZcIDx1ZD/y3ayQm4Yr45bpOjI6rvBPYT1kpfs2jLce3up6f+eahJhdFJFxvVTuf3h0xIgEFHea5RZBvhUZTYv5387Pyo6Y139apcNiYEMTYr0eioceGAdJSJ8WCvc3polP7/jMov/grI8q7mHoFuJhtpyDKAB/2Q+IB6YY3cxpq7n8fqTUrzisigPvrTtOV6FdnEshd5Rrv8gark2eM72rFuABSL7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FI2AaGl/6XzGGN91wq2o9M8/XrpIUiGKxjtRBO6+Ep8=; b=XVIActCvwhHQ2QQucvUwLilTGF4obIV7fp7MZbM26d1DZNevwvuO9OC0fqM++NUlcZyfvwfcWblLkPOzaSol9F8U9cP63KnrkCcWgT+hOpdd8lvc+bs9VGlVhuKYslGHlSDewAR8VWeDpfgS4P/MFjqK8x4GYPt7XOZrsSskGS1ImX1uBSxh/OOXOsmXPvIirtgrmrii9hWqyqJer7fISEikHi1JaoNfK76y28TTdU4+6YOY5Q5J6FBdTe51dVKiLFnAS9l5ZielW5j4vW//qZwIjK1Z31wYn1i/GsZz5sBt7joWnb/kzXsd0o2K4j9u7ZjnHOVSdIQxubnpFKJBow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FI2AaGl/6XzGGN91wq2o9M8/XrpIUiGKxjtRBO6+Ep8=; b=eZl7GzluF1FoSheq/K1/6M4nDNF3R9sdkEcRjODCBErC0XS6IBI5k46S0KOei36PzCmQrrDhA6q7KhDWcljbnZsh0jn4jGvDXv6aVgQAcc2XSEWEXyRkj0+Unpsa/oTSZk/A48QOxhsMXDtHVN3hqSThq01JcX9KNHjdeIMczyE= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5887.namprd11.prod.outlook.com (2603:10b6:510:136::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 11:22:06 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 11:22:06 +0000 Message-ID: <46897f55-b550-fee2-c466-79420c37a9fa@intel.com> Date: Tue, 2 Nov 2021 11:21:59 +0000 Content-Language: en-US To: Jerin Jacob CC: Tomasz Duszynski , dpdk-dev , "Jerin Jacob" , Harman Kalra , "Nithin Dabilpuram" , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jakub Palider References: <20211005074620.2224968-1-tduszynski@marvell.com> <20211022115625.1956708-1-tduszynski@marvell.com> <4832f0a8-67a4-ec48-30b6-01aa7d80ab1a@intel.com> <69b20079-c079-1d7b-a850-70de757c1343@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0230.eurprd04.prod.outlook.com (2603:10a6:10:2b1::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0230.eurprd04.prod.outlook.com (2603:10a6:10:2b1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Tue, 2 Nov 2021 11:22:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f17b3bfa-5a9d-4c0c-98a8-08d99df3009b X-MS-TrafficTypeDiagnostic: PH7PR11MB5887: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7fnLM/pRmnw5eqak8Ro1O2WtkRhvv+4lCBBYDm1JNXw/6ad5u9GLXesbdVSasvLeO4FXFLGESasdkdgBcc/KNpfQihUQWCynHigI2sjKbZivJ4qFNghIFLecUXgmIGPHwJLIfygl13ZeFCu4TfaqOP5zmPZyuhPAD78sMuemFbeo2teG2iLL2cPgriMom5v4GR7yNTqMp+68LubEhz+7q8tlHVD3bQC6GJFbX8KFnS6FWEsTCZuyNHRnh2z5oscxtxHdSUkIm6hS8pwAphyMCVslQQQ2FmCZqzhm+jAhosWd0TPYl6lvduO61eC7I3bbIGfpgut6JR+R9QtuIf8bM1geDB0r6b3ZUiViksovGVOGO9mWMh07euCZnvr9Edpx+EgEjuqnsHlDg2d8R02/7BEh7qvB+pxu1VRv57NwSciy1pzKRWAncgO+WgioPG1835CWkNzwXr0s3tBTkZ9EP2ALTVpvsAsXj6OBfocjNEvshxtYG9nDSmGD2BvSQUcx5vHBRhmPPSJb3+ltdMYfXNAnuljw5x7rICJCR/oAJSSvQisJDyNcQPg2wMo9JN+K3eZKSpGc65L1fxMX2MfFVH6hY8CBWqAc/LeU3D4jaDW22/Rlh8DnJ89VsRffm1x6Fj1WG8A0IQFcN4/pA+BZZmIOBDLfF8jwdUX9XjkWBNdgkffELwESMKckjYag3a/DhNK97luEAkDrSCLUcsFEnA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(44832011)(31686004)(8676002)(5660300002)(38100700002)(83380400001)(6486002)(956004)(4326008)(2616005)(508600001)(8936002)(16576012)(66476007)(7416002)(66946007)(31696002)(26005)(86362001)(316002)(36756003)(2906002)(186003)(66556008)(6916009)(54906003)(53546011)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGYzS1NVNE5pZVg1S2NrNU5GbTZqeXNGaUNhSFpjOVUvVk1nMlBhaHVTL2dr?= =?utf-8?B?QVpwTmpwWk5pQW5ocWZvUkMrWDEvKzlZRnB2TWNGeUN5OTZ6UythSFEyZDhj?= =?utf-8?B?Zlk4R2p0NlBNUmZjYmEvMEQ5ajhKenVZOU5xN25ITENTQ0loNmc4TnZXZG1V?= =?utf-8?B?YjQ5Sm9VL0RtWEsrVXF3MHBaZXN3SDlsYUVqUjNQRGl4cGZrL3pCaTZ6SmV1?= =?utf-8?B?MW9rOGoyMWwzWE13QzJOcXpYMHNsenNtZUhON2VUdFNjQ0xZN2ZmVzdjL1dn?= =?utf-8?B?cEFYcDFYNmJraERML1B2RjhSVXFNY0liNDRJV2lMcFROVUdIS0NxemJ5Q0l1?= =?utf-8?B?MW8yQjAva2MxRVo2Rit4L0tZQU9xeUllcjN3Wk8raUpsdU5PUFYvRGRMMkNY?= =?utf-8?B?dm9EOFpSZkJ5TzVQUEdIMHBjeFZFZlBlWUJveHdQTGxUQ3RMY1VpNFpDU21I?= =?utf-8?B?ajNxY0d1cVJuMU1iL0lXSkpKbmtpUXpic2NKbGw0Z2tkT1hmWkc1Q0w5TGFG?= =?utf-8?B?d0RWYitMaGh0K0FtVGlHeEMrYjdTL3c4dklwNzhsWmdCNFpZUUdmczV6bG82?= =?utf-8?B?NHVJUmN6VDlSR1NidU1LZGVucktPeVVmcEcrVFNaUitJa2Z0ckFqL1ZhN1Rn?= =?utf-8?B?WVFWaHNmckFJWjM0VGVTZzlwdkpxc2wyT3plUmFiY3hESjRDLzFhcnBsMUk0?= =?utf-8?B?a1h2NHlEU1g1T0ZsaVlZNFZpbmxEQUJRczh1UnN3eURFRmFIdHNEcy9RTXVr?= =?utf-8?B?di9CdnpYRU5OSUhITDg1cm03Tzdud09hbERvNG9LdmUyRmhsYWpNam9jb1hQ?= =?utf-8?B?bVlURWlmRkNuZVo2ZEhaempNYVR1L29OZWh6Z2x4Z3RPRTBYRk5LeFp4TXhU?= =?utf-8?B?dVQvQkJaclVvcG5Yb0Rpa2svMXNhaWR4eUVNdEQyRXV6OTVFUFJJcDE4NXJC?= =?utf-8?B?OVd0d1JDSzZVaGo5MXd6by8yeVExUWlSdXNSUjVpSW0wZE5xL1JTT2FiL1B4?= =?utf-8?B?VDlOSU0wZklaOW9oQXJhU1UwTjZTQ0hFcDBkT2hyN2NHSzd5Z3FLaE4vbUJr?= =?utf-8?B?ZzJ6K2Qxd0JZSDZNUDlhYmtUUlFreDN0eUtsYWVzZkIvcUwybmNvQWk2KzVs?= =?utf-8?B?enliVTJ6NW5CKzIxQStQU1plTVVZaS94a29nNnBlY3FZV3h3MEV6ZnZoME4r?= =?utf-8?B?Q1h6STVSWXJINE10ZklFcWF3dmlCWm4wbjJDaFR4UGpYemF6NnlIdkQwWlhp?= =?utf-8?B?SHVsdUVabm1FUTM4M2UzdmJacjEwR0p3K3JLWVFaNkNWTC9VbmtFMHZkeDd0?= =?utf-8?B?cHdaeDlhT2dSd0ZaSmVTOWRzVVN0TUNYWklZejhlUWxFRFFVdFNLTXdVdFF1?= =?utf-8?B?SXBocnU1VDJ5dWVXa2RFZWFtWEQyRFQ2dzBqUUI5VTZEZjVSK1p5S3ZPcWZl?= =?utf-8?B?WmFid3FlMEZoWnFsSHdFRDdvRzI2L2FnTzUycWFDeHY5RW5kb0lzdzBUN2xD?= =?utf-8?B?RlUwRURCK0l5YW0yaStvdWlUZ3pteXJhUE9xZ2RSMmlXbDlab09FOEtvSTVT?= =?utf-8?B?THpEb0JuZVhRZ1FLdlR4N2pHRFNGcmRiNmZCMTgxWi9yYmF0NmRuVUNJbDBY?= =?utf-8?B?T3NJYUEyTEtsdktCNUpLRm55c0pRZHJhSnBHL2hYNTZmWWVzdXUwdEdmZmNV?= =?utf-8?B?N2RZNFZ1VnhCQnVSRjNSM1ZXeDhuYk9xbzVmbEJwSEdBQ0JiLzcyNGpmMGRR?= =?utf-8?B?SmE2RzV6Z25IekMzSWxzcHZSS1hyRDBJZFk2MldkbzE5ZmZnckxmZ3FRWWw0?= =?utf-8?B?REtCTXRaN0RXejZrcVNrQ2dLN1RRbHJ4N2RVZmVkZDd5LzFTTEFKVWRJRzhu?= =?utf-8?B?N2N5VEFRMGRxV3B6dlN5bW1mMTd1Tll0eGgvOGF4VXNFdW5YWEhOVEtKb0ZZ?= =?utf-8?B?NzIvMTdYZWJLUkYvQ0pRaTdhb3JPKyt5Vm5DbmtiOXJNbUFzZitaQ2sxaElx?= =?utf-8?B?L1VZaVZBN0svNlhkYmRld3hWMDRrdlUzV1c0NW0rTVFjMXZFN2I4SXUvQ3Fp?= =?utf-8?B?Qzc4SENHdG5zcmY0RHZydE9PSVhwbG0vYWZtZ0YySlNGWGtXYkY3Mk9NTHg1?= =?utf-8?B?N3Y0akNZcEprWnpKMHEwOVpaUS9TdW1GeldodHJXVUVMY2M0S3hjUDhjS0dk?= =?utf-8?Q?7RWDC8zvDU05/vA2/q+PxFo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f17b3bfa-5a9d-4c0c-98a8-08d99df3009b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 11:22:06.5563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hDk7eMt6Ye/T+COR7QA6mo48wTFMmQtpJAIO5sANheqDVBL9LxRileR30qwJzJ8Ee/az/XJPwiu2BzuNOWVH/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 11:11 AM, Jerin Jacob wrote: > On Tue, Nov 2, 2021 at 3:58 PM Ferruh Yigit wrote: >> >> On 11/2/2021 4:32 AM, Jerin Jacob wrote: >>> On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: >>>> >>>> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: >>>>> Add initial support for baseband telemetry. >>>>> >>>>> Signed-off-by: Tomasz Duszynski >>>>> --- >>>>> v2: >>>>> - make bphy telemetry available only on platforms supporting baseband >>>>> - use platform types where possible >>>>> - remove unused header >>>>> >>>>> drivers/common/cnxk/cnxk_telemetry_bphy.c | 52 +++++++++++++++++++++++ >>>> >>>> Since the telemetry support is for 'raw/cnxk_bphy', why it is implemented >>>> in common code, instead of driver? >>> >>> It can be raw/cnxk_bphy, thought of keeping it in common due to >>> 1) To reuse it for another common code consumer >> >> Is it reusable, since the code is to get telemetry data from raw device? > > Yes. I meant, common code is reused on another library that has > telemetry support too. > >> >>> 2) roc_bphy_sso_pf_func_get() and roc_bphy_npa_pf_func_get() manged by >>> common code. aka there is no reverse dependency on the raw driver framework >>> in common code. >> >> If telemetry code moved to raw driver, dependency will be from driver to >> common code, which is correct dependency order I think. >> >> It just looks wrong to have rawdev related telemetry function in the common >> code, but I may be missing details, trying to understand. > > Currently, we are doing like this: > - implementing HW specific telemetry endpoints in driver/common/cnxk > - ethdev/mempool/eventdev/cryptodev driver-specific telemetry endpoint > in driver/.../cnxk. > The criteria for deciding what is the second category is, if it uses > any ethdev/mempool/eventdev/cryptodev/rawdev > symbols or if telemetry-related raw dev driver implementation details. > i.e common code does not have > any raw driver dependency. > Got it, so I am proceeding as it is.