From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF264A04DB; Thu, 15 Oct 2020 12:45:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF8A41DEE0; Thu, 15 Oct 2020 12:45:27 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 815211DEE3 for ; Thu, 15 Oct 2020 12:45:26 +0200 (CEST) IronPort-SDR: 2RqrdUwnPzmUwNezOcf3EjXONXInwGSkoLYnbzSJBOAmsnLJHQDWNBZI6U4XgAbt6zpoIIzyDr cKndoFFK92TA== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="183859196" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="183859196" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:45:24 -0700 IronPort-SDR: GxSLgCn4hmqscEkCtCG0J8GXsJv+FgxX6IjBPOEbKn9uwPa0BqzpVexGZOKSLeA1w7uNC3Yvsd N0wY2Q8EzzZA== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="521795398" Received: from orozen-mobl.ger.corp.intel.com (HELO [10.213.243.220]) ([10.213.243.220]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 03:45:22 -0700 From: "Burakov, Anatoly" To: "Ananyev, Konstantin" , "dev@dpdk.org" Cc: "Ma, Liang J" , Jan Viktorin , Ruifeng Wang , David Christensen , "Richardson, Bruce" , "Hunt, David" , "jerinjacobk@gmail.com" , "thomas@monjalon.net" , "McDaniel, Timothy" , "Eads, Gage" , "Macnamara, Chris" References: <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com> <493732d1-379e-51f8-1740-8df784ab96c7@intel.com> Message-ID: <46962f43-0013-0018-60e7-bf89cccc851b@intel.com> Date: Thu, 15 Oct 2020 11:45:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <493732d1-379e-51f8-1740-8df784ab96c7@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 02/10] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >>> +static inline void rte_power_monitor(const volatile void *p, >>> +const uint64_t expected_value, const uint64_t value_mask, >>> +const uint64_t tsc_timestamp, const uint8_t data_sz) >>> +{ >>> +RTE_SET_USED(p); >>> +RTE_SET_USED(expected_value); >>> +RTE_SET_USED(value_mask); >>> +RTE_SET_USED(tsc_timestamp); >>> +RTE_SET_USED(data_sz); >>> +} >> >> You can probably put NOP implementations of these rte_powe_* functions >> into generic/rte_power_intrinsics.h. >> So, wouldn't need to duplicate them for every non-supported arch. >> Same as it was done for rte_wait_until_equal_*(). >> > > Will look into it. > To be completely honest, i don't like that approach. The ifdefery in generic headers looks ugly and out of place, i'd rather leave everything in arch specific header files and provide stubs there. -- Thanks, Anatoly