From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 930588E92 for ; Wed, 4 Nov 2015 02:20:48 +0100 (CET) Received: by wmll128 with SMTP id l128so101861700wml.0 for ; Tue, 03 Nov 2015 17:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=FGYrT41nd/DB397YN/I28EIyynyVIqCmxbHlpOK1yl8=; b=FLfkTb+DUXhAgC9evMpFDuz3as+KIMcsEqJKMRafXOQ9a25pdFvrieuAm+5q3SbXj4 rxmt+WlAXbC2YEdRpyFQKoHEmw+9psbzC5p/GG0kpoHGByy18V0rOOrgUbedA31sqNmU rYFFp0G1UsAVt+absZ93vPQwf+rWUH2QPITakp2oIV9w8NiBKLNu5sR2UIpwlt9iIgQj bBFNpKX1JYWWKshuHZ07N5NrOqc7qy25GbawwtPXeRoONUy1dmJZiMsmbtM/a+YpcTAE Hb2rUeB9bG7ix5eo4AIoOrlNdh+pAd4V+W7KOqaMZDqhrkOm99SljFx7RDBG+fzaRNmG 0V0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=FGYrT41nd/DB397YN/I28EIyynyVIqCmxbHlpOK1yl8=; b=DFaC2gW2F3oetucy4yMhGgnLYcosAVxbJDWCiz9Mz3om3ojbB8k9N4Y2PDhNFPrqfg nhZZtqWYpaxCRmX61tNFeku8rLAk9JIoj5StiBvOZZXbgothJ73B//PYzk8ENrubcSdJ OTjt/EoEyMivur/7O4ZoWs0lox2bR7iq+O1TGnDYA8+wCuKr+rLKo70Dr97/FRBpDfcC T7nGCVOs8kwswKPQ2uMs7bAeSZR4Upn4mTEOjBkM/YXpWPpwX5OZQS5qLNf6nEFa7Qly w5/OiZ5zZx4BWVnyqdJIlpZFfEjeJPIJ0X6rP9CDEvQ4z9MbD//0w6hF2H6NrgPUzPI5 +j/g== X-Gm-Message-State: ALoCoQnFje4SylYYDAjtmJTJkMBVxe9G6Sb4BguQ3mrxZ+po/rR+8N94jFh1N3QlJJxTXNFr7oQs X-Received: by 10.28.132.13 with SMTP id g13mr21781650wmd.35.1446600048465; Tue, 03 Nov 2015 17:20:48 -0800 (PST) Received: from xps13.localnet ([93.158.41.25]) by smtp.gmail.com with ESMTPSA id r5sm18500153wjf.18.2015.11.03.17.20.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Nov 2015 17:20:47 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 04 Nov 2015 02:19:36 +0100 Message-ID: <4698587.GS9blBozDC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446552059-5446-3-git-send-email-bruce.richardson@intel.com> References: <1441811374-28984-1-git-send-email-bruce.richardson@intel.com> <1446552059-5446-1-git-send-email-bruce.richardson@intel.com> <1446552059-5446-3-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macros to header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 01:20:48 -0000 2015-11-03 12:00, Bruce Richardson: > Move the function ptr and port id checking macros to the header file, so > that they can be used in the static inline functions there. In doxygen > comments, mark them as for internal use only. [...] > +/** > + * @internal > + * Macro to print a message if in debugging mode > + */ > +#ifdef RTE_LIBRTE_ETHDEV_DEBUG > +#define RTE_PMD_DEBUG_TRACE(fmt, args...) \ > + RTE_LOG(ERR, PMD, "%s: " fmt, __func__, ## args) > +#else > +#define RTE_PMD_DEBUG_TRACE(fmt, args...) > +#endif It does not compile because Mellanox drivers are pedantic: In file included from /home/thomas/projects/dpdk/dpdk/drivers/net/mlx4/mlx4.c:78:0: /home/thomas/projects/dpdk/dpdk/x86_64-native-linuxapp-gcc-shared-next/include/rte_ethdev.h: At top level: /home/thomas/projects/dpdk/dpdk/x86_64-native-linuxapp-gcc-shared-next/include/rte_ethdev.h:933:38: error: ISO C does not permit named variadic macros [-Werror=variadic-macros] #define RTE_PMD_DEBUG_TRACE(fmt, args...) \