From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD63E41C35; Wed, 8 Feb 2023 02:16:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D0140E6E; Wed, 8 Feb 2023 02:16:59 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2086.outbound.protection.outlook.com [40.107.220.86]) by mails.dpdk.org (Postfix) with ESMTP id C084240DDB for ; Wed, 8 Feb 2023 02:16:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+m0HBqYo+bU5ggs22Go+B3IQRGOCqPnsFCdHb8PPLOV++5WTfcHzHLiciDdu9LYZgq81TvQrSOjw9zJpUJs/x5xDiKw7dbv98cf2tOywxXXjEHrE3AN4Cz0aJu+Quln63I6CYs9Tk5/B4YM9b0iOj5nRS1+QIh3sCI3O9IL2YbYEUqvxnYl/jmv83Qk+lv34NGejHB4vw+KiZHz/qNDvKnio30POmCIX9mZXBJDgBhwZQINw1HrkN2VgeULsxgM2IuEUIyaAbZoruZ3nWu08zizazzRcZfvO4c7yphJYBFi3l8739Yt83HtyGjERb3Ys9gqTPou8hpkxiww3kmPRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cwu+SSmbqc6L6Nb/iOlZLyI1wykk1sl5XW2H35ohbp8=; b=McxeVHy9t4qeywzOOVEW1OeYv5OKw9+Ko1NAuQ6Y9O1bYrx8SzJ4wZ2o/BRYarPZ45mbl7mJJSKMBstsi+Irt+PpXwhS5LIMJZFAAuMf2nIr+H7HR91Eiw5iwKKm7nYe+xHZRI60oP6orBFlmQ57ExW4M3yySACKCSnfzhd6A3ws4/sGE9fclLAFnh3eWbnf08ANR0BjRibXXditsCS7L3iUbmDF+7KfrZ0Y5CfthepOF1kGdS1BGab9Dlyv94n6mEuQzRv+5PfYNroahSSu2KzO/sJseNvaV0YS3zwP4Ta+5pgS9UBANmjxMEIlBR/5/CwgO0iE8eNLJW9m13btxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cwu+SSmbqc6L6Nb/iOlZLyI1wykk1sl5XW2H35ohbp8=; b=0+eE7L+ejFM9z88zrnWFFMaLM+L4vRjXTHCzrPnQNDU3LmNx+/DpFZ+EbR9/eryQxhhrtOyK06KLZ0CBfwnz1K9H92NMdzyASKlxTDthuqCbtGqgty4lygPx8I5Xf9Tfb9ESFloVifFjAiF8c5YgqKCOeeVSLDGtlihFaqRF+e8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6788.namprd12.prod.outlook.com (2603:10b6:510:1ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 01:16:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6064.034; Wed, 8 Feb 2023 01:16:51 +0000 Message-ID: <46c958b0-a0d1-039b-d399-76188bf2a2c5@amd.com> Date: Wed, 8 Feb 2023 01:16:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, mdr@ashroe.eu, orika@nvidia.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com, mb@smartsharesystems.com References: <20230206115810.308574-1-adwivedi@marvell.com> <20230207063254.401538-1-adwivedi@marvell.com> <20230207063254.401538-3-adwivedi@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v9 2/6] ethdev: add trace points for ethdev (part one) In-Reply-To: <20230207063254.401538-3-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6788:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e5d4707-8627-48c3-2595-08db09722869 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CbfvlNWzDJmfjtYnQA0M62WyfQWKZzVFruaGzuQbpB7jVWdZgyVTbp9A4K+ZXCUMzgrNusOoM/3eREY3PEVN7AJjVqQo/t+FrG0w3dk3ZDfcychrxp8MaVSivF4TagJNSP82FqG1AQO1KO0RieNsA39Qh4r958EavRFAhPI4+eWWH1sTHPMmAcG34R2DWDi0lRn7vpAuM2gkM2jI7yrMlXIIXfJN6Dq2EHbXKLGZTERJjMjmU4WEy1AZRHazZfCJ+ErG9T/xR8T0Q3n56dzHsFmaYkpm7On1PumP5jC7kd8P8/G0UikvpCV91NTuR9HfnR1faH6O8wn+udB6ECXPeyfMPOKSCRgewzDTiW/8pC4iYdibRBREaCDmcteNMDBmJ8lU+Ca0qrST34/mcWEEyqivz/RHxw2uyv3q1ipaFPBOAT+GZdnKg4wjn242yHB9a2I9WJMr24daY4zHy2Kdxtc1QceAE3sG3Dsl5HT/UWuVktrG4x0GY23aDsTmH3nMZyAKwooHSevjV07kGzQ4AcaxDJqx4r+gbBCZwenaVemgjcN2DMm5xwKjUlq0AWh5ARCQnngB0gGyA9OcYjeBAM1l2TJmfQ2WmKHDffRRyQAv8DF6Us78wdBbdZhewffC+dVKS4s91xvpYLevR69mklHr1i7CZ94z2ON1PqFTO1GPxIFIiEJ6Q3A0NMaJ1e7CfNX2Bdh2fYArYE2oUPH3+juMqZVJgTmqDuLItdDA4z4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(451199018)(31686004)(8676002)(53546011)(26005)(6506007)(36756003)(6512007)(186003)(6666004)(6486002)(86362001)(66556008)(31696002)(4326008)(66946007)(66476007)(478600001)(316002)(38100700002)(7416002)(7406005)(7366002)(7336002)(44832011)(2616005)(5660300002)(2906002)(41300700001)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzlpUDhRUlRuSnMvN2p2YWNjaklxaFFrNm04cU41R2VHckpYM1lpQjdKVEhm?= =?utf-8?B?QytCTURudVZUWHBWY0REVHZMcDJJbDJBeHJZRHBJRHpKcVJIbTlXL2FCYmFU?= =?utf-8?B?b3NnZ1hZaklmRVpCbjlINFZZNGZkZVl5NUhyR01xUkxvdDBhQTIvMEp4TGY5?= =?utf-8?B?VkthVEs0eGl1TTRCeVVOQjhYbS9TMHhMSDFxaEttRFpqdnN2NkNiaktSM0Jp?= =?utf-8?B?T2EwK01SZlVURGhYNXNQKzREc2ZxLzBzSkZaYUg0VC9oUUpPZ3Fsd3dhcTRD?= =?utf-8?B?OVNlSzdSU1ZNcll3clRSRlZnbG9aRzlVazczUkt4dEZTZ1BKaERZN1dpNGsx?= =?utf-8?B?UmJEaFk5VHVIa2JHTHhLQlFHQThSL3NtejBTN01nYk1SZHhYQ0Y1NjhDelV4?= =?utf-8?B?ZnVKOHdVcWxZUkJWNmJMVFJ5VVdESnJvbFIwU29wakw2L000NVcxK0JjQWRM?= =?utf-8?B?aWgxa0NLZWU1NFE2aFpaOGYwQU9sYUFmMzZ1NG9lMXNoOWlKd0xsRWlxMFdv?= =?utf-8?B?bjMxT3gvVkFjWWxFOW9RUk0rUzlhTWFnSjA2bURMQVFIQXF2cTNCekxFc1c4?= =?utf-8?B?NDdIcXdGZWpLK21qeUF3cmFNdkYvdndUdVMrSVRXRmVwSVNOUC9BR0VvUFMx?= =?utf-8?B?TzV5T01yWEhJcENEQWk2VmRwelQ3dHN0ZzNOU1pWek5QSmJDTmxYRWM2VWts?= =?utf-8?B?M3ZuNDhhd3RtOUJ5UnZibkFiU00vT1R5Y2IrRVBzakRlMGxEZnh3ZWxkWFN6?= =?utf-8?B?dG81cTlJeHh4MDc4d3BNVnVpVWNkYUxnRWtqZ2xXU0gwazFaNzdLRE5FOWdw?= =?utf-8?B?d1RFZ1pYb0l6RHhkMW5UT2d2VmRyWDVUS0tyN2FNRDZ0OFdVUWkzODdVTkdi?= =?utf-8?B?ZUpvVi9UbkxqMzVsdWIxajZTZURrak5rR0paazJlaGVOL2YxU2JUVjNFTnlF?= =?utf-8?B?cHlTWCtzRVgyQUpOcjhNZlIrZjNJV04vbVpIU2pnSGRWWHZ5d3dld1dLWEY3?= =?utf-8?B?bFVQcXozRWMxUWdYcDk2NmdtdWtSaWxuV05ibGhEWjZsVG1wTm4vWG9DaEFW?= =?utf-8?B?bUtJZVBuRjNiSXJVTmRLQkhUMFppR3VrZHZRcHN6aDVlNGFaalN3MG1mdlV4?= =?utf-8?B?VjMwNTdHcmZlMHNkblJObjh1UmFLM1JQbEp6bzJkSElNQUltTk0wUmlFNlVu?= =?utf-8?B?ZWRWNGFoTWM2cEkxck1Vd25PQklpbS9oSkNWaDJ0Uk9VTU96QWU2bGJiZzdk?= =?utf-8?B?Yi83SkI4WlpTQUxWSXlKc082MUhJZVMxOWZXcXZkZ1BFNzF6cnJaOUhsQjd4?= =?utf-8?B?WjNnTlZBVHdSUXlwVmRoVjNVN1BKSGM2NFFHTXFVejdZUTdQaE1UbXF6VWNO?= =?utf-8?B?RmJicmtLK081ODltejhhUkhQWEVlQVBQYjF5Zi9VckR2Vm84aHFtVG5lZ1gz?= =?utf-8?B?S2RBa2RwRmpJN0JJTEh6Uk5DR2tBU1U3VEJuR0JFdXQ5ZGhRVEh5Y1h2bE1k?= =?utf-8?B?OEc2UnJ6MjgrejF6TFcvSitFWWlnUU9McUg2NjJKRDdpQTAxK1BrSGdCS2pQ?= =?utf-8?B?S251QUdwNGttUjR5S2pOUG9ya21lMGJ2RzF2cmU4cEQyV2FaaGpPb1U1UmtK?= =?utf-8?B?bk1HREVXcHAyTldDOWYvVi9sZDFSM3A3b1hyeTRlRmNrZk05aENUOU5nQWdD?= =?utf-8?B?YTFSbndlaXpnNXpuU3JOVjNvS1pmeURobHduNUlkOElMS3gzWURhSUVONFNu?= =?utf-8?B?ZzlBY0lTSW5uZ2FjZWdpY2FUb0M3SmFpclBNd2IvL1N5a2NxV0NaL24yL1Q5?= =?utf-8?B?NjZyVDR6QmNWMmdoVnBmU2loUWVzSUxiWlg4eW96ZXYyeFQzV0F4YWNzK1di?= =?utf-8?B?NHBuNkQwL3VOOEZFTG51a2trL1RWNUk2U2xOVE5Lb2owd1Z5ZWFWTXgwRzdY?= =?utf-8?B?VUpvZGhwT0VjNWhxcDBZdWU1dnU1RUFCWkFkS24rY1I1bjlQQ21tb3N1Tm9V?= =?utf-8?B?V3BDYjZhTWxHYjdLWnQwV1kxZG55Q1ZOSGpxZ2hHSVp1dHZrZzcyY0RCN3pR?= =?utf-8?B?cnQ0cTdpT0NmNmREd29qQUp5MGo1QW9xS2FIK2phdjFwWFZVN2F2OCtzZEx3?= =?utf-8?Q?OL++KCWTyRuXqIDPin64s81OW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e5d4707-8627-48c3-2595-08db09722869 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 01:16:51.7894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0G+0QCSN7rwh3Ybduxb3F0V27WGvLwrGGRK/qHLvb4PvnJhQPns+TV8rTq1FiGqH X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6788 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2023 6:32 AM, Ankur Dwivedi wrote: > Adds trace points for ethdev functions. > > The rte_ethdev_trace.h is removed. The file ethdev_trace.h is added as > an internal header. ethdev_trace.h contains internal slow path and > fast path tracepoints. The public fast path tracepoints are present in > rte_ethdev_trace_fp.h header. > > Signed-off-by: Ankur Dwivedi > Acked-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit <...> > +RTE_TRACE_POINT( > + rte_ethdev_trace_owner_set, > + RTE_TRACE_POINT_ARGS(const uint16_t port_id, > + const struct rte_eth_dev_owner *owner, int ret), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u64(owner->id); > + rte_trace_point_emit_string(owner->name); > + rte_trace_point_emit_int(ret); > +) > + > +RTE_TRACE_POINT( > + rte_ethdev_trace_owner_unset, > + RTE_TRACE_POINT_ARGS(const uint16_t port_id, > + const uint64_t owner_id, int ret), > + rte_trace_point_emit_u16(port_id); > + rte_trace_point_emit_u64(owner_id); > + rte_trace_point_emit_int(ret); > +) > + 'const' qualifier is not needed for basic types, can you please fix if there will be a new version.