From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9055045C59; Sun, 3 Nov 2024 01:48:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B066402A5; Sun, 3 Nov 2024 01:48:41 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83]) by mails.dpdk.org (Postfix) with ESMTP id CC3004026B for ; Sun, 3 Nov 2024 01:48:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gMqkmW1HgJjfPSrmbmm4R4zeXKCPVRLM1ptDJA2fNgK0U8/ONGsFIaWtAgRmVKY1PwH9R/1h6v/cTnap0hUilu0RPrYWp1xVpHTNK/mwKeT9+cPCAS/tkerrrdtHk5fX0QCPBb8kNmqduqZfHWXZMebZalEyj9mt4fhup3JnsvnmNDsd6U2Rw3HXDuJF64wrft0maFRtkzueMoDbFgoqVRJ3965CdBa/SrHMhbz0cDzPxRBojhavTPhNU5+m8j2wmr4qUH3A+3/WhpVd+eLxZAvO+xUh3KJaEzAYMYtLIoiqty9uvyfzsuLEmC57qAW8shU5OSAbNle6PXTW4F2FvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2gXLNSHYHZW5GbgUy5Ia24MyQf3vMI8esOlJX0cnTb4=; b=Pfxi0hfZEDnqwL7KEJ2jd+NeKiLLwmMGBvf6hnl/n0NyMZzp+/G6ZU17VPsKIAZUUqhjF2HX1aH5O35Gz9d1FxLaS1ToMEtSc0iFIaeX8MmddSbCICLdJ6p9A1GqcIchd85sEQogpE4EMao5Fpcxh0TduyKzxhT89yVtujbbGiyvxIVZgRla9BDp24BEkhrFcHDjtw3GJYMQd8AFYPaGcLH40Ukxy1jI86KTOpy8Zvtp5s+mY15G8seS4a+AXb51euWqqTaJutF4K5+QPc2Ap6LB4c5j7ByCMEr4Cn+zkXYp5kDCe8d72CggihEhH8E4cpcOOT5wwd/b74qyBtkV8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2gXLNSHYHZW5GbgUy5Ia24MyQf3vMI8esOlJX0cnTb4=; b=E9tz8j3biVeUSLE82JncPv5W+ZyU83dvaCrKFCjZorM1VCz4YJamPknWusW7LyPR+5wsz5Dipk0DDe8vTuBhNpoM5qmApmDRxcyChbB7110T8vtBj2pProT2trUcFT+B4fVbkGwJucsfTBWn+BfTphAOYKU3TlF+5rDeFkFCZIY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV3PR12MB9234.namprd12.prod.outlook.com (2603:10b6:408:1a0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.20; Sun, 3 Nov 2024 00:48:37 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sun, 3 Nov 2024 00:48:37 +0000 Message-ID: <46ce443c-8b70-4e59-8506-625dfab105c7@amd.com> Date: Sun, 3 Nov 2024 00:48:31 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] net/nfp: add support for port identify To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, James Hershaw References: <20241030082759.209617-1-chaoyong.he@corigine.com> <20241101025713.290462-1-chaoyong.he@corigine.com> <20241101025713.290462-5-chaoyong.he@corigine.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241101025713.290462-5-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0655.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::9) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV3PR12MB9234:EE_ X-MS-Office365-Filtering-Correlation-Id: 53b2bbbd-2ff9-491a-38bd-08dcfba1409e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NkxqaXkyMGR1ZTJBREhRT216ZDJQUk91bjhSVTg1NmlTMlUwZXFIV2YvQUps?= =?utf-8?B?SFozMUFzMTdqWjBuTDVLSG5HdUZTS0RCNTZsWkdaQm83SmdpV1NMSUxWRmlH?= =?utf-8?B?Z3BVLzl5cVh0NWJIYzdYKzRDUUNpVlhMdUpMYkRGbXppNmRBUjNpSURJZjlW?= =?utf-8?B?aXBMY3VSdjNyTjQ3dWJwZ0I0YWxWT0pvSmZiNzFJMWZKN1pzV2FUSUxadHR3?= =?utf-8?B?dzkwYllNaEJNa3NPMmVEYmFMV2R1eDcwdElBVE9QdHBuS1U2WmJFd1VLQVc3?= =?utf-8?B?YXdadmhPVHlDM1pKQnpIS1V5TU8vV1BweGhPeVpaTVJrakZTTE1HamNYbFgz?= =?utf-8?B?WWpzejdxeHREUi9jMGJyRTlNOTcxeWVIOEU2Skt0L0NjdlNGZk5wSkFQamJk?= =?utf-8?B?dll5RXoxdHUrYm5EMzhHL2Jsb1JBM3dqQ3Q2NkZBL3pBOXdjS3lLanVaUThm?= =?utf-8?B?UkFwempwcTY2Mm8xNFZYTnF0d2pWWjA3RmpSQUVlUFhadnVQYnZYZW5SNUd0?= =?utf-8?B?Q2RyQjBBdjc0cyttb3BSUDFiMTg5MStDU0lTRjd6UEJuTVJJMXc5VnVTRHN4?= =?utf-8?B?ZGZhdTF6d0RFdUkvVGh5OGxra3o1VzFONGd2VzU0VjNxT1Z4d21JeWx0eEwv?= =?utf-8?B?OXBaREdnYmx4Zkd3d2FZUjArZDlsOS9CWlNHeEhPNXgwbVcrSE9FeVc4QjA1?= =?utf-8?B?TGc2L0tnak12bEJhYXM4RWJ2dW5IVUYvZEsxUDZkWUxKQk9PQVNxRmJ0WXpq?= =?utf-8?B?TjdwQlMwWUxmZmYxRjlZUjBBZ0FoMVJ2NE13dHlGWmNwRmFGc0cwd0JWYVoy?= =?utf-8?B?UG94cjE2eEQxVTl3WUdBeEtxNTMxRUxaWDJITC9NZkZWMjlNZ3d1VVlHOS94?= =?utf-8?B?ZFF3YmxOSmNmdGQ1U2JvR2FtMFpNeEgwbGJXZmNpdjU3ZGNud3BBRklDRUY4?= =?utf-8?B?RzRUNTE3RnRFRFBaNnpzRW95QmRpK1FrNldDS1V6OEsrNXhwekU1T1JyVnhZ?= =?utf-8?B?ZytiQkx4RW40d2l3K2ZiUkdvQkZWVUcxSFZHN3ZtUWJtOEpoL2NqZGMydC9E?= =?utf-8?B?QVZzTFdiR1k4TWx6aGVvbHhoUWUvRlFSWSt1WjRrWi9VUHd4azFpVk45WXFG?= =?utf-8?B?bXhkZ28waWhjQlNxLzZKSVVoWjlVaDA3cXNmUmh2TFFURW1vYzU5VC9maS9K?= =?utf-8?B?SENHbUcrUFR3MkhDNUk4T3FxRmVuQWQzRVpvUXpJK2dYSjVQM1JvS29zU28w?= =?utf-8?B?Q0U0dExFNkptK3FpclhGYUdPL0pRVVI3QVlrT3h5Zy9aaVU1WUF6Vk1sYzVl?= =?utf-8?B?RzlTTUs1bks2QmVQcHg2ZmVEckdGMTN5Y1hLTkxScGJlaTl6ZGhnVVFUVkNn?= =?utf-8?B?Ukg1aFhZR2dmUXUxbDErZEpxeHpzdHNqL0VlTkhmbkJRbDg4emEzSE5wQzRl?= =?utf-8?B?UGZGekRxdmR4V0JKZ2lSZFAxR2RZYXh1WmpLcmJJajNZdkFSTFBzRWU4NzVY?= =?utf-8?B?S0ZtQlNXdXorNkxFNEVQTDhGbWFXak5xUUZzTlRjR0xDMFRWVkhQUFFHVmds?= =?utf-8?B?Y2hHeVZhQ3hjYnRraWkrNHpuNFpCWithOHVneWtYRlFDYU8xdGpJRC9hNWRi?= =?utf-8?B?clp0UXVTV1NUMDhnL29lOUlWMWhLVE45TFhjVnVuWmJWNFBaYnRudjZtVE5w?= =?utf-8?B?eW51SHF1NjVFdHkwT3VmVUd4ZzJqNFhZQ2k1QldjL2NhYXVKV2t2ZEdxa3hm?= =?utf-8?Q?C4kOsLSqz4zNGMQHOSX3vDSTTMizZGfxtiS4Kvj?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFlGVHd0cmV3MS9IU21FMnpnc2JxR0NPSVQ0R2FsNHQ3K0ZCczJsdXFCYzBx?= =?utf-8?B?OGhzRWJ6NnYza1R3TkxsSWc5OFBKa2RQQVpDYmVLSWVPdG9ta3BwdThnZk5o?= =?utf-8?B?UEgzb3BrMS8rc2M2V3hIMU1aVHl2SWJubjVwcXNjRS9kS3FwODB2bWVKcnYy?= =?utf-8?B?Q1lkOHdrL3RScURzQVVjQVJtMGMzVzE3aCtNaHJJQUNYZHJOc2tPTEFPZWRT?= =?utf-8?B?Y1Fqc2l0UDZjTjBuemhDcVV5RmZ1MDBMRzNHWkdxYTdQTWg4UkNuV21XekNo?= =?utf-8?B?VE9RYjBpcnBIbUs0K2V5SE1mcG54T0k5TGlBTjUwODNmNkZCS25yTi8zK2RY?= =?utf-8?B?YzRsR1ViV1F4TEg3WXh1ZGt0dS94M2V0Z2xkUHZxL3dhcWpDUWo5dE9IeGFS?= =?utf-8?B?QVczMzB1b0RHaVI3aFh1VWFNbTAyKzNTRnhzSWhQNUI5emlENzRCdHZNaG54?= =?utf-8?B?VGlyc3JYY3VuNjQ4OGR2TmFuS2FlRHJWcGEwTHV0K0UzUHllV3NhdG1UNit0?= =?utf-8?B?M3FsN0lFM0RMZ0hyY3lyd1grYXdtMUhMZkUwekdESG5WNks1b01YUm9sTlUx?= =?utf-8?B?SkgyMlBxV1grc2hQRFc3ZENnRytUMStiam4wblM3QW9CTnlvMFZVMUUrcVd3?= =?utf-8?B?dVFPK0w0VXNlQU1rblVHN1hhUFlIUmFqdDdRRXNnbml0OXNWS3greDUwa2Zt?= =?utf-8?B?V21mOS94QnQwVWUrdHlHQWhxa1BpZVBwWUNJM21uUkxKY2M5cnJac3V4T0Jo?= =?utf-8?B?a3NsZzlJOE5aRHYyU0dXVzR3blFMSEdVUHZ1N3JWbElHcVZrOE5tckExcHNu?= =?utf-8?B?ZEFyejBQRmJMQnVQa1VwS0tFdFhyVFluWGp1Q3FUTG1MMkp4dFQ3ZWtiTHVV?= =?utf-8?B?TFRicUZpU3lIQVNsUmRJb2ZGVk9Ddytub3ZnYUluM0hvYlgvWUVWNE9jVCt1?= =?utf-8?B?cFdNUGZzV3huVWc3L3BBUEZQZkpUSnF1QUVNUzJEbWR1VVFVcG53cCtMamgx?= =?utf-8?B?ZTNoa0xaTWxuN3VyQzRGNDlBTUZkYitSbWlWQlpWR2J5WFNKcU91SXltOTFF?= =?utf-8?B?ejN0UThQOUVwWGphd0lOTXVBRlZQMllMS0R6STNKeEU1TklhN0swbFRMK01y?= =?utf-8?B?R0ZpaE8wcjNHWXNQKzlTUG9CbStCSGtvUmR3V1JiSXJrSjhPQnhueWpKQ29O?= =?utf-8?B?RUNoOFkvQnpZOHIwZjlkdklRZ2FpMXBEcjhBU3RGV3JEMEEwTnorT0dwVHRu?= =?utf-8?B?M2NUZmRBRzNLdWhKVGQ4ZkFsQjcrMUNxMVFnR2ZhTlZxMnYrZ2wxak03cXVp?= =?utf-8?B?bnFsa1FLYjYzUDBsYll1YWxTRjlnUDNoeWY2YUVRb04wVmJsZ0RZbzl5MHFa?= =?utf-8?B?Nk84Q2JNT0V6dTdDd1R6OU05dEY1NktmZm1IQ3p6YUYvUkdRdWtOVGRBNVo2?= =?utf-8?B?WEtCbm52NXdMSUFKdE9zVVFZTlJhTUVyVW55Z1J3RGFZNDY3ek9jcFV4Q3Fj?= =?utf-8?B?K1puR09jY3ZlN2pGVGpSNWZFMGEzUDRmZ2Y0NERHM0ZBeklLak5OR1FqcHdt?= =?utf-8?B?b0R3OFA3b1B5WkpjWXltbjFneHUyc004MmFUMC9uY1pkellzQzNBa2JkT2x4?= =?utf-8?B?MVNEMTNFOVlsZjZaNnlRK0ZlU3VvL2lQSXhaUFdocGlZbHRZV2hLZUtpYUE3?= =?utf-8?B?RGhKbkpVUHdJOWp6OVBrV2hRRkgrZWFqb2V1M2NVaWw0a2E4dEVHOC80RlZN?= =?utf-8?B?S2JHK2kvV2thZHNGbkRTcTVxeU1GSlJoc3AvNjZ1dWw5ZlQzVmpubDFBR2lG?= =?utf-8?B?bk1yeHg3amRMR2dndU5vSFE3clBlS0pBcVBaSXpPNEd6VEh4bVNWSXNxdzFX?= =?utf-8?B?cHNsbnNUQzFLU1BPem9tbjBBMktGNzB5KzNhMWYxL095NzBvYVN6TUlVK1hD?= =?utf-8?B?MXdjNThHRGtVNGo3NlNiOHo3ZCt2WlZPUFdSZm4wS1oyZWNRSU9ScHBoUytW?= =?utf-8?B?RXE5d2xCOTdxSUFtWEJHUktEcTdXU3lSMGttdjV6SVArSW56WEhhRm5XMmp5?= =?utf-8?B?Y3NMMDdEWm8ybUFSQVVMWjlkWk4zb3BVbEtSdmw3aEgydVMvMTh2RXhCY0FZ?= =?utf-8?Q?6MS1p0GBHbj00Lmd53029znON?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53b2bbbd-2ff9-491a-38bd-08dcfba1409e X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2024 00:48:37.2863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jo/gPSr5KKhA4oZ168SxTrmoyv2j1yhSeOptxQMPJCinlIkoXiIqIueQKbhLwcBQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9234 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2024 2:57 AM, Chaoyong He wrote: > Implement the necessary functions to allow user to visually identify a > physical port associated with a netdev by blinking an LED on that port. > > Signed-off-by: James Hershaw > Signed-off-by: Chaoyong He > --- > .../net/nfp/flower/nfp_flower_representor.c | 30 ++++++++++++++++ > drivers/net/nfp/nfp_ethdev.c | 2 ++ > drivers/net/nfp/nfp_net_common.c | 32 +++++++++++++++++ > drivers/net/nfp/nfp_net_common.h | 2 ++ > drivers/net/nfp/nfpcore/nfp_nsp.h | 1 + > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 36 +++++++++++++++++++ > 6 files changed, 103 insertions(+) > Can you please update nfp.ini to add LED support. This patch is basically adding LED support, patch title can be updated to reflect this, it is simpler description.