From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0C2575595 for ; Mon, 5 Sep 2016 08:36:57 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 749DA61E7D; Mon, 5 Sep 2016 06:36:56 +0000 (UTC) Received: from [10.72.4.13] (vpn1-4-13.pek2.redhat.com [10.72.4.13]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u856apEO005264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Sep 2016 02:36:54 -0400 To: Thomas Monjalon References: <1472798220-7121-1-git-send-email-jasowang@redhat.com> <2323448.KHrCRZ2JeF@xps13> Cc: dev@dpdk.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com, mst@redhat.com From: Jason Wang Message-ID: <46db62d6-4f24-3f86-c22e-089442e182d2@redhat.com> Date: Mon, 5 Sep 2016 14:36:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2323448.KHrCRZ2JeF@xps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 05 Sep 2016 06:36:56 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 06:36:57 -0000 On 2016年09月02日 20:57, Thomas Monjalon wrote: > 2016-09-02 14:36, Jason Wang: >> Spec said "The PCI Device ID is calculated by adding 0x1040 to the >> Virtio Device ID". So this patch makes pmd can recognize modern virtio >> net id. > Please could you describe what is a modern virtio-net? I think it means the device that only support virtio 1.0. > >> #define VIRTIO_PCI_DEVICEID_MIN 0x1000 >> #define VIRTIO_PCI_DEVICEID_MAX 0x103F >> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 > It doesn't match the sentence above: 1000 + 1040 = 2040 According to the spec (5.1.1), Virtio Device id (not pci device id) is 1. > > By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code. > Yes, we can remove this. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AE098920C for ; Thu, 8 Sep 2016 05:47:00 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 07 Sep 2016 20:47:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,298,1470726000"; d="scan'208";a="5848541" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga006.fm.intel.com with ESMTP; 07 Sep 2016 20:46:59 -0700 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 20:46:59 -0700 Received: from rrsmsp801.amr.corp.intel.com (10.9.230.203) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 20:46:59 -0700 Received: from Pickup by RRSMSP801.amr.corp.intel.com with Microsoft SMTP Server id 14.3.301.0; Wed, 7 Sep 2016 20:53:27 +0000 From: Jason Wang Sender: dev To: Thomas Monjalon CC: , "Xie, Huawei" , , References: <1472798220-7121-1-git-send-email-jasowang@redhat.com> <2323448.KHrCRZ2JeF@xps13> In-Reply-To: <2323448.KHrCRZ2JeF@xps13> Date: Mon, 5 Sep 2016 00:36:46 -0600 Message-ID: <46db62d6-4f24-3f86-c22e-089442e182d2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKyy1v8v+X7HJqdklT5hP6lSkGSugKTM01UAqn7VPY= Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 03:47:01 -0000 Message-ID: <20160905063646.VcqbUS8_xvyZkTsghSLI-YLcxjI3IsfeUCZKvZf_z2c@z> On 2016=E5=B9=B409=E6=9C=8802=E6=97=A5 20:57, Thomas Monjalon wrote: > 2016-09-02 14:36, Jason Wang: >> Spec said "The PCI Device ID is calculated by adding 0x1040 to the >> Virtio Device ID". So this patch makes pmd can recognize modern virtio >> net id. > Please could you describe what is a modern virtio-net? I think it means the device that only support virtio 1.0. > >> #define VIRTIO_PCI_DEVICEID_MIN 0x1000 >> #define VIRTIO_PCI_DEVICEID_MAX 0x103F >> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 > It doesn't match the sentence above: 1000 + 1040 =3D 2040 According to the spec (5.1.1), Virtio Device id (not pci device id) is 1. > > By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code. > Yes, we can remove this. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D54B59366 for ; Thu, 8 Sep 2016 05:47:50 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 07 Sep 2016 20:47:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,298,1470726000"; d="scan'208";a="5848683" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga006.fm.intel.com with ESMTP; 07 Sep 2016 20:47:49 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 20:47:49 -0700 Received: from rrsmsp801.amr.corp.intel.com (10.9.230.203) by ORSMSX112.amr.corp.intel.com (10.22.240.13) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 20:47:48 -0700 Received: from Pickup by RRSMSP801.amr.corp.intel.com with Microsoft SMTP Server id 14.3.301.0; Wed, 7 Sep 2016 20:53:29 +0000 From: Jason Wang To: Thomas Monjalon CC: , "Xie, Huawei" , , References: <1472798220-7121-1-git-send-email-jasowang@redhat.com> <2323448.KHrCRZ2JeF@xps13> In-Reply-To: <2323448.KHrCRZ2JeF@xps13> Date: Mon, 5 Sep 2016 00:36:46 -0600 Message-ID: <46db62d6-4f24-3f86-c22e-089442e182d2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKyy1v8v+X7HJqdklT5hP6lSkGSugKTM01UAqn7VPY= Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 03:47:51 -0000 Message-ID: <20160905063646.ET0QejoRxnBaTUjgIvxBQ6a1l4Uy1ORSRqOidzUdo8Y@z> On 2016=E5=B9=B409=E6=9C=8802=E6=97=A5 20:57, Thomas Monjalon wrote: > 2016-09-02 14:36, Jason Wang: >> Spec said "The PCI Device ID is calculated by adding 0x1040 to the >> Virtio Device ID". So this patch makes pmd can recognize modern virtio >> net id. > Please could you describe what is a modern virtio-net? I think it means the device that only support virtio 1.0. > >> #define VIRTIO_PCI_DEVICEID_MIN 0x1000 >> #define VIRTIO_PCI_DEVICEID_MAX 0x103F >> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 > It doesn't match the sentence above: 1000 + 1040 =3D 2040 According to the spec (5.1.1), Virtio Device id (not pci device id) is 1. > > By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code. > Yes, we can remove this. Thanks