* [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check
@ 2018-04-19 12:00 Juhamatti Kuusisaari
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Juhamatti Kuusisaari @ 2018-04-19 12:00 UTC (permalink / raw)
To: thomas; +Cc: dev, Juhamatti Kuusisaari
Handle properly a case where DPDK_PATCH_PATH is set
to point to a directory.
Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 7676a6b..2bb5458 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -75,7 +75,7 @@ while getopts hn:qv ARG ; do
done
shift $(($OPTIND - 1))
-if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
+if [ ! -f "$DPDK_CHECKPATCH_PATH" ] || [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
print_usage >&2
echo
echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
--
2.8.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check
2018-04-19 12:00 [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check Juhamatti Kuusisaari
@ 2018-04-19 12:00 ` Juhamatti Kuusisaari
2018-04-19 13:24 ` Ferruh Yigit
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Juhamatti Kuusisaari @ 2018-04-19 12:00 UTC (permalink / raw)
To: thomas; +Cc: dev, Juhamatti Kuusisaari
Handle properly a case where DPDK_MAINTAINER_PATH is set
to point to a directory.
Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
---
devtools/get-maintainer.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
index 1e9eabd..b916048 100755
--- a/devtools/get-maintainer.sh
+++ b/devtools/get-maintainer.sh
@@ -23,7 +23,8 @@ print_usage () {
}
# Requires DPDK_GETMAINTAINER_PATH devel config option set
-if [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
+if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
+ [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
print_usage >&2
echo
echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2
--
2.8.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
@ 2018-04-19 13:24 ` Ferruh Yigit
2018-04-20 4:10 ` Kuusisaari, Juhamatti
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-04-19 13:24 UTC (permalink / raw)
To: Juhamatti Kuusisaari, thomas; +Cc: dev
On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote:
> Handle properly a case where DPDK_MAINTAINER_PATH is set
> to point to a directory.
>
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> ---
> devtools/get-maintainer.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
> index 1e9eabd..b916048 100755
> --- a/devtools/get-maintainer.sh
> +++ b/devtools/get-maintainer.sh
> @@ -23,7 +23,8 @@ print_usage () {
> }
>
> # Requires DPDK_GETMAINTAINER_PATH devel config option set
> -if [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
> +if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
> + [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
This isn't an issue but is there a reason that for exact same check you go with
single line check in checkpatches.sh and multi line check in this file?
> print_usage >&2
> echo
> echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check
2018-04-19 13:24 ` Ferruh Yigit
@ 2018-04-20 4:10 ` Kuusisaari, Juhamatti
0 siblings, 0 replies; 6+ messages in thread
From: Kuusisaari, Juhamatti @ 2018-04-20 4:10 UTC (permalink / raw)
To: Ferruh Yigit, thomas; +Cc: dev
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Thursday, April 19, 2018 4:25 PM
> To: Kuusisaari, Juhamatti <Juhamatti.Kuusisaari@coriant.com>;
> thomas@monjalon.net
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script
> execution check
>
> On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote:
> > Handle properly a case where DPDK_MAINTAINER_PATH is set to point to a
> > directory.
> >
> > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> > ---
> > devtools/get-maintainer.sh | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
> > index 1e9eabd..b916048 100755
> > --- a/devtools/get-maintainer.sh
> > +++ b/devtools/get-maintainer.sh
> > @@ -23,7 +23,8 @@ print_usage () {
> > }
> >
> > # Requires DPDK_GETMAINTAINER_PATH devel config option set -if [ ! -x
> > "$DPDK_GETMAINTAINER_PATH" ] ; then
> > +if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
> > + [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
>
> This isn't an issue but is there a reason that for exact same check you go with
> single line check in checkpatches.sh and multi line check in this file?
The line was getting long, that is the reason.
> > print_usage >&2
> > echo
> > echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check
2018-04-19 12:00 [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check Juhamatti Kuusisaari
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
@ 2018-04-19 13:21 ` Ferruh Yigit
2018-05-22 21:34 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-04-19 13:21 UTC (permalink / raw)
To: Juhamatti Kuusisaari, thomas; +Cc: dev
On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote:
> Handle properly a case where DPDK_PATCH_PATH is set
> to point to a directory.
>
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
@ 2018-05-22 21:34 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-05-22 21:34 UTC (permalink / raw)
To: Juhamatti Kuusisaari; +Cc: dev, Ferruh Yigit
19/04/2018 15:21, Ferruh Yigit:
> On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote:
> > Handle properly a case where DPDK_PATCH_PATH is set
> > to point to a directory.
> >
> > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
>
> For series,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-22 21:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 12:00 [dpdk-dev] [PATCH v2 1/2] devtools: improve kernel script execution check Juhamatti Kuusisaari
2018-04-19 12:00 ` [dpdk-dev] [PATCH v2 2/2] " Juhamatti Kuusisaari
2018-04-19 13:24 ` Ferruh Yigit
2018-04-20 4:10 ` Kuusisaari, Juhamatti
2018-04-19 13:21 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-05-22 21:34 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).