From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15562A00BE; Tue, 19 Apr 2022 12:47:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6F2C4068E; Tue, 19 Apr 2022 12:47:53 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id E207240687 for ; Tue, 19 Apr 2022 12:47:51 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 49C1D5C013F; Tue, 19 Apr 2022 06:47:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 19 Apr 2022 06:47:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1650365271; x= 1650451671; bh=UBEztvtoOHDgRTFJzp1uMtwm1/0bkXG1hRhByZXOdrQ=; b=N fL3NDj9hc4ikYbw/SmVMszxZ1VU15zYPucJcGCABiH0v33NzSWw55lZGmHEpTFhL iyO7LGftU6GjxSYfWFoAoJQCBrPjlMv+mEdi8L5lxnaKzUU9DPRIOlZVsuAEVWcq duorhUo8e6vkiul0UzwZFcJDMAVv9EP1vmtcPxdZhmp4xNFl5RI/UV+gbNeON1Wf VvGd9m8yrD+Og+LxcVM8n8ASPJSIquLVc4CpsoFtvDFakKSkYe34pVbU6p6lQVDj jz0cEacO+5O9/pZhKvQ3JZbaFTgfcxmL3+YHNW4i7rGJmWsgFJyLJxtmwUVLNFg8 jMX4cc0u/3rPLbGnZeL9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650365271; x=1650451671; bh=UBEztvtoOHDgR TFJzp1uMtwm1/0bkXG1hRhByZXOdrQ=; b=nlnYsvzFxCSa1uK7l6ZOh01pF2T+0 KBNW734kYM2wZCcVXJdl1RA6gKpcZ4LbVgSZp4vdQldgvA/1/hMJOFihhS3O6x2D CwQ1WrWH3D2oQ3g6NSftfgda86bdLaq02jCCl6hSiMLTIeNbhMAoFyvaalHyKwSE vNLijgHC7/MpYhVJ3fHL0D4M3GSYVIAMML1RnIyVStaVc6/JlCiewNTXlFmC/aXG ylb8LSXlAcQFDa9Djihq6+OdsEubMRJXHC5j/nv/oPbB+h8mQ/mA3JkB42N0aqcP J8OoiA1fB9FRUMTC4SySbV1tuIMc6WxJYUvk6WWPwC8bd8VBpd7Asuelw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddtfedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeiteefheffgeegjeehveeufffgjeekjeehteeuvdeiueejkedt uedvuddtkefhnecuffhomhgrihhnpehsthhrohhnghhsfigrnhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhho nhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Apr 2022 06:47:49 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: "dev@dpdk.org" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "konstantin.ananyev@intel.com" , "ciara.power@intel.com" , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru , mdr@ashroe.eu Subject: Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Date: Tue, 19 Apr 2022 12:47:48 +0200 Message-ID: <4703969.GXAFRqVoOG@thomas> In-Reply-To: References: <20220217172341.607360-1-gakhil@marvell.com> <11961195.O9o76ZdvQC@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/04/2022 12:14, Akhil Goyal: > Hi Thomas, > > > 16/04/2022 21:25, Akhil Goyal: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > > /** Soft byte expiry of SA */ > > > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > > > + /** Soft packet expiry of SA */ > > > > Is there a reference explaining what exactly is a "soft packet expiry"? > > SA expiry is a very common procedure in case of IPsec. > And all stacks must support this feature. > You can refer https://docs.strongswan.org/strongswan-docs/5.9/config/rekeying.html > For details. > Time expiry means after x seconds SA will expire. > Packet expiry means after x packets processing SA will expire. > Byte expiry means after x bytes of packet processing SA will expire. I think you should use the syntax @ref packets_soft_limit so it is clear where the event come from. > > I think you should also mention what should be done > > in the event handler. > > I believe this is quite obvious as per IPsec specifications. > Application need to start rekeying or SA need to be created again. Yes indeed. > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > > > + /** Hard byte expiry of SA */ > > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > > > + /** Hard packet expiry of SA */ > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > > > > Same comment for the 3 events. > > > > > /** Max value of this enum */ > > > RTE_ETH_EVENT_IPSEC_MAX > > > }; > > > > What is the impact of this "MAX" value on ABI compatibility? > > I see no issues reported while running ABI check. > There is no array being used inside library based on MAX. No need of array inside the library, the events are exposed to the app. I'm surprised libabigail is OK with changing an enum value.