From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2E10C200 for ; Tue, 1 May 2018 16:04:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CD4AE20FF9; Tue, 1 May 2018 10:04:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 01 May 2018 10:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=z/euj8JWf0T/6gds2DF+xh1yCF N38yQR/TDvqF1zKzQ=; b=k9OJFTO4k7BxlMVIRuhLxKflRO1Ic0+Iitpf4s7BR0 J/jlBw2m/cdbY/j0pHTaWGKuCQ0YexNkxQZGnNJB27TpT4K6YYshvHJmjLRzA641 XNvszuR3FK3JSHt8ueaU5BKFs5re25czZ05MZ0cR168LqqhrXxHjO0tUs7S8IB78 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=z/euj8 JWf0T/6gds2DF+xh1yCFN38yQR/TDvqF1zKzQ=; b=XV8FU27tFSGgMHzEtC3Jlq KgrHo5E3FTAFi71Vk8eybZyGcLjPAgSODAh9MoUA6rRAyEtwXohWQSxiOjl4rC/L SQ/GEHTPPE3gAxpzG/HZr3OdjqB5crgVYtw6GhFRCfwAIIBNXM4ihG7tGWiLMUtH OK9r0au2pLHrFWYKY1Gk2cyBa5EUSiuopTEGeRqLgE2f/KfKXqqDKvFj3tT07k6r QCtYwdskHbOnyQM5JBTs91ZLtqNnf5dMTZdD30ZLxtmxwlbG7nttspSREPqBbYQJ q/b6fhl0VDsc24IZSH1/AON4d8XHyqzFJl4b/vL0VCSkmRMTHo2hi3S2y5D/AZAA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6BB55E4488; Tue, 1 May 2018 10:04:44 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Xueming Li , Shahaf Shuler , Nelio Laranjeiro , Wenzhuo Lu , Jingjing Wu , Adrien Mazarguil , dev@dpdk.org, John McNamara , Qi Zhang Date: Tue, 01 May 2018 16:04:43 +0200 Message-ID: <4704748.XbhYmuginu@xps> In-Reply-To: <03cfea68-a04f-e36d-add8-beca273be5ba@intel.com> References: <20180409121035.148813-1-xuemingl@mellanox.com> <6300361.pQ73498XhG@xps> <03cfea68-a04f-e36d-add8-beca273be5ba@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add supported hash function check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 14:04:46 -0000 01/05/2018 13:04, Ferruh Yigit: > On 4/23/2018 7:14 PM, Thomas Monjalon wrote: > > 23/04/2018 18:06, Ferruh Yigit: > >> On 4/20/2018 3:30 PM, Xueming Li wrote: > >>> Add supported RSS hash function check in device configuration to > >>> have better error verbosity for application developers. > >>> > >>> Signed-off-by: Xueming Li > >>> Acked-by: Adrien Mazarguil > >>> > >>> + /* Check that device supports requested rss hash functions. */ > >>> + if ((dev_info.flow_type_rss_offloads | > >>> + dev_conf->rx_adv_conf.rss_conf.rss_hf) != > >>> + dev_info.flow_type_rss_offloads) { > >>> + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: " > >>> + "0x%"PRIx64", valid value: 0x%"PRIx64"\n", > >>> + port_id, > >>> + dev_conf->rx_adv_conf.rss_conf.rss_hf, > >>> + dev_info.flow_type_rss_offloads); > >>> + return -EINVAL; > >>> + } > >> > >> Hi Thomas, > >> > >> This can break the PMDs that are not setting flow_type_rss_offloads properly. > >> How can we highlight this so that PMD owners can double check? > > > > Can we have a check-list in the RC1 announce email? > > Hi Thomas, Xueming, > > This change is breaking multiple sample applications, testpmd was also broken > but already fixed by Qi [1]. > > Indeed this patch should update sample applications and testpmd as well when > doing an ethdev API update, also should update release notes "API Changes" section. > > We can fix sample applications for rc2, but same thing also can hit users. > > Or for this release we can remote returning error, instead update log message to > error. Next release add the return and change log message back to debug. > > What do you think? Yes: 1/ update the API doc and sample apps in 18.05 2/ send a deprecation notice 3/ add error return in 18.08 I've replied to your patch too: http://dpdk.org/ml/archives/dev/2018-May/099865.html