From: Thomas Monjalon <thomas@monjalon.net>
To: eagostini@nvidia.com, Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver
Date: Tue, 16 Nov 2021 17:40:24 +0100 [thread overview]
Message-ID: <4706258.s6B8IiG2J6@thomas> (raw)
In-Reply-To: <20211116075811.02433921@hermes.local>
16/11/2021 16:58, Stephen Hemminger:
> Minor comments, overall looks fine.
>
>
> +/* CUDA Driver functions loaded with dlsym() */
> +CUresult CUDAAPI (*sym_cuInit)(unsigned int flags) = NULL;
> +CUresult CUDAAPI (*sym_cuDriverGetVersion)(int *driverVersion) = NULL;
> +CUresult CUDAAPI (*sym_cuGetProcAddress)(const char *symbol,
> + void **pfn, int cudaVersion, uint64_t flags) = NULL;
> +
>
> Can these be local (static) since not prefixed with driver specific name.
> Also global variables are always loaded as zero so NULL initialization is
> unnecessary. For other types checkpatch would complain.
>
>
> > +/* NVIDIA GPU address map */
> > +static struct rte_pci_id pci_id_cuda_map[] = {
>
> Can this be const?
On a separate note, Elena did what you suggested for the logtype variable:
static RTE_LOG_REGISTER_DEFAULT(cuda_logtype, NOTICE);
So cuda_logtype is static.
I think we should do the same for all DPDK logtypes.
Volunteer for a patch?
next prev parent reply other threads:[~2021-11-16 16:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 22:49 [dpdk-dev] [RFC PATCH] " eagostini
2021-11-04 2:01 ` [dpdk-dev] [PATCH v2 0/1] " eagostini
2021-11-04 2:01 ` [dpdk-dev] [PATCH v2 1/1] " eagostini
2021-11-03 18:15 ` Stephen Hemminger
2021-11-08 18:35 ` Stephen Hemminger
2021-11-08 18:39 ` Elena Agostini
2021-11-08 18:59 ` Stephen Hemminger
2021-11-08 19:07 ` Elena Agostini
2021-11-08 19:02 ` [dpdk-dev] [RFC PATCH] " Stephen Hemminger
2021-11-08 21:20 ` Elena Agostini
2021-11-08 22:07 ` Stephen Hemminger
2021-11-08 23:15 ` Stephen Hemminger
2021-11-09 2:28 ` [dpdk-dev] [PATCH v3 0/1] " eagostini
2021-11-09 2:28 ` [dpdk-dev] [PATCH v3 1/1] " eagostini
2021-11-08 19:52 ` David Marchand
2021-11-09 5:50 ` [dpdk-dev] [PATCH v4 0/1] " eagostini
2021-11-09 5:50 ` [dpdk-dev] [PATCH v4 1/1] " eagostini
2021-11-15 22:36 ` [PATCH v5 0/1] " eagostini
2021-11-15 22:36 ` [PATCH v5 1/1] " eagostini
2021-11-16 20:47 ` [PATCH v6 0/1] " eagostini
2021-11-16 20:47 ` [PATCH v6 1/1] " eagostini
2021-11-16 22:50 ` [PATCH v7 0/1] " eagostini
2021-11-16 22:50 ` [PATCH v7 1/1] " eagostini
2021-11-16 15:58 ` Stephen Hemminger
2021-11-16 16:35 ` Thomas Monjalon
2021-11-16 16:40 ` Thomas Monjalon [this message]
2021-11-16 16:30 ` Thomas Monjalon
2021-11-16 16:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4706258.s6B8IiG2J6@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).