From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alfredo Cardigliano <cardigliano@ntop.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD
Date: Tue, 10 Dec 2019 18:57:30 +0000 [thread overview]
Message-ID: <47087dc7-f68e-3968-61ff-b5a11ea08568@intel.com> (raw)
In-Reply-To: <20191209214656.27347-1-cardigliano@ntop.org>
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote:
> The patch series provides an initial version of a
> poll mode driver for Pensando network adapters.
> The driver name is ionic.
>
> v3 Changes:
> ----------
> - Set the license to BSD-3 (in addition to GPL-2)
> - Add the new PMD driver to the release notes
> - Add a link to the adapter vendor page
> - Cleanup the makefile (compilation flags, libraries, etc)
> - Fix clang build errors
> - Fix indentation according to the dpdk coding style
> - Cleanup log functions and macros
> - Set min/max mtu to be checked by the API
> - Uninitialize device in close dev_ops
> - Fix VLAN offload support
> - Initialize stats struct
> - Move structures size check
> - Other minor code cleanup
>
> Signed-off-by: Alfredo Cardigliano <cardigliano@ntop.org>
> Reviewed-by: Shannon Nelson <snelson@pensando.io>
>
> Alfredo Cardigliano (17):
> net/ionic: add skeleton
> net/ionic: add hardware structures definitions
> net/ionic: add log
> net/ionic: register and initialize the adapter
> net/ionic: add port management commands
> net/ionic: add basic lif support
> net/ionic: add doorbells
> net/ionic: add adminq support
> net/ionic: add notifyq support
> net/ionic: add basic port operations
> net/ionic: add RX filters support
> net/ionic: add Flow Control support
> net/ionic: add RX and TX handling
> net/ionic: add RSS support
> net/ionic: add stats
> net/ionic: add TX checksum support
> net/ionic: read fw version
Hi Alfredo,
License issue still needs to be cleared.
There is shared build errors, I mentioned details in the patch, can you please
be sure shared build works in next version?
Also can you please run in-house scripts and be sure the issues they identified
are addressed:
./devtools/checkpatches.sh
./devtools/check-git-log.sh
And I already put some comments to the individual patches.
Thanks,
ferruh
prev parent reply other threads:[~2019-12-10 18:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 21:46 Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton Alfredo Cardigliano
2019-12-10 18:48 ` Ferruh Yigit
2019-12-12 12:01 ` Alfredo Cardigliano
2019-12-12 12:39 ` Ferruh Yigit
2019-12-12 14:09 ` Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano
2019-12-10 18:48 ` Ferruh Yigit
2019-12-13 10:25 ` Hemant Agrawal
2019-12-17 19:46 ` Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 03/17] net/ionic: add log Alfredo Cardigliano
2019-12-10 18:49 ` Ferruh Yigit
2019-12-13 10:22 ` Hemant Agrawal
2019-12-10 18:49 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano
2019-12-10 18:50 ` Ferruh Yigit
2019-12-12 12:04 ` Alfredo Cardigliano
2019-12-12 12:42 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 05/17] net/ionic: add port management commands Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 06/17] net/ionic: add basic lif support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 07/17] net/ionic: add doorbells Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 08/17] net/ionic: add adminq support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 09/17] net/ionic: add notifyq support Alfredo Cardigliano
2019-12-10 18:53 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 10/17] net/ionic: add basic port operations Alfredo Cardigliano
2019-12-10 18:50 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 11/17] net/ionic: add RX filters support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 12/17] net/ionic: add Flow Control support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 13/17] net/ionic: add RX and TX handling Alfredo Cardigliano
2019-12-10 18:51 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 14/17] net/ionic: add RSS support Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 15/17] net/ionic: add stats Alfredo Cardigliano
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 16/17] net/ionic: add TX checksum support Alfredo Cardigliano
2019-12-10 18:52 ` Ferruh Yigit
2019-12-09 21:46 ` [dpdk-dev] [PATCH v3 17/17] net/ionic: read fw version Alfredo Cardigliano
2019-12-10 18:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47087dc7-f68e-3968-61ff-b5a11ea08568@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).