DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx
Date: Mon, 11 Oct 2021 17:51:08 +0300
Message-ID: <4710ce54-b0b1-8c41-85ca-38cd13c2b5b1@oktetlabs.ru> (raw)
In-Reply-To: <YVTf2P2iVJlzb73n@platinum>

Hi Olivier,

On 9/30/21 12:51 AM, Olivier Matz wrote:
> Hi Andrew,
> 
> On Wed, Sep 29, 2021 at 10:37:34AM +0300, Andrew Rybchenko wrote:
>> Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
>> should be used as a replacement.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> FYI, I just submitted a patchset that removes all PKT_ flags and
> fixes the namespace. I will rebase it on top of your patch.

I'm sorry for inconvenience.

>> ---
>>  doc/guides/rel_notes/deprecation.rst   | 7 +------
>>  doc/guides/rel_notes/release_21_11.rst | 3 +++
>>  lib/mbuf/rte_mbuf_core.h               | 7 -------
>>  3 files changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 59445a6f42..3175426dad 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -42,7 +42,7 @@ Deprecation Notices
>>  * mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
>>    A compatibility layer will be kept until DPDK 22.11, except for the flags
>>    that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``,
>> -  ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>> +  ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>>  
> 
> I think this one should not be modified.
> 
> You can add my ack to the v2.

Fixed in v2.

Thanks,
Andrew.

  reply	other threads:[~2021-10-11 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  7:37 Andrew Rybchenko
2021-09-29 21:51 ` Olivier Matz
2021-10-11 14:51   ` Andrew Rybchenko [this message]
2021-10-11 14:28 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-10-13 21:03   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4710ce54-b0b1-8c41-85ca-38cd13c2b5b1@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git