From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A0B182FDD for ; Tue, 4 Apr 2017 19:12:15 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 04 Apr 2017 10:12:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="841772375" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 04 Apr 2017 10:12:13 -0700 To: Allain Legacy References: <20170404163654.86100-1-allain.legacy@windriver.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> Date: Tue, 4 Apr 2017 18:12:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170404163654.86100-1-allain.legacy@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 17:12:16 -0000 On 4/4/2017 5:36 PM, Allain Legacy wrote: > The AVP devices are only supported on Intel 64-bit architectures so > adjusting the defconfig attributes accordingly. > > Fixes: c5ab4707ba97 ("net/avp: support driver registration") > > Signed-off-by: Allain Legacy > --- > config/common_linuxapp | 1 - > config/defconfig_i686-native-linuxapp-gcc | 5 ----- > config/defconfig_i686-native-linuxapp-icc | 5 ----- > config/defconfig_x86_64-native-linuxapp-clang | 5 +++++ Right now compiler config files only have compiler and architecture configs, although it is OK to update them, to be consistent with what other PMDs did, what do you think: Keep AVP config enabled in "common_linuxapp" Disable AVP in following configs: defconfig_arm64-armv8a-linuxapp-gcc defconfig_arm-armv7a-linuxapp-gcc defconfig_ppc_64-power8-linuxapp-gcc > config/defconfig_x86_64-native-linuxapp-gcc | 6 ++++++ > config/defconfig_x86_64-native-linuxapp-icc | 5 +++++ > config/defconfig_x86_x32-native-linuxapp-gcc | 5 ----- > 7 files changed, 16 insertions(+), 16 deletions(-) > <...>