DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Hajkowski <marcinx.hajkowski@intel.com>, david.hunt@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types
Date: Tue, 19 Mar 2019 11:58:48 +0000	[thread overview]
Message-ID: <4716aa77-e4d2-6991-0482-8aa6ff34f57e@intel.com> (raw)
In-Reply-To: <20190318115647.14784-4-marcinx.hajkowski@intel.com>

On 18-Mar-19 11:56 AM, Hajkowski wrote:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> 
> Test all existing power environment configuration to verify if related
> data is properly initialized and clean in set/unset scenarios.
> 
> Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> ---

<snip>

> +
>   	rte_power_unset_env();
> +
> +	/* Perform tests for valid environments.*/
> +	const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ,
> +						PM_ENV_KVM_VM,
> +						PM_ENV_PSTATE_CPUFREQ};

Extreme nitpicking, but i believe we use two indentation levels for 
continuation.

Otherwise

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2019-03-19 11:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 11:56 [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification Hajkowski
2019-03-18 11:56 ` Hajkowski
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 10:57   ` Burakov, Anatoly
2019-03-19 10:57     ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 10:58   ` Burakov, Anatoly
2019-03-19 10:58     ` Burakov, Anatoly
2019-03-18 11:56 ` [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types Hajkowski
2019-03-18 11:56   ` Hajkowski
2019-03-19 11:58   ` Burakov, Anatoly [this message]
2019-03-19 11:58     ` Burakov, Anatoly
2019-03-18 15:01 ` [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification Stephen Hemminger
2019-03-18 15:01   ` Stephen Hemminger
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-19 10:57   ` Burakov, Anatoly
2019-03-29 14:14 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-03-29 14:14   ` Thomas Monjalon
2019-03-29 15:09   ` Burakov, Anatoly
2019-03-29 15:09     ` Burakov, Anatoly
2020-10-25 18:22     ` Thomas Monjalon
2020-10-28 13:53       ` David Hunt
2020-10-28 14:16         ` Thomas Monjalon
2019-04-05 14:35 ` [dpdk-dev] [PATCH] " Hajkowski
2019-04-05 14:35   ` Hajkowski
2019-04-22 20:22   ` Thomas Monjalon
2019-04-22 20:22     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4716aa77-e4d2-6991-0482-8aa6ff34f57e@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=marcinx.hajkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).