From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C7FABA3 for ; Tue, 19 Mar 2019 12:58:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 04:58:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="143269651" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.83]) ([10.237.220.83]) by orsmga002.jf.intel.com with ESMTP; 19 Mar 2019 04:58:49 -0700 To: Hajkowski , david.hunt@intel.com Cc: dev@dpdk.org References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <20190318115647.14784-4-marcinx.hajkowski@intel.com> From: "Burakov, Anatoly" Message-ID: <4716aa77-e4d2-6991-0482-8aa6ff34f57e@intel.com> Date: Tue, 19 Mar 2019 11:58:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190318115647.14784-4-marcinx.hajkowski@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 11:58:52 -0000 On 18-Mar-19 11:56 AM, Hajkowski wrote: > From: Marcin Hajkowski > > Test all existing power environment configuration to verify if related > data is properly initialized and clean in set/unset scenarios. > > Signed-off-by: Marcin Hajkowski > --- > + > rte_power_unset_env(); > + > + /* Perform tests for valid environments.*/ > + const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ, > + PM_ENV_KVM_VM, > + PM_ENV_PSTATE_CPUFREQ}; Extreme nitpicking, but i believe we use two indentation levels for continuation. Otherwise Acked-by: Anatoly Burakov -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 141F1A00E6 for ; Tue, 19 Mar 2019 12:58:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 028501B19; Tue, 19 Mar 2019 12:58:53 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C7FABA3 for ; Tue, 19 Mar 2019 12:58:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 04:58:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,497,1544515200"; d="scan'208";a="143269651" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.83]) ([10.237.220.83]) by orsmga002.jf.intel.com with ESMTP; 19 Mar 2019 04:58:49 -0700 To: Hajkowski , david.hunt@intel.com Cc: dev@dpdk.org References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <20190318115647.14784-4-marcinx.hajkowski@intel.com> From: "Burakov, Anatoly" Message-ID: <4716aa77-e4d2-6991-0482-8aa6ff34f57e@intel.com> Date: Tue, 19 Mar 2019 11:58:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190318115647.14784-4-marcinx.hajkowski@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319115848.OaES478M3Zmd2_umjFL5n5JanmH2t7GKm8i_B_j3MM0@z> On 18-Mar-19 11:56 AM, Hajkowski wrote: > From: Marcin Hajkowski > > Test all existing power environment configuration to verify if related > data is properly initialized and clean in set/unset scenarios. > > Signed-off-by: Marcin Hajkowski > --- > + > rte_power_unset_env(); > + > + /* Perform tests for valid environments.*/ > + const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ, > + PM_ENV_KVM_VM, > + PM_ENV_PSTATE_CPUFREQ}; Extreme nitpicking, but i believe we use two indentation levels for continuation. Otherwise Acked-by: Anatoly Burakov -- Thanks, Anatoly