From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF88EA04DB; Fri, 16 Oct 2020 12:34:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 141671ECBA; Fri, 16 Oct 2020 12:34:00 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5F70F1ECB1 for ; Fri, 16 Oct 2020 12:33:58 +0200 (CEST) IronPort-SDR: F3In+BBf5t1cOIGPk+VRuwKIUX5jpR6BGY55atROrL5H9hF0rZowuz3O/8BwiIFrCOTFGRlLgz HWs7KJkRlrtg== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="165814306" X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="165814306" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 03:33:56 -0700 IronPort-SDR: 9Y5BLPGo61pXwr6yFPJr0BeNz+yJCxyvNy6a4r3Vzj3suhc12YopKtbRDDRSTxbeOJyAEB4o12 Jqyn631BGJpA== X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="531667886" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 03:33:55 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201014055517.1214386-1-jiawenwu@trustnetic.com> <20201014055517.1214386-3-jiawenwu@trustnetic.com> <001d01d6a3a2$0d405e40$27c11ac0$@trustnetic.com> From: Ferruh Yigit Message-ID: <472e7ebb-0836-3689-4893-b1b69020cbed@intel.com> Date: Fri, 16 Oct 2020 11:33:51 +0100 MIME-Version: 1.0 In-Reply-To: <001d01d6a3a2$0d405e40$27c11ac0$@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 02/56] net/txgbe: add ethdev probe and remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2020 10:52 AM, Jiawen Wu wrote: > On 10/15/2020 8:56 AM Ferruh Yigit wrote: >> On 10/14/2020 6:54 AM, Jiawen Wu wrote: >>> Add basic PCIe ethdev probe and remove. >>> >>> Signed-off-by: Jiawen Wu >> >> <...> >> >>> +RTE_LOG_REGISTER(txgbe_logtype_init, pmd.net.txgbe.init, NOTICE); >>> +RTE_LOG_REGISTER(txgbe_logtype_driver, pmd.net.txgbe.driver, NOTICE); >>> + >>> +#ifdef RTE_LIBRTE_TXGBE_DEBUG_RX >>> + RTE_LOG_REGISTER(txgbe_logtype_rx, pmd.net.txgbe.rx, DEBUG); #endif >>> +#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX >>> + RTE_LOG_REGISTER(txgbe_logtype_tx, pmd.net.txgbe.tx, DEBUG); #endif >>> + >>> +#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX_FREE >>> + RTE_LOG_REGISTER(txgbe_logtype_tx_free, pmd.net.txgbe.tx_free, >>> +DEBUG); #endif >> >> Can you please document available logging types in the driver documentation? >> ("pmd.net.txgbe.init", .. etc) > > Since there is no config/common_base, which file should I add the default values > of these config parameters? (RTE_LIBRTE_TXGBE_DEBUG_RX .. etc) > > There is no way to provide default values now [1], or no place to list the existing config options. In meson these compile time flags can be provided as arguments to build, like meson -Dc_args="-DRTE_LIBRTE_TXGBE_DEBUG_RX" build That is why, 1- We are trying to reduce compile time flags as much as possible. 2- For the compile time flags we can't remove, they need to be listed/documented in the driver documentation (doc/guides/nics/txgbe.rst for your case), so that users can be aware of them and can use them. Please check following sfc patch sent recently, it may help as sample: https://patches.dpdk.org/patch/80514/ Please document all build options that driver use. Thanks, ferruh [1] Indeed there is a way, it is 'config/rte_config.h', but that is only for the cases we have to add the compile time, many driver config doesn't qualify this, I believe including above discussed ones.