* [dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx
@ 2017-08-01 16:35 Yongseok Koh
2017-08-03 21:19 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2017-08-01 16:35 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Yongseok Koh
The data_off field of newly allocated mbufs is stale data. This shouldn't
be used in calculating Rx address for device when posting free buffers.
RTE_PKTMBUF_HEADROOM should be used instead and data_off of a mbuf will be
reset on packet reception anyway.
Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
index 74e595386..9be48a0c9 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
@@ -568,7 +568,8 @@ rxq_replenish_bulk_mbuf(struct rxq *rxq, uint16_t n)
return;
}
for (i = 0; i < n; ++i)
- wq[i].addr = htonll(rte_pktmbuf_mtod(elts[i], uintptr_t));
+ wq[i].addr = htonll((uintptr_t)elts[i]->buf_addr +
+ RTE_PKTMBUF_HEADROOM);
rxq->rq_ci += n;
rte_wmb();
*rxq->rq_db = htonl(rxq->rq_ci);
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx
2017-08-01 16:35 [dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx Yongseok Koh
@ 2017-08-03 21:19 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-08-03 21:19 UTC (permalink / raw)
To: Yongseok Koh; +Cc: dev, adrien.mazarguil, nelio.laranjeiro
01/08/2017 18:35, Yongseok Koh:
> The data_off field of newly allocated mbufs is stale data. This shouldn't
> be used in calculating Rx address for device when posting free buffers.
> RTE_PKTMBUF_HEADROOM should be used instead and data_off of a mbuf will be
> reset on packet reception anyway.
>
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-01 16:35 [dpdk-dev] [PATCH] net/mlx5: fix buffer address posting in vectorized Rx Yongseok Koh
2017-08-03 21:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).